Hive
  1. Hive
  2. HIVE-4045

Modify PreDropPartitionEvent to pass Table parameter

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.11.0
    • Component/s: Metastore
    • Labels:
      None

      Description

      MetaStorePreEventListener which implements onEvent(PreEventContext context) sometimes needs to access Table properties when PreDropPartitionEvent is listened to.

      1. HIVE-4045.2.patch.txt
        3 kB
        Li Yang
      2. HIVE-4045.1.patch.txt
        3 kB
        Li Yang

        Activity

        Show
        Namit Jain added a comment - https://reviews.facebook.net/D8757
        Hide
        Li Yang added a comment -
        Show
        Li Yang added a comment - diff is at: https://reviews.facebook.net/D8757
        Hide
        Li Yang added a comment -

        Namit,

        Can you please review this change?

        Thanks,
        Li

        Show
        Li Yang added a comment - Namit, Can you please review this change? Thanks, Li
        Hide
        Kevin Wilfong added a comment -

        Comments on Phabricator

        Show
        Kevin Wilfong added a comment - Comments on Phabricator
        Hide
        Pamela Vagata added a comment -

        Kevin, Namit - Li has updated the diff with a unit test, could one of you take a look at the diff?

        Show
        Pamela Vagata added a comment - Kevin, Namit - Li has updated the diff with a unit test, could one of you take a look at the diff?
        Hide
        Kevin Wilfong added a comment -

        +1

        Show
        Kevin Wilfong added a comment - +1
        Hide
        Kevin Wilfong added a comment -

        Li, can you update the patch attached to the JIRA?

        Show
        Kevin Wilfong added a comment - Li, can you update the patch attached to the JIRA?
        Hide
        Pamela Vagata added a comment -

        Thanks Kevin!

        Show
        Pamela Vagata added a comment - Thanks Kevin!
        Hide
        Li Yang added a comment -

        Thanks Kevin. I've updated the patch.

        Show
        Li Yang added a comment - Thanks Kevin. I've updated the patch.
        Hide
        Kevin Wilfong added a comment -

        Committed, thanks Li.

        Show
        Kevin Wilfong added a comment - Committed, thanks Li.
        Hide
        Li Yang added a comment -

        Thanks Kevin!

        Show
        Li Yang added a comment - Thanks Kevin!
        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-h0.21 #2011 (See https://builds.apache.org/job/Hive-trunk-h0.21/2011/)
        HIVE-4045. Modify PreDropPartitionEvent to pass Table parameter. (Li Yang via kevinwilfong) (Revision 1455282)

        Result = SUCCESS
        kevinwilfong : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1455282
        Files :

        • /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
        • /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/PreDropPartitionEvent.java
        • /hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java
        Show
        Hudson added a comment - Integrated in Hive-trunk-h0.21 #2011 (See https://builds.apache.org/job/Hive-trunk-h0.21/2011/ ) HIVE-4045 . Modify PreDropPartitionEvent to pass Table parameter. (Li Yang via kevinwilfong) (Revision 1455282) Result = SUCCESS kevinwilfong : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1455282 Files : /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/PreDropPartitionEvent.java /hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java
        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-hadoop2 #138 (See https://builds.apache.org/job/Hive-trunk-hadoop2/138/)
        HIVE-4045. Modify PreDropPartitionEvent to pass Table parameter. (Li Yang via kevinwilfong) (Revision 1455282)

        Result = FAILURE
        kevinwilfong : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1455282
        Files :

        • /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
        • /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/PreDropPartitionEvent.java
        • /hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java
        Show
        Hudson added a comment - Integrated in Hive-trunk-hadoop2 #138 (See https://builds.apache.org/job/Hive-trunk-hadoop2/138/ ) HIVE-4045 . Modify PreDropPartitionEvent to pass Table parameter. (Li Yang via kevinwilfong) (Revision 1455282) Result = FAILURE kevinwilfong : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1455282 Files : /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/PreDropPartitionEvent.java /hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java

          People

          • Assignee:
            Li Yang
            Reporter:
            Li Yang
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development