Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-3505

log4j template has logging threshold that hides all audit logs

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.10.0
    • Component/s: Logging
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      With the "template" for log4j configuration provided in the tarball, audit logging is hidden (it's logged as "INFO"). By making the log threshold a parameter, this information remains hidden when using the CLI (which is desired) but can be overridden when starting services to enable audit-logging.

      (This is primarily so that Hive is more functional out-of-the-box as installed by Apache Bigtop).

      1. HIVE-3505.patch.1
        0.8 kB
        Sean Mackrory
      2. HIVE-3505.patch.2
        0.7 kB
        Sean Mackrory
      3. HIVE-3505.patch.3
        1 kB
        Sean Mackrory
      4. HIVE-3505.patch.4
        1 kB
        Sean Mackrory

        Issue Links

          Activity

          Hide
          mackrorysd Sean Mackrory added a comment -
          Show
          mackrorysd Sean Mackrory added a comment - Code review here: https://reviews.apache.org/r/7238/
          Hide
          cwsteinbach Carl Steinbach added a comment -

          @Sean: comments on reviewboard. Thanks.

          Show
          cwsteinbach Carl Steinbach added a comment - @Sean: comments on reviewboard. Thanks.
          Hide
          mackrorysd Sean Mackrory added a comment -

          This patch fixes a typo that existed on these lines before this fix. This patch is also in SVN format (as opposed to git).

          Show
          mackrorysd Sean Mackrory added a comment - This patch fixes a typo that existed on these lines before this fix. This patch is also in SVN format (as opposed to git).
          Hide
          cwsteinbach Carl Steinbach added a comment -

          +1. Will commit if tests pass.

          Show
          cwsteinbach Carl Steinbach added a comment - +1. Will commit if tests pass.
          Hide
          cwsteinbach Carl Steinbach added a comment -

          @Sean: Actually, would you mind making the same change to ql/src/java/conf/hive-exec-log4j.properties? Thanks.

          Show
          cwsteinbach Carl Steinbach added a comment - @Sean: Actually, would you mind making the same change to ql/src/java/conf/hive-exec-log4j.properties? Thanks.
          Hide
          mackrorysd Sean Mackrory added a comment -

          log4j.threshold and hive.root.logger specify two different levels. Should they actually be the same, in reality or should only one be paramterized? Which would be most intuitive considering how this file gets used?

          Show
          mackrorysd Sean Mackrory added a comment - log4j.threshold and hive.root.logger specify two different levels. Should they actually be the same, in reality or should only one be paramterized? Which would be most intuitive considering how this file gets used?
          Hide
          cwsteinbach Carl Steinbach added a comment -

          Generally speaking they should be the same. The way you have it setup in hive-log4j.properties looks like the right approach to me.

          Show
          cwsteinbach Carl Steinbach added a comment - Generally speaking they should be the same. The way you have it setup in hive-log4j.properties looks like the right approach to me.
          Hide
          mackrorysd Sean Mackrory added a comment -

          New patch applies the same change to hive-exec-log4j.properties

          Show
          mackrorysd Sean Mackrory added a comment - New patch applies the same change to hive-exec-log4j.properties
          Hide
          cwsteinbach Carl Steinbach added a comment -

          +1. Will commit if tests pass.

          Show
          cwsteinbach Carl Steinbach added a comment - +1. Will commit if tests pass.
          Hide
          cwsteinbach Carl Steinbach added a comment -

          Committed to trunk. Thanks Sean!

          Show
          cwsteinbach Carl Steinbach added a comment - Committed to trunk. Thanks Sean!
          Hide
          hudson Hudson added a comment -

          Integrated in Hive-trunk-h0.21 #1698 (See https://builds.apache.org/job/Hive-trunk-h0.21/1698/)
          HIVE-3505. log4j template has logging threshold that hides all audit logs (Sean Mackrory via cws) (Revision 1390278)

          Result = FAILURE
          cws : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1390278
          Files :

          • /hive/trunk/common/src/java/conf/hive-log4j.properties
          • /hive/trunk/ql/src/java/conf/hive-exec-log4j.properties
          Show
          hudson Hudson added a comment - Integrated in Hive-trunk-h0.21 #1698 (See https://builds.apache.org/job/Hive-trunk-h0.21/1698/ ) HIVE-3505 . log4j template has logging threshold that hides all audit logs (Sean Mackrory via cws) (Revision 1390278) Result = FAILURE cws : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1390278 Files : /hive/trunk/common/src/java/conf/hive-log4j.properties /hive/trunk/ql/src/java/conf/hive-exec-log4j.properties
          Hide
          hudson Hudson added a comment -

          Integrated in Hive-trunk-hadoop2 #54 (See https://builds.apache.org/job/Hive-trunk-hadoop2/54/)
          HIVE-3505. log4j template has logging threshold that hides all audit logs (Sean Mackrory via cws) (Revision 1390278)

          Result = ABORTED
          cws : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1390278
          Files :

          • /hive/trunk/common/src/java/conf/hive-log4j.properties
          • /hive/trunk/ql/src/java/conf/hive-exec-log4j.properties
          Show
          hudson Hudson added a comment - Integrated in Hive-trunk-hadoop2 #54 (See https://builds.apache.org/job/Hive-trunk-hadoop2/54/ ) HIVE-3505 . log4j template has logging threshold that hides all audit logs (Sean Mackrory via cws) (Revision 1390278) Result = ABORTED cws : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1390278 Files : /hive/trunk/common/src/java/conf/hive-log4j.properties /hive/trunk/ql/src/java/conf/hive-exec-log4j.properties
          Hide
          ashutoshc Ashutosh Chauhan added a comment -

          This issue is fixed and released as part of 0.10.0 release. If you find an issue which seems to be related to this one, please create a new jira and link this one with new jira.

          Show
          ashutoshc Ashutosh Chauhan added a comment - This issue is fixed and released as part of 0.10.0 release. If you find an issue which seems to be related to this one, please create a new jira and link this one with new jira.

            People

            • Assignee:
              mackrorysd Sean Mackrory
              Reporter:
              mackrorysd Sean Mackrory
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development