Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-3420

Inefficiency in hbase handler when process query including rowkey range scan

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Critical
    • Resolution: Fixed
    • None
    • 0.13.0
    • HBase Handler
    • None
    • Hive-0.9.0 + HBase-0.94.1

    Description

      When query hive with hbase rowkey range, hive map tasks do not leverage startrow, endrow information in tablesplit. For example, if the rowkeys fit into 5 hbase files, then where will be 5 map tasks. Ideally, each task will process 1 file. But in current implementation, each task processes 5 files repeatedly. The behavior not only waste network bandwidth, but also worse the lock contention in HBase block cache as each task have to access the same block. The problem code is in HiveHBaseTableInputFormat.convertFilte as below:
      ……
      if (tableSplit != null)

      { tableSplit = new TableSplit( tableSplit.getTableName(), startRow, stopRow, tableSplit.getRegionLocation()); }

      scan.setStartRow(startRow);
      scan.setStopRow(stopRow);
      ……
      As tableSplit already include startRow, endRow information of file, the better implementation will be:

      ……
      byte[] splitStart = startRow;
      byte[] splitStop = stopRow;
      if (tableSplit != null) {

      if(tableSplit.getStartRow() != null)

      { splitStart = startRow.length == 0 || Bytes.compareTo(tableSplit.getStartRow(), startRow) >= 0 ? tableSplit.getStartRow() : startRow; }

      if(tableSplit.getEndRow() != null)

      { splitStop = (stopRow.length == 0 || Bytes.compareTo(tableSplit.getEndRow(), stopRow) <= 0) && tableSplit.getEndRow().length > 0 ? tableSplit.getEndRow() : stopRow; }


      tableSplit = new TableSplit(
      tableSplit.getTableName(),
      splitStart,
      splitStop,
      tableSplit.getRegionLocation());
      }
      scan.setStartRow(splitStart);
      scan.setStopRow(splitStop);
      ……
      In my test, the changed code will improve performance more than 30%.

      Attachments

        1. HIVE-3420.D7311.1.patch
          5 kB
          Phabricator

        Issue Links

          Activity

            People

              navis Navis Ryu
              gang Gang Deng
              Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - 2h
                  2h
                  Remaining:
                  Remaining Estimate - 2h
                  2h
                  Logged:
                  Time Spent - Not Specified
                  Not Specified