Hive
  1. Hive
  2. HIVE-3004

RegexSerDe should support other column types in addition to STRING

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.11.0
    • Labels:
      None
    1. HIVE-3004-1.patch
      42 kB
      Shreepadma Venugopalan
    2. HIVE-3004.2.patch
      43 kB
      Shreepadma Venugopalan
    3. HIVE-3004.3.patch.txt
      13 kB
      Shreepadma Venugopalan
    4. HIVE-3004.4.patch
      13 kB
      Shreepadma Venugopalan

      Activity

      Hide
      Carl Steinbach added a comment -

      Currently RegexSerDe requires that all columns in the table be of type STRING. We should modify it so that it automatically converts to the other primitive column types. If feasible, it would also be nice to support Hive's complex column types.

      Show
      Carl Steinbach added a comment - Currently RegexSerDe requires that all columns in the table be of type STRING. We should modify it so that it automatically converts to the other primitive column types. If feasible, it would also be nice to support Hive's complex column types.
      Hide
      Shreepadma Venugopalan added a comment -

      I'm working on rebasing the patch off of the trunk.

      Show
      Shreepadma Venugopalan added a comment - I'm working on rebasing the patch off of the trunk.
      Hide
      Ashutosh Chauhan added a comment -

      Sorry, this fell off of my radar. Please rebase and I will take a look.

      Show
      Ashutosh Chauhan added a comment - Sorry, this fell off of my radar. Please rebase and I will take a look.
      Hide
      Shreepadma Venugopalan added a comment -

      Thanks Ashutosh. I've attached the new patch to the JIRA.

      Show
      Shreepadma Venugopalan added a comment - Thanks Ashutosh. I've attached the new patch to the JIRA.
      Hide
      Shreepadma Venugopalan added a comment -
      Show
      Shreepadma Venugopalan added a comment - Review board : https://reviews.apache.org/r/8931/
      Hide
      Ashutosh Chauhan added a comment -

      Left a comment on RB.

      Show
      Ashutosh Chauhan added a comment - Left a comment on RB.
      Hide
      Ashutosh Chauhan added a comment -

      +1 running tests now.

      Show
      Ashutosh Chauhan added a comment - +1 running tests now.
      Hide
      Ashutosh Chauhan added a comment -

      Committed to trunk. Thanks, Shreepadma!

      Show
      Ashutosh Chauhan added a comment - Committed to trunk. Thanks, Shreepadma!
      Hide
      Hudson added a comment -

      Integrated in Hive-trunk-h0.21 #1913 (See https://builds.apache.org/job/Hive-trunk-h0.21/1913/)
      HIVE-3004 : RegexSerDe should support other column types in addition to STRING (Shreepadma Venugoplan via Ashutosh Chauhan) (Revision 1433297)

      Result = FAILURE
      hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1433297
      Files :

      • /hive/trunk/ql/src/test/queries/clientnegative/serde_regex.q
      • /hive/trunk/ql/src/test/queries/clientpositive/serde_regex.q
      • /hive/trunk/ql/src/test/results/clientnegative/serde_regex.q.out
      • /hive/trunk/ql/src/test/results/clientpositive/serde_regex.q.out
      • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/RegexSerDe.java
      Show
      Hudson added a comment - Integrated in Hive-trunk-h0.21 #1913 (See https://builds.apache.org/job/Hive-trunk-h0.21/1913/ ) HIVE-3004 : RegexSerDe should support other column types in addition to STRING (Shreepadma Venugoplan via Ashutosh Chauhan) (Revision 1433297) Result = FAILURE hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1433297 Files : /hive/trunk/ql/src/test/queries/clientnegative/serde_regex.q /hive/trunk/ql/src/test/queries/clientpositive/serde_regex.q /hive/trunk/ql/src/test/results/clientnegative/serde_regex.q.out /hive/trunk/ql/src/test/results/clientpositive/serde_regex.q.out /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/RegexSerDe.java
      Hide
      Hudson added a comment -

      Integrated in hive-trunk-hadoop1 #14 (See https://builds.apache.org/job/hive-trunk-hadoop1/14/)
      HIVE-3004 : RegexSerDe should support other column types in addition to STRING (Shreepadma Venugoplan via Ashutosh Chauhan) (Revision 1433297)

      Result = ABORTED
      hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1433297
      Files :

      • /hive/trunk/ql/src/test/queries/clientnegative/serde_regex.q
      • /hive/trunk/ql/src/test/queries/clientpositive/serde_regex.q
      • /hive/trunk/ql/src/test/results/clientnegative/serde_regex.q.out
      • /hive/trunk/ql/src/test/results/clientpositive/serde_regex.q.out
      • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/RegexSerDe.java
      Show
      Hudson added a comment - Integrated in hive-trunk-hadoop1 #14 (See https://builds.apache.org/job/hive-trunk-hadoop1/14/ ) HIVE-3004 : RegexSerDe should support other column types in addition to STRING (Shreepadma Venugoplan via Ashutosh Chauhan) (Revision 1433297) Result = ABORTED hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1433297 Files : /hive/trunk/ql/src/test/queries/clientnegative/serde_regex.q /hive/trunk/ql/src/test/queries/clientpositive/serde_regex.q /hive/trunk/ql/src/test/results/clientnegative/serde_regex.q.out /hive/trunk/ql/src/test/results/clientpositive/serde_regex.q.out /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/RegexSerDe.java
      Hide
      Hudson added a comment -

      Integrated in Hive-trunk-hadoop2 #66 (See https://builds.apache.org/job/Hive-trunk-hadoop2/66/)
      HIVE-3004 : RegexSerDe should support other column types in addition to STRING (Shreepadma Venugoplan via Ashutosh Chauhan) (Revision 1433297)

      Result = FAILURE
      hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1433297
      Files :

      • /hive/trunk/ql/src/test/queries/clientnegative/serde_regex.q
      • /hive/trunk/ql/src/test/queries/clientpositive/serde_regex.q
      • /hive/trunk/ql/src/test/results/clientnegative/serde_regex.q.out
      • /hive/trunk/ql/src/test/results/clientpositive/serde_regex.q.out
      • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/RegexSerDe.java
      Show
      Hudson added a comment - Integrated in Hive-trunk-hadoop2 #66 (See https://builds.apache.org/job/Hive-trunk-hadoop2/66/ ) HIVE-3004 : RegexSerDe should support other column types in addition to STRING (Shreepadma Venugoplan via Ashutosh Chauhan) (Revision 1433297) Result = FAILURE hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1433297 Files : /hive/trunk/ql/src/test/queries/clientnegative/serde_regex.q /hive/trunk/ql/src/test/queries/clientpositive/serde_regex.q /hive/trunk/ql/src/test/results/clientnegative/serde_regex.q.out /hive/trunk/ql/src/test/results/clientpositive/serde_regex.q.out /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/RegexSerDe.java
      Hide
      Shreepadma Venugopalan added a comment -

      Thanks Ashutosh!

      Show
      Shreepadma Venugopalan added a comment - Thanks Ashutosh!

        People

        • Assignee:
          Shreepadma Venugopalan
          Reporter:
          Carl Steinbach
        • Votes:
          0 Vote for this issue
          Watchers:
          5 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development