Hive
  1. Hive
  2. HIVE-2948

HiveFileFormatUtils should use Path.SEPARATOR instead of File.Separator

        Details

        • Type: Bug Bug
        • Status: Closed
        • Priority: Major Major
        • Resolution: Fixed
        • Affects Version/s: None
        • Fix Version/s: 0.9.0
        • Component/s: None
        • Labels:
          None

          Description

          Because its munging hdfs paths and not OS paths.

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            Phabricator added a comment -

            ashutoshc requested code review of "HIVE-2948 [jira] HiveFileFormatUtils should use Path.SEPARATOR instead of File.Separator".
            Reviewers: JIRA

            https://issues.apache.org/jira/browse/HIVE-2948

            Simple patch which replaces File.separator to Path.SEPARATOR since separator for hdfs path is Path.SEPARATOR not java's File.SEPARATOR

            Because its munging hdfs paths and not OS paths.

            TEST PLAN
            EMPTY

            REVISION DETAIL
            https://reviews.facebook.net/D2763

            AFFECTED FILES
            ql/src/java/org/apache/hadoop/hive/ql/io/HiveFileFormatUtils.java

            MANAGE HERALD DIFFERENTIAL RULES
            https://reviews.facebook.net/herald/view/differential/

            WHY DID I GET THIS EMAIL?
            https://reviews.facebook.net/herald/transcript/6291/

            Tip: use the X-Herald-Rules header to filter Herald messages in your client.

            Show
            Phabricator added a comment - ashutoshc requested code review of " HIVE-2948 [jira] HiveFileFormatUtils should use Path.SEPARATOR instead of File.Separator". Reviewers: JIRA https://issues.apache.org/jira/browse/HIVE-2948 Simple patch which replaces File.separator to Path.SEPARATOR since separator for hdfs path is Path.SEPARATOR not java's File.SEPARATOR Because its munging hdfs paths and not OS paths. TEST PLAN EMPTY REVISION DETAIL https://reviews.facebook.net/D2763 AFFECTED FILES ql/src/java/org/apache/hadoop/hive/ql/io/HiveFileFormatUtils.java MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/6291/ Tip: use the X-Herald-Rules header to filter Herald messages in your client.
            Hide
            Permalink
            Ashutosh Chauhan added a comment -

            All the tests passed.

            Show
            Ashutosh Chauhan added a comment - All the tests passed.
            Hide
            Permalink
            Ashutosh Chauhan added a comment -

            Ready for review.

            Show
            Ashutosh Chauhan added a comment - Ready for review.
            Hide
            Permalink
            Phabricator added a comment -

            kevinwilfong has accepted the revision "HIVE-2948 [jira] HiveFileFormatUtils should use Path.SEPARATOR instead of File.Separator".

            +1

            REVISION DETAIL
            https://reviews.facebook.net/D2763

            BRANCH
            svn

            Show
            Phabricator added a comment - kevinwilfong has accepted the revision " HIVE-2948 [jira] HiveFileFormatUtils should use Path.SEPARATOR instead of File.Separator". +1 REVISION DETAIL https://reviews.facebook.net/D2763 BRANCH svn
            Hide
            Permalink
            Ashutosh Chauhan added a comment -

            Thanks, Kevin for the review.. Committed to trunk.

            Show
            Ashutosh Chauhan added a comment - Thanks, Kevin for the review.. Committed to trunk.
            Hide
            Permalink
            Phabricator added a comment -

            ashutoshc has committed the revision "HIVE-2948 [jira] HiveFileFormatUtils should use Path.SEPARATOR instead of File.Separator".

            Change committed by hashutosh.

            REVISION DETAIL
            https://reviews.facebook.net/D2763

            COMMIT
            https://reviews.facebook.net/rHIVE1325615

            Show
            Phabricator added a comment - ashutoshc has committed the revision " HIVE-2948 [jira] HiveFileFormatUtils should use Path.SEPARATOR instead of File.Separator". Change committed by hashutosh. REVISION DETAIL https://reviews.facebook.net/D2763 COMMIT https://reviews.facebook.net/rHIVE1325615
            Hide
            Permalink
            Hudson added a comment -

            Integrated in Hive-trunk-h0.21 #1371 (See https://builds.apache.org/job/Hive-trunk-h0.21/1371/)
            HIVE-2948 [jira] HiveFileFormatUtils should use Path.SEPARATOR instead of
            File.Separator

            Summary:
            https://issues.apache.org/jira/browse/HIVE-2948

            Simple patch which replaces File.separator to Path.SEPARATOR since separator for
            hdfs path is Path.SEPARATOR not java's File.SEPARATOR

            Because its munging hdfs paths and not OS paths.

            Test Plan: EMPTY

            Reviewers: JIRA, kevinwilfong

            Reviewed By: kevinwilfong

            Differential Revision: https://reviews.facebook.net/D2763 (Revision 1325615)

            Result = ABORTED
            hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1325615
            Files :

            • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/io/HiveFileFormatUtils.java
            Show
            Hudson added a comment - Integrated in Hive-trunk-h0.21 #1371 (See https://builds.apache.org/job/Hive-trunk-h0.21/1371/ ) HIVE-2948 [jira] HiveFileFormatUtils should use Path.SEPARATOR instead of File.Separator Summary: https://issues.apache.org/jira/browse/HIVE-2948 Simple patch which replaces File.separator to Path.SEPARATOR since separator for hdfs path is Path.SEPARATOR not java's File.SEPARATOR Because its munging hdfs paths and not OS paths. Test Plan: EMPTY Reviewers: JIRA, kevinwilfong Reviewed By: kevinwilfong Differential Revision: https://reviews.facebook.net/D2763 (Revision 1325615) Result = ABORTED hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1325615 Files : /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/io/HiveFileFormatUtils.java
            Hide
            Permalink
            Ashutosh Chauhan added a comment -

            This issue is closed now. It was released with the fix in 0.9.0. If there is a problem, please open a new jira and link this one with that.

            Show
            Ashutosh Chauhan added a comment - This issue is closed now. It was released with the fix in 0.9.0. If there is a problem, please open a new jira and link this one with that.
            Hide
            Permalink
            Hudson added a comment -

            Integrated in Hive-trunk-hadoop2 #54 (See https://builds.apache.org/job/Hive-trunk-hadoop2/54/)
            HIVE-2948 [jira] HiveFileFormatUtils should use Path.SEPARATOR instead of
            File.Separator

            Summary:
            https://issues.apache.org/jira/browse/HIVE-2948

            Simple patch which replaces File.separator to Path.SEPARATOR since separator for
            hdfs path is Path.SEPARATOR not java's File.SEPARATOR

            Because its munging hdfs paths and not OS paths.

            Test Plan: EMPTY

            Reviewers: JIRA, kevinwilfong

            Reviewed By: kevinwilfong

            Differential Revision: https://reviews.facebook.net/D2763 (Revision 1325615)

            Result = ABORTED
            hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1325615
            Files :

            • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/io/HiveFileFormatUtils.java
            Show
            Hudson added a comment - Integrated in Hive-trunk-hadoop2 #54 (See https://builds.apache.org/job/Hive-trunk-hadoop2/54/ ) HIVE-2948 [jira] HiveFileFormatUtils should use Path.SEPARATOR instead of File.Separator Summary: https://issues.apache.org/jira/browse/HIVE-2948 Simple patch which replaces File.separator to Path.SEPARATOR since separator for hdfs path is Path.SEPARATOR not java's File.SEPARATOR Because its munging hdfs paths and not OS paths. Test Plan: EMPTY Reviewers: JIRA, kevinwilfong Reviewed By: kevinwilfong Differential Revision: https://reviews.facebook.net/D2763 (Revision 1325615) Result = ABORTED hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1325615 Files : /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/io/HiveFileFormatUtils.java

              People

              • Assignee:
                Ashutosh Chauhan
                Reporter:
                Ashutosh Chauhan
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development