Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0
    • Component/s: None
    • Labels:
      None

      Description

      We need to clean up the RAT report to 0. Apache projects aren't supposed to release until they have shown that all of their files have proper headers.

      Note that although most of the files are just missing headers, some of them explicitly say copyright by facebook and released under the Thrift (not Apache) license. I'll generate a list of them, but I'd really appreciate it if someone from facebook could in verify that they intend to license them to Apache.

        Activity

        Hide
        Owen O'Malley added a comment -

        The files that are copyright by Facebook are:

        service/lib/php/ext/thrift_protocol/config.m4
        service/lib/py/thrift/protocol/fastbinary.c
        service/lib/py/thrift/reflection/__init__.py
        
        Show
        Owen O'Malley added a comment - The files that are copyright by Facebook are: service/lib/php/ext/thrift_protocol/config.m4 service/lib/py/thrift/protocol/fastbinary.c service/lib/py/thrift/reflection/__init__.py
        Hide
        Owen O'Malley added a comment -

        I ran through the files without headers and found the commit that first added them and converted it to a jira from the log message. My intent was to show that all of the files that I was adding headers to had been properly contributed to the project via the checkbox on jira or the contributor's ICLA. Here's the list of Jiras that added the files that are currently without headers:

        HADOOP-3601
        HADOOP-4230
        HADOOP-4566
        HIVE-65
        HIVE-82
        HIVE-166
        HIVE-203
        HIVE-251
        HIVE-299
        HIVE-343
        HIVE-382
        HIVE-675
        HIVE-705
        HIVE-713
        HIVE-956
        HIVE-1003
        HIVE-1104
        HIVE-1135
        HIVE-1163
        HIVE-1204
        HIVE-1361
        HIVE-1405
        HIVE-1513
        HIVE-1609
        HIVE-1616
        HIVE-1867
        HIVE-1983
        HIVE-2011
        HIVE-2076
        HIVE-2185
        HIVE-2244
        HIVE-2246 *** contributed by Sohan Jain
        HIVE-2441
        HIVE-2442
        HIVE-2523 (covered by John Sichi's ICLA)
        HIVE-2795 (covered by Kevin Wilfong's ICLA)
        HIVE-2797
        HIVE-2805 (covered by Kevin Wilfong's ICLA)
        HIVE-2853 (covered by Kevin Wilfong's ICLA)
        HIVE-2866 (covered by Kevin Wilfong's ICLA)
        

        The only one that doesn't seem covered is HIVE-2246, which was contributed by Sohan Jain. I'll start a discussion on the dev list rather than continue on in a jira. smile

        Show
        Owen O'Malley added a comment - I ran through the files without headers and found the commit that first added them and converted it to a jira from the log message. My intent was to show that all of the files that I was adding headers to had been properly contributed to the project via the checkbox on jira or the contributor's ICLA. Here's the list of Jiras that added the files that are currently without headers: HADOOP-3601 HADOOP-4230 HADOOP-4566 HIVE-65 HIVE-82 HIVE-166 HIVE-203 HIVE-251 HIVE-299 HIVE-343 HIVE-382 HIVE-675 HIVE-705 HIVE-713 HIVE-956 HIVE-1003 HIVE-1104 HIVE-1135 HIVE-1163 HIVE-1204 HIVE-1361 HIVE-1405 HIVE-1513 HIVE-1609 HIVE-1616 HIVE-1867 HIVE-1983 HIVE-2011 HIVE-2076 HIVE-2185 HIVE-2244 HIVE-2246 *** contributed by Sohan Jain HIVE-2441 HIVE-2442 HIVE-2523 (covered by John Sichi's ICLA) HIVE-2795 (covered by Kevin Wilfong's ICLA) HIVE-2797 HIVE-2805 (covered by Kevin Wilfong's ICLA) HIVE-2853 (covered by Kevin Wilfong's ICLA) HIVE-2866 (covered by Kevin Wilfong's ICLA) The only one that doesn't seem covered is HIVE-2246 , which was contributed by Sohan Jain. I'll start a discussion on the dev list rather than continue on in a jira. smile
        Hide
        Phabricator added a comment -

        omalley requested code review of "HIVE-2930 [jira] Add license to the Hive files".
        Reviewers: JIRA

        <<Enter Revision Title>>

        Fixing rat warnings

        We need to clean up the RAT report to 0. Apache projects aren't supposed to release until they have shown that all of their files have proper headers.

        Note that although most of the files are just missing headers, some of them explicitly say copyright by facebook and released under the Thrift (not Apache) license. I'll generate a list of them, but I'd really appreciate it if someone from facebook could in verify that they intend to license them to Apache.

        TEST PLAN
        EMPTY

        REVISION DETAIL
        https://reviews.facebook.net/D2835

        AFFECTED FILES
        .checkstyle
        build.properties
        build.xml
        common/src/java/conf/hive-log4j.properties
        conf/configuration.xsl
        conf/hive-env.sh.template
        data/conf/hive-log4j.properties
        data/scripts/cat.py
        data/scripts/cat_error.py
        data/scripts/dumpdata_script.py
        data/scripts/error_script
        data/scripts/input20_script
        docs/velocity.properties
        eclipse-templates/.classpath
        eclipse-templates/.classpath._hbase
        eclipse-templates/.externalToolBuilders/Hive_Ant_Builder.launch
        eclipse-templates/.project
        eclipse-templates/.settings/org.eclipse.jdt.core.prefs
        eclipse-templates/.settings/org.eclipse.jdt.ui.prefs
        eclipse-templates/HiveCLI.launchtemplate
        eclipse-templates/TestCliDriver.launchtemplate
        eclipse-templates/TestEmbeddedHiveMetaStore.launchtemplate
        eclipse-templates/TestHBaseCliDriver.launchtemplate
        eclipse-templates/TestHive.launchtemplate
        eclipse-templates/TestHiveMetaStoreChecker.launchtemplate
        eclipse-templates/TestJdbc.launchtemplate
        eclipse-templates/TestMTQueries.launchtemplate
        eclipse-templates/TestRemoteHiveMetaStore.launchtemplate
        eclipse-templates/TestTruncate.launchtemplate
        hbase-handler/src/test/templates/TestHBaseCliDriver.vm
        metastore/if/hive_metastore.thrift
        metastore/scripts/hive.metastore_ctrl
        metastore/scripts/hive.metastore_daemon
        metastore/scripts/upgrade/001-HIVE-2795.update_view_partitions.py
        metastore/src/java/org/apache/hadoop/hive/metastore/parser/Filter.g
        metastore/src/model/package.jdo
        metastore/src/test/org/apache/hadoop/hive/metastore/DummyPreListener.java
        metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteUGIHiveMetaStoreIpAddress.java
        ql/if/queryplan.thrift
        ql/src/java/conf/hive-exec-log4j.properties
        ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/MetadataOnlyOptimizer.java
        ql/src/java/org/apache/hadoop/hive/ql/plan/mapredplan.jr
        ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsUtils.java
        ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPPlus.java
        ql/src/test/org/apache/hadoop/hive/ql/exec/sample_plan.xml
        ql/src/test/queries/clientnegative/dyn_part_empty.q.disabled
        ql/src/test/scripts/testgrep
        ql/src/test/templates/TestCliDriver.vm
        ql/src/test/templates/TestNegativeCliDriver.vm
        ql/src/test/templates/TestParse.vm
        ql/src/test/templates/TestParseNegative.vm
        serde/if/serde.thrift
        serde/if/test/complex.thrift
        serde/if/test/complexpb.proto
        serde/if/test/testthrift.thrift
        serde/src/java/org/apache/hadoop/hive/serde2/columnar/LazyBinaryColumnarSerDe.java
        serde/src/java/org/apache/hadoop/hive/serde2/dynamic_type/thrift_grammar.jjt
        service/lib/php/ext/thrift_protocol/config.m4
        service/lib/php/ext/thrift_protocol/tags/1.0.0/config.m4
        service/lib/php/ext/thrift_protocol/tags/1.0.0/php_thrift_protocol.cpp
        service/lib/php/ext/thrift_protocol/tags/1.0.0/php_thrift_protocol.h
        service/lib/py/fb303/_init_.py
        service/lib/py/thrift/protocol/fastbinary.c
        service/lib/py/thrift/reflection/_init_.py
        service/lib/py/thrift/reflection/limited/_init_.py
        service/src/test/php/test_service.php
        testutils/compute_stats
        testutils/dump_schema
        testutils/run_tests

        MANAGE HERALD DIFFERENTIAL RULES
        https://reviews.facebook.net/herald/view/differential/

        WHY DID I GET THIS EMAIL?
        https://reviews.facebook.net/herald/transcript/6429/

        Tip: use the X-Herald-Rules header to filter Herald messages in your client.

        Show
        Phabricator added a comment - omalley requested code review of " HIVE-2930 [jira] Add license to the Hive files". Reviewers: JIRA <<Enter Revision Title>> Fixing rat warnings We need to clean up the RAT report to 0. Apache projects aren't supposed to release until they have shown that all of their files have proper headers. Note that although most of the files are just missing headers, some of them explicitly say copyright by facebook and released under the Thrift (not Apache) license. I'll generate a list of them, but I'd really appreciate it if someone from facebook could in verify that they intend to license them to Apache. TEST PLAN EMPTY REVISION DETAIL https://reviews.facebook.net/D2835 AFFECTED FILES .checkstyle build.properties build.xml common/src/java/conf/hive-log4j.properties conf/configuration.xsl conf/hive-env.sh.template data/conf/hive-log4j.properties data/scripts/cat.py data/scripts/cat_error.py data/scripts/dumpdata_script.py data/scripts/error_script data/scripts/input20_script docs/velocity.properties eclipse-templates/.classpath eclipse-templates/.classpath._hbase eclipse-templates/.externalToolBuilders/Hive_Ant_Builder.launch eclipse-templates/.project eclipse-templates/.settings/org.eclipse.jdt.core.prefs eclipse-templates/.settings/org.eclipse.jdt.ui.prefs eclipse-templates/HiveCLI.launchtemplate eclipse-templates/TestCliDriver.launchtemplate eclipse-templates/TestEmbeddedHiveMetaStore.launchtemplate eclipse-templates/TestHBaseCliDriver.launchtemplate eclipse-templates/TestHive.launchtemplate eclipse-templates/TestHiveMetaStoreChecker.launchtemplate eclipse-templates/TestJdbc.launchtemplate eclipse-templates/TestMTQueries.launchtemplate eclipse-templates/TestRemoteHiveMetaStore.launchtemplate eclipse-templates/TestTruncate.launchtemplate hbase-handler/src/test/templates/TestHBaseCliDriver.vm metastore/if/hive_metastore.thrift metastore/scripts/hive.metastore_ctrl metastore/scripts/hive.metastore_daemon metastore/scripts/upgrade/001- HIVE-2795 .update_view_partitions.py metastore/src/java/org/apache/hadoop/hive/metastore/parser/Filter.g metastore/src/model/package.jdo metastore/src/test/org/apache/hadoop/hive/metastore/DummyPreListener.java metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteUGIHiveMetaStoreIpAddress.java ql/if/queryplan.thrift ql/src/java/conf/hive-exec-log4j.properties ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/MetadataOnlyOptimizer.java ql/src/java/org/apache/hadoop/hive/ql/plan/mapredplan.jr ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsUtils.java ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPPlus.java ql/src/test/org/apache/hadoop/hive/ql/exec/sample_plan.xml ql/src/test/queries/clientnegative/dyn_part_empty.q.disabled ql/src/test/scripts/testgrep ql/src/test/templates/TestCliDriver.vm ql/src/test/templates/TestNegativeCliDriver.vm ql/src/test/templates/TestParse.vm ql/src/test/templates/TestParseNegative.vm serde/if/serde.thrift serde/if/test/complex.thrift serde/if/test/complexpb.proto serde/if/test/testthrift.thrift serde/src/java/org/apache/hadoop/hive/serde2/columnar/LazyBinaryColumnarSerDe.java serde/src/java/org/apache/hadoop/hive/serde2/dynamic_type/thrift_grammar.jjt service/lib/php/ext/thrift_protocol/config.m4 service/lib/php/ext/thrift_protocol/tags/1.0.0/config.m4 service/lib/php/ext/thrift_protocol/tags/1.0.0/php_thrift_protocol.cpp service/lib/php/ext/thrift_protocol/tags/1.0.0/php_thrift_protocol.h service/lib/py/fb303/_ init _.py service/lib/py/thrift/protocol/fastbinary.c service/lib/py/thrift/reflection/_ init _.py service/lib/py/thrift/reflection/limited/_ init _.py service/src/test/php/test_service.php testutils/compute_stats testutils/dump_schema testutils/run_tests MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/6429/ Tip: use the X-Herald-Rules header to filter Herald messages in your client.
        Hide
        Owen O'Malley added a comment -

        This doesn't fix the sql files, but fixes the rest of them. It passes unit tests.

        Show
        Owen O'Malley added a comment - This doesn't fix the sql files, but fixes the rest of them. It passes unit tests.
        Hide
        Sohan Jain added a comment -

        I intended to license my patch for HIVE-2246 to the Apache Software Foundation. Thanks!

        Show
        Sohan Jain added a comment - I intended to license my patch for HIVE-2246 to the Apache Software Foundation. Thanks!
        Hide
        Phabricator added a comment -

        ashutoshc has accepted the revision "HIVE-2930 [jira] Add license to the Hive files".

        +1 will commit soon.

        REVISION DETAIL
        https://reviews.facebook.net/D2835

        BRANCH
        h-2930

        Show
        Phabricator added a comment - ashutoshc has accepted the revision " HIVE-2930 [jira] Add license to the Hive files". +1 will commit soon. REVISION DETAIL https://reviews.facebook.net/D2835 BRANCH h-2930
        Hide
        Phabricator added a comment -

        omalley has committed the revision "HIVE-2930 [jira] Add license to the Hive files".

        Change committed by hashutosh.

        REVISION DETAIL
        https://reviews.facebook.net/D2835

        COMMIT
        https://reviews.facebook.net/rHIVE1327205

        Show
        Phabricator added a comment - omalley has committed the revision " HIVE-2930 [jira] Add license to the Hive files". Change committed by hashutosh. REVISION DETAIL https://reviews.facebook.net/D2835 COMMIT https://reviews.facebook.net/rHIVE1327205
        Hide
        Ashutosh Chauhan added a comment -

        Thanks Owen for fixing this. Committed to 0.9 and trunk.

        Show
        Ashutosh Chauhan added a comment - Thanks Owen for fixing this. Committed to 0.9 and trunk.
        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-h0.21 #1379 (See https://builds.apache.org/job/Hive-trunk-h0.21/1379/)
        HIVE-2930 [jira] Add license to the Hive files
        (Owen O'Malley via Ashutosh Chauhan)

        Summary:
        <<Enter Revision Title>>

        Fixing rat warnings

        We need to clean up the RAT report to 0. Apache projects aren't supposed to
        release until they have shown that all of their files have proper headers.

        Note that although most of the files are just missing headers, some of them
        explicitly say copyright by facebook and released under the Thrift (not Apache)
        license. I'll generate a list of them, but I'd really appreciate it if someone
        from facebook could in verify that they intend to license them to Apache.

        Test Plan: EMPTY

        Reviewers: JIRA, ashutoshc

        Reviewed By: ashutoshc

        Differential Revision: https://reviews.facebook.net/D2835 (Revision 1327205)

        Result = SUCCESS
        hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1327205
        Files :

        • /hive/trunk/.checkstyle
        • /hive/trunk/build.properties
        • /hive/trunk/build.xml
        • /hive/trunk/common/src/java/conf/hive-log4j.properties
        • /hive/trunk/conf/configuration.xsl
        • /hive/trunk/conf/hive-env.sh.template
        • /hive/trunk/data/conf/hive-log4j.properties
        • /hive/trunk/data/scripts/cat.py
        • /hive/trunk/data/scripts/cat_error.py
        • /hive/trunk/data/scripts/dumpdata_script.py
        • /hive/trunk/data/scripts/error_script
        • /hive/trunk/data/scripts/input20_script
        • /hive/trunk/docs/velocity.properties
        • /hive/trunk/eclipse-templates/.classpath
        • /hive/trunk/eclipse-templates/.classpath._hbase
        • /hive/trunk/eclipse-templates/.externalToolBuilders/Hive_Ant_Builder.launch
        • /hive/trunk/eclipse-templates/.project
        • /hive/trunk/eclipse-templates/.settings/org.eclipse.jdt.core.prefs
        • /hive/trunk/eclipse-templates/.settings/org.eclipse.jdt.ui.prefs
        • /hive/trunk/eclipse-templates/HiveCLI.launchtemplate
        • /hive/trunk/eclipse-templates/TestCliDriver.launchtemplate
        • /hive/trunk/eclipse-templates/TestEmbeddedHiveMetaStore.launchtemplate
        • /hive/trunk/eclipse-templates/TestHBaseCliDriver.launchtemplate
        • /hive/trunk/eclipse-templates/TestHive.launchtemplate
        • /hive/trunk/eclipse-templates/TestHiveMetaStoreChecker.launchtemplate
        • /hive/trunk/eclipse-templates/TestJdbc.launchtemplate
        • /hive/trunk/eclipse-templates/TestMTQueries.launchtemplate
        • /hive/trunk/eclipse-templates/TestRemoteHiveMetaStore.launchtemplate
        • /hive/trunk/eclipse-templates/TestTruncate.launchtemplate
        • /hive/trunk/hbase-handler/src/test/templates/TestHBaseCliDriver.vm
        • /hive/trunk/metastore/if/hive_metastore.thrift
        • /hive/trunk/metastore/scripts/hive.metastore_ctrl
        • /hive/trunk/metastore/scripts/hive.metastore_daemon
        • /hive/trunk/metastore/scripts/upgrade/001-HIVE-2795.update_view_partitions.py
        • /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/parser/Filter.g
        • /hive/trunk/metastore/src/model/package.jdo
        • /hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/DummyPreListener.java
        • /hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteUGIHiveMetaStoreIpAddress.java
        • /hive/trunk/ql/if/queryplan.thrift
        • /hive/trunk/ql/src/java/conf/hive-exec-log4j.properties
        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/MetadataOnlyOptimizer.java
        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/mapredplan.jr
        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsUtils.java
        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPPlus.java
        • /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/exec/sample_plan.xml
        • /hive/trunk/ql/src/test/queries/clientnegative/dyn_part_empty.q.disabled
        • /hive/trunk/ql/src/test/scripts/testgrep
        • /hive/trunk/ql/src/test/templates/TestCliDriver.vm
        • /hive/trunk/ql/src/test/templates/TestNegativeCliDriver.vm
        • /hive/trunk/ql/src/test/templates/TestParse.vm
        • /hive/trunk/ql/src/test/templates/TestParseNegative.vm
        • /hive/trunk/serde/if/serde.thrift
        • /hive/trunk/serde/if/test/complex.thrift
        • /hive/trunk/serde/if/test/complexpb.proto
        • /hive/trunk/serde/if/test/testthrift.thrift
        • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/columnar/LazyBinaryColumnarSerDe.java
        • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/dynamic_type/thrift_grammar.jjt
        • /hive/trunk/service/lib/php/ext/thrift_protocol/config.m4
        • /hive/trunk/service/lib/php/ext/thrift_protocol/tags/1.0.0/config.m4
        • /hive/trunk/service/lib/php/ext/thrift_protocol/tags/1.0.0/php_thrift_protocol.cpp
        • /hive/trunk/service/lib/php/ext/thrift_protocol/tags/1.0.0/php_thrift_protocol.h
        • /hive/trunk/service/lib/py/fb303/_init_.py
        • /hive/trunk/service/lib/py/thrift/protocol/fastbinary.c
        • /hive/trunk/service/lib/py/thrift/reflection/_init_.py
        • /hive/trunk/service/lib/py/thrift/reflection/limited/_init_.py
        • /hive/trunk/service/src/test/php/test_service.php
        • /hive/trunk/testutils/compute_stats
        • /hive/trunk/testutils/dump_schema
        • /hive/trunk/testutils/run_tests
        Show
        Hudson added a comment - Integrated in Hive-trunk-h0.21 #1379 (See https://builds.apache.org/job/Hive-trunk-h0.21/1379/ ) HIVE-2930 [jira] Add license to the Hive files (Owen O'Malley via Ashutosh Chauhan) Summary: <<Enter Revision Title>> Fixing rat warnings We need to clean up the RAT report to 0. Apache projects aren't supposed to release until they have shown that all of their files have proper headers. Note that although most of the files are just missing headers, some of them explicitly say copyright by facebook and released under the Thrift (not Apache) license. I'll generate a list of them, but I'd really appreciate it if someone from facebook could in verify that they intend to license them to Apache. Test Plan: EMPTY Reviewers: JIRA, ashutoshc Reviewed By: ashutoshc Differential Revision: https://reviews.facebook.net/D2835 (Revision 1327205) Result = SUCCESS hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1327205 Files : /hive/trunk/.checkstyle /hive/trunk/build.properties /hive/trunk/build.xml /hive/trunk/common/src/java/conf/hive-log4j.properties /hive/trunk/conf/configuration.xsl /hive/trunk/conf/hive-env.sh.template /hive/trunk/data/conf/hive-log4j.properties /hive/trunk/data/scripts/cat.py /hive/trunk/data/scripts/cat_error.py /hive/trunk/data/scripts/dumpdata_script.py /hive/trunk/data/scripts/error_script /hive/trunk/data/scripts/input20_script /hive/trunk/docs/velocity.properties /hive/trunk/eclipse-templates/.classpath /hive/trunk/eclipse-templates/.classpath._hbase /hive/trunk/eclipse-templates/.externalToolBuilders/Hive_Ant_Builder.launch /hive/trunk/eclipse-templates/.project /hive/trunk/eclipse-templates/.settings/org.eclipse.jdt.core.prefs /hive/trunk/eclipse-templates/.settings/org.eclipse.jdt.ui.prefs /hive/trunk/eclipse-templates/HiveCLI.launchtemplate /hive/trunk/eclipse-templates/TestCliDriver.launchtemplate /hive/trunk/eclipse-templates/TestEmbeddedHiveMetaStore.launchtemplate /hive/trunk/eclipse-templates/TestHBaseCliDriver.launchtemplate /hive/trunk/eclipse-templates/TestHive.launchtemplate /hive/trunk/eclipse-templates/TestHiveMetaStoreChecker.launchtemplate /hive/trunk/eclipse-templates/TestJdbc.launchtemplate /hive/trunk/eclipse-templates/TestMTQueries.launchtemplate /hive/trunk/eclipse-templates/TestRemoteHiveMetaStore.launchtemplate /hive/trunk/eclipse-templates/TestTruncate.launchtemplate /hive/trunk/hbase-handler/src/test/templates/TestHBaseCliDriver.vm /hive/trunk/metastore/if/hive_metastore.thrift /hive/trunk/metastore/scripts/hive.metastore_ctrl /hive/trunk/metastore/scripts/hive.metastore_daemon /hive/trunk/metastore/scripts/upgrade/001- HIVE-2795 .update_view_partitions.py /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/parser/Filter.g /hive/trunk/metastore/src/model/package.jdo /hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/DummyPreListener.java /hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteUGIHiveMetaStoreIpAddress.java /hive/trunk/ql/if/queryplan.thrift /hive/trunk/ql/src/java/conf/hive-exec-log4j.properties /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/MetadataOnlyOptimizer.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/mapredplan.jr /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsUtils.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPPlus.java /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/exec/sample_plan.xml /hive/trunk/ql/src/test/queries/clientnegative/dyn_part_empty.q.disabled /hive/trunk/ql/src/test/scripts/testgrep /hive/trunk/ql/src/test/templates/TestCliDriver.vm /hive/trunk/ql/src/test/templates/TestNegativeCliDriver.vm /hive/trunk/ql/src/test/templates/TestParse.vm /hive/trunk/ql/src/test/templates/TestParseNegative.vm /hive/trunk/serde/if/serde.thrift /hive/trunk/serde/if/test/complex.thrift /hive/trunk/serde/if/test/complexpb.proto /hive/trunk/serde/if/test/testthrift.thrift /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/columnar/LazyBinaryColumnarSerDe.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/dynamic_type/thrift_grammar.jjt /hive/trunk/service/lib/php/ext/thrift_protocol/config.m4 /hive/trunk/service/lib/php/ext/thrift_protocol/tags/1.0.0/config.m4 /hive/trunk/service/lib/php/ext/thrift_protocol/tags/1.0.0/php_thrift_protocol.cpp /hive/trunk/service/lib/php/ext/thrift_protocol/tags/1.0.0/php_thrift_protocol.h /hive/trunk/service/lib/py/fb303/_ init _.py /hive/trunk/service/lib/py/thrift/protocol/fastbinary.c /hive/trunk/service/lib/py/thrift/reflection/_ init _.py /hive/trunk/service/lib/py/thrift/reflection/limited/_ init _.py /hive/trunk/service/src/test/php/test_service.php /hive/trunk/testutils/compute_stats /hive/trunk/testutils/dump_schema /hive/trunk/testutils/run_tests
        Hide
        Ashutosh Chauhan added a comment -

        This issue is closed now. It was released with the fix in 0.9.0. If there is a problem, please open a new jira and link this one with that.

        Show
        Ashutosh Chauhan added a comment - This issue is closed now. It was released with the fix in 0.9.0. If there is a problem, please open a new jira and link this one with that.
        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-hadoop2 #54 (See https://builds.apache.org/job/Hive-trunk-hadoop2/54/)
        HIVE-2930 [jira] Add license to the Hive files
        (Owen O'Malley via Ashutosh Chauhan)

        Summary:
        <<Enter Revision Title>>

        Fixing rat warnings

        We need to clean up the RAT report to 0. Apache projects aren't supposed to
        release until they have shown that all of their files have proper headers.

        Note that although most of the files are just missing headers, some of them
        explicitly say copyright by facebook and released under the Thrift (not Apache)
        license. I'll generate a list of them, but I'd really appreciate it if someone
        from facebook could in verify that they intend to license them to Apache.

        Test Plan: EMPTY

        Reviewers: JIRA, ashutoshc

        Reviewed By: ashutoshc

        Differential Revision: https://reviews.facebook.net/D2835 (Revision 1327205)

        Result = ABORTED
        hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1327205
        Files :

        • /hive/trunk/.checkstyle
        • /hive/trunk/build.properties
        • /hive/trunk/build.xml
        • /hive/trunk/common/src/java/conf/hive-log4j.properties
        • /hive/trunk/conf/configuration.xsl
        • /hive/trunk/conf/hive-env.sh.template
        • /hive/trunk/data/conf/hive-log4j.properties
        • /hive/trunk/data/scripts/cat.py
        • /hive/trunk/data/scripts/cat_error.py
        • /hive/trunk/data/scripts/dumpdata_script.py
        • /hive/trunk/data/scripts/error_script
        • /hive/trunk/data/scripts/input20_script
        • /hive/trunk/docs/velocity.properties
        • /hive/trunk/eclipse-templates/.classpath
        • /hive/trunk/eclipse-templates/.classpath._hbase
        • /hive/trunk/eclipse-templates/.externalToolBuilders/Hive_Ant_Builder.launch
        • /hive/trunk/eclipse-templates/.project
        • /hive/trunk/eclipse-templates/.settings/org.eclipse.jdt.core.prefs
        • /hive/trunk/eclipse-templates/.settings/org.eclipse.jdt.ui.prefs
        • /hive/trunk/eclipse-templates/HiveCLI.launchtemplate
        • /hive/trunk/eclipse-templates/TestCliDriver.launchtemplate
        • /hive/trunk/eclipse-templates/TestEmbeddedHiveMetaStore.launchtemplate
        • /hive/trunk/eclipse-templates/TestHBaseCliDriver.launchtemplate
        • /hive/trunk/eclipse-templates/TestHive.launchtemplate
        • /hive/trunk/eclipse-templates/TestHiveMetaStoreChecker.launchtemplate
        • /hive/trunk/eclipse-templates/TestJdbc.launchtemplate
        • /hive/trunk/eclipse-templates/TestMTQueries.launchtemplate
        • /hive/trunk/eclipse-templates/TestRemoteHiveMetaStore.launchtemplate
        • /hive/trunk/eclipse-templates/TestTruncate.launchtemplate
        • /hive/trunk/hbase-handler/src/test/templates/TestHBaseCliDriver.vm
        • /hive/trunk/metastore/if/hive_metastore.thrift
        • /hive/trunk/metastore/scripts/hive.metastore_ctrl
        • /hive/trunk/metastore/scripts/hive.metastore_daemon
        • /hive/trunk/metastore/scripts/upgrade/001-HIVE-2795.update_view_partitions.py
        • /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/parser/Filter.g
        • /hive/trunk/metastore/src/model/package.jdo
        • /hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/DummyPreListener.java
        • /hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteUGIHiveMetaStoreIpAddress.java
        • /hive/trunk/ql/if/queryplan.thrift
        • /hive/trunk/ql/src/java/conf/hive-exec-log4j.properties
        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/MetadataOnlyOptimizer.java
        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/mapredplan.jr
        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsUtils.java
        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPPlus.java
        • /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/exec/sample_plan.xml
        • /hive/trunk/ql/src/test/queries/clientnegative/dyn_part_empty.q.disabled
        • /hive/trunk/ql/src/test/scripts/testgrep
        • /hive/trunk/ql/src/test/templates/TestCliDriver.vm
        • /hive/trunk/ql/src/test/templates/TestNegativeCliDriver.vm
        • /hive/trunk/ql/src/test/templates/TestParse.vm
        • /hive/trunk/ql/src/test/templates/TestParseNegative.vm
        • /hive/trunk/serde/if/serde.thrift
        • /hive/trunk/serde/if/test/complex.thrift
        • /hive/trunk/serde/if/test/complexpb.proto
        • /hive/trunk/serde/if/test/testthrift.thrift
        • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/columnar/LazyBinaryColumnarSerDe.java
        • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/dynamic_type/thrift_grammar.jjt
        • /hive/trunk/service/lib/php/ext/thrift_protocol/config.m4
        • /hive/trunk/service/lib/php/ext/thrift_protocol/tags/1.0.0/config.m4
        • /hive/trunk/service/lib/php/ext/thrift_protocol/tags/1.0.0/php_thrift_protocol.cpp
        • /hive/trunk/service/lib/php/ext/thrift_protocol/tags/1.0.0/php_thrift_protocol.h
        • /hive/trunk/service/lib/py/fb303/_init_.py
        • /hive/trunk/service/lib/py/thrift/protocol/fastbinary.c
        • /hive/trunk/service/lib/py/thrift/reflection/_init_.py
        • /hive/trunk/service/lib/py/thrift/reflection/limited/_init_.py
        • /hive/trunk/service/src/test/php/test_service.php
        • /hive/trunk/testutils/compute_stats
        • /hive/trunk/testutils/dump_schema
        • /hive/trunk/testutils/run_tests
        Show
        Hudson added a comment - Integrated in Hive-trunk-hadoop2 #54 (See https://builds.apache.org/job/Hive-trunk-hadoop2/54/ ) HIVE-2930 [jira] Add license to the Hive files (Owen O'Malley via Ashutosh Chauhan) Summary: <<Enter Revision Title>> Fixing rat warnings We need to clean up the RAT report to 0. Apache projects aren't supposed to release until they have shown that all of their files have proper headers. Note that although most of the files are just missing headers, some of them explicitly say copyright by facebook and released under the Thrift (not Apache) license. I'll generate a list of them, but I'd really appreciate it if someone from facebook could in verify that they intend to license them to Apache. Test Plan: EMPTY Reviewers: JIRA, ashutoshc Reviewed By: ashutoshc Differential Revision: https://reviews.facebook.net/D2835 (Revision 1327205) Result = ABORTED hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1327205 Files : /hive/trunk/.checkstyle /hive/trunk/build.properties /hive/trunk/build.xml /hive/trunk/common/src/java/conf/hive-log4j.properties /hive/trunk/conf/configuration.xsl /hive/trunk/conf/hive-env.sh.template /hive/trunk/data/conf/hive-log4j.properties /hive/trunk/data/scripts/cat.py /hive/trunk/data/scripts/cat_error.py /hive/trunk/data/scripts/dumpdata_script.py /hive/trunk/data/scripts/error_script /hive/trunk/data/scripts/input20_script /hive/trunk/docs/velocity.properties /hive/trunk/eclipse-templates/.classpath /hive/trunk/eclipse-templates/.classpath._hbase /hive/trunk/eclipse-templates/.externalToolBuilders/Hive_Ant_Builder.launch /hive/trunk/eclipse-templates/.project /hive/trunk/eclipse-templates/.settings/org.eclipse.jdt.core.prefs /hive/trunk/eclipse-templates/.settings/org.eclipse.jdt.ui.prefs /hive/trunk/eclipse-templates/HiveCLI.launchtemplate /hive/trunk/eclipse-templates/TestCliDriver.launchtemplate /hive/trunk/eclipse-templates/TestEmbeddedHiveMetaStore.launchtemplate /hive/trunk/eclipse-templates/TestHBaseCliDriver.launchtemplate /hive/trunk/eclipse-templates/TestHive.launchtemplate /hive/trunk/eclipse-templates/TestHiveMetaStoreChecker.launchtemplate /hive/trunk/eclipse-templates/TestJdbc.launchtemplate /hive/trunk/eclipse-templates/TestMTQueries.launchtemplate /hive/trunk/eclipse-templates/TestRemoteHiveMetaStore.launchtemplate /hive/trunk/eclipse-templates/TestTruncate.launchtemplate /hive/trunk/hbase-handler/src/test/templates/TestHBaseCliDriver.vm /hive/trunk/metastore/if/hive_metastore.thrift /hive/trunk/metastore/scripts/hive.metastore_ctrl /hive/trunk/metastore/scripts/hive.metastore_daemon /hive/trunk/metastore/scripts/upgrade/001- HIVE-2795 .update_view_partitions.py /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/parser/Filter.g /hive/trunk/metastore/src/model/package.jdo /hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/DummyPreListener.java /hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteUGIHiveMetaStoreIpAddress.java /hive/trunk/ql/if/queryplan.thrift /hive/trunk/ql/src/java/conf/hive-exec-log4j.properties /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/MetadataOnlyOptimizer.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/mapredplan.jr /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsUtils.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPPlus.java /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/exec/sample_plan.xml /hive/trunk/ql/src/test/queries/clientnegative/dyn_part_empty.q.disabled /hive/trunk/ql/src/test/scripts/testgrep /hive/trunk/ql/src/test/templates/TestCliDriver.vm /hive/trunk/ql/src/test/templates/TestNegativeCliDriver.vm /hive/trunk/ql/src/test/templates/TestParse.vm /hive/trunk/ql/src/test/templates/TestParseNegative.vm /hive/trunk/serde/if/serde.thrift /hive/trunk/serde/if/test/complex.thrift /hive/trunk/serde/if/test/complexpb.proto /hive/trunk/serde/if/test/testthrift.thrift /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/columnar/LazyBinaryColumnarSerDe.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/dynamic_type/thrift_grammar.jjt /hive/trunk/service/lib/php/ext/thrift_protocol/config.m4 /hive/trunk/service/lib/php/ext/thrift_protocol/tags/1.0.0/config.m4 /hive/trunk/service/lib/php/ext/thrift_protocol/tags/1.0.0/php_thrift_protocol.cpp /hive/trunk/service/lib/php/ext/thrift_protocol/tags/1.0.0/php_thrift_protocol.h /hive/trunk/service/lib/py/fb303/_ init _.py /hive/trunk/service/lib/py/thrift/protocol/fastbinary.c /hive/trunk/service/lib/py/thrift/reflection/_ init _.py /hive/trunk/service/lib/py/thrift/reflection/limited/_ init _.py /hive/trunk/service/src/test/php/test_service.php /hive/trunk/testutils/compute_stats /hive/trunk/testutils/dump_schema /hive/trunk/testutils/run_tests

          People

          • Assignee:
            Owen O'Malley
            Reporter:
            Owen O'Malley
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development