Hive
  1. Hive
  2. HIVE-2894

RCFile Reader doesn't provide access to Metadata

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0
    • Component/s: None
    • Labels:
      None

      Description

      Currently the RCFile writer can add metadata to an RCFile, but the reader doesn't provide an accessor. I'd like to add one.

        Activity

        Hide
        Phabricator added a comment -

        omalley requested code review of "HIVE-2894 [jira] RCFile Reader doesn't provide access to Metadata".
        Reviewers: JIRA

        hive-2894

        Add an accessor for RCFile's metadata.

        Currently the RCFile writer can add metadata to an RCFile, but the reader doesn't provide an accessor. I'd like to add one.

        TEST PLAN
        I added a call to test that the metadata that was passed in was available from
        the reader.

        REVISION DETAIL
        https://reviews.facebook.net/D2421

        AFFECTED FILES
        ql/src/java/org/apache/hadoop/hive/ql/io/RCFile.java
        ql/src/test/org/apache/hadoop/hive/ql/io/TestRCFile.java

        MANAGE HERALD DIFFERENTIAL RULES
        https://reviews.facebook.net/herald/view/differential/

        WHY DID I GET THIS EMAIL?
        https://reviews.facebook.net/herald/transcript/5421/

        Tip: use the X-Herald-Rules header to filter Herald messages in your client.

        Show
        Phabricator added a comment - omalley requested code review of " HIVE-2894 [jira] RCFile Reader doesn't provide access to Metadata". Reviewers: JIRA hive-2894 Add an accessor for RCFile's metadata. Currently the RCFile writer can add metadata to an RCFile, but the reader doesn't provide an accessor. I'd like to add one. TEST PLAN I added a call to test that the metadata that was passed in was available from the reader. REVISION DETAIL https://reviews.facebook.net/D2421 AFFECTED FILES ql/src/java/org/apache/hadoop/hive/ql/io/RCFile.java ql/src/test/org/apache/hadoop/hive/ql/io/TestRCFile.java MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/5421/ Tip: use the X-Herald-Rules header to filter Herald messages in your client.
        Hide
        Owen O'Malley added a comment -

        I ran the test cases and they pass.

        Show
        Owen O'Malley added a comment - I ran the test cases and they pass.
        Hide
        Phabricator added a comment -

        ashutoshc has accepted the revision "HIVE-2894 [jira] RCFile Reader doesn't provide access to Metadata".

        +1 will commit this one soon

        REVISION DETAIL
        https://reviews.facebook.net/D2421

        BRANCH
        h-2894

        Show
        Phabricator added a comment - ashutoshc has accepted the revision " HIVE-2894 [jira] RCFile Reader doesn't provide access to Metadata". +1 will commit this one soon REVISION DETAIL https://reviews.facebook.net/D2421 BRANCH h-2894
        Hide
        Ashutosh Chauhan added a comment -

        Committed to trunk. Thanks, Owen!

        Show
        Ashutosh Chauhan added a comment - Committed to trunk. Thanks, Owen!
        Hide
        Phabricator added a comment -

        omalley has committed the revision "HIVE-2894 [jira] RCFile Reader doesn't provide access to Metadata".

        Change committed by hashutosh.

        REVISION DETAIL
        https://reviews.facebook.net/D2421

        COMMIT
        https://reviews.facebook.net/rHIVE1304693

        Show
        Phabricator added a comment - omalley has committed the revision " HIVE-2894 [jira] RCFile Reader doesn't provide access to Metadata". Change committed by hashutosh. REVISION DETAIL https://reviews.facebook.net/D2421 COMMIT https://reviews.facebook.net/rHIVE1304693
        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-h0.21 #1330 (See https://builds.apache.org/job/Hive-trunk-h0.21/1330/)
        HIVE-2894 [jira] RCFile Reader doesn't provide access to Metadata
        (Owen O'Malley via Ashutosh Chauhan)

        Summary:
        hive-2894

        Add an accessor for RCFile's metadata.

        Currently the RCFile writer can add metadata to an RCFile, but the reader
        doesn't provide an accessor. I'd like to add one.

        Test Plan:
        I added a call to test that the metadata that was passed in was available from
        the reader.

        Reviewers: JIRA, ashutoshc

        Reviewed By: ashutoshc

        Differential Revision: https://reviews.facebook.net/D2421 (Revision 1304693)

        Result = SUCCESS
        hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304693
        Files :

        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/io/RCFile.java
        • /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/io/TestRCFile.java
        Show
        Hudson added a comment - Integrated in Hive-trunk-h0.21 #1330 (See https://builds.apache.org/job/Hive-trunk-h0.21/1330/ ) HIVE-2894 [jira] RCFile Reader doesn't provide access to Metadata (Owen O'Malley via Ashutosh Chauhan) Summary: hive-2894 Add an accessor for RCFile's metadata. Currently the RCFile writer can add metadata to an RCFile, but the reader doesn't provide an accessor. I'd like to add one. Test Plan: I added a call to test that the metadata that was passed in was available from the reader. Reviewers: JIRA, ashutoshc Reviewed By: ashutoshc Differential Revision: https://reviews.facebook.net/D2421 (Revision 1304693) Result = SUCCESS hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304693 Files : /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/io/RCFile.java /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/io/TestRCFile.java
        Hide
        Ashutosh Chauhan added a comment -

        This issue is closed now. It was released with the fix in 0.9.0. If there is a problem, please open a new jira and link this one with that.

        Show
        Ashutosh Chauhan added a comment - This issue is closed now. It was released with the fix in 0.9.0. If there is a problem, please open a new jira and link this one with that.
        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-hadoop2 #54 (See https://builds.apache.org/job/Hive-trunk-hadoop2/54/)
        HIVE-2894 [jira] RCFile Reader doesn't provide access to Metadata
        (Owen O'Malley via Ashutosh Chauhan)

        Summary:
        hive-2894

        Add an accessor for RCFile's metadata.

        Currently the RCFile writer can add metadata to an RCFile, but the reader
        doesn't provide an accessor. I'd like to add one.

        Test Plan:
        I added a call to test that the metadata that was passed in was available from
        the reader.

        Reviewers: JIRA, ashutoshc

        Reviewed By: ashutoshc

        Differential Revision: https://reviews.facebook.net/D2421 (Revision 1304693)

        Result = ABORTED
        hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304693
        Files :

        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/io/RCFile.java
        • /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/io/TestRCFile.java
        Show
        Hudson added a comment - Integrated in Hive-trunk-hadoop2 #54 (See https://builds.apache.org/job/Hive-trunk-hadoop2/54/ ) HIVE-2894 [jira] RCFile Reader doesn't provide access to Metadata (Owen O'Malley via Ashutosh Chauhan) Summary: hive-2894 Add an accessor for RCFile's metadata. Currently the RCFile writer can add metadata to an RCFile, but the reader doesn't provide an accessor. I'd like to add one. Test Plan: I added a call to test that the metadata that was passed in was available from the reader. Reviewers: JIRA, ashutoshc Reviewed By: ashutoshc Differential Revision: https://reviews.facebook.net/D2421 (Revision 1304693) Result = ABORTED hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304693 Files : /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/io/RCFile.java /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/io/TestRCFile.java

          People

          • Assignee:
            Owen O'Malley
            Reporter:
            Owen O'Malley
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development