Hive
  1. Hive
  2. HIVE-2815

Filter pushdown in hbase for keys stored in binary format

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.6.0, 0.7.0, 0.7.1, 0.8.0, 0.8.1
    • Fix Version/s: 0.9.0
    • Component/s: HBase Handler
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      This patch enables filter pushdown for keys stored in binary format in hbase

        Issue Links

          Activity

          Hide
          Phabricator added a comment -

          ashutoshc requested code review of "HIVE-2815 [jira] Filter pushdown in hbase for keys stored in binary format".
          Reviewers: JIRA

          Further support for pushdown on keys stored in binary format

          This patch enables filter pushdown for keys stored in binary format in hbase

          TEST PLAN
          Included a new test case.

          REVISION DETAIL
          https://reviews.facebook.net/D1875

          AFFECTED FILES
          hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseSerDe.java
          hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStorageHandler.java
          hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHBaseTableInputFormat.java
          hbase-handler/src/test/queries/external_table_ppd.q
          hbase-handler/src/test/results/external_table_ppd.q.out

          MANAGE HERALD DIFFERENTIAL RULES
          https://reviews.facebook.net/herald/view/differential/

          WHY DID I GET THIS EMAIL?
          https://reviews.facebook.net/herald/transcript/3981/

          Tip: use the X-Herald-Rules header to filter Herald messages in your client.

          Show
          Phabricator added a comment - ashutoshc requested code review of " HIVE-2815 [jira] Filter pushdown in hbase for keys stored in binary format". Reviewers: JIRA Further support for pushdown on keys stored in binary format This patch enables filter pushdown for keys stored in binary format in hbase TEST PLAN Included a new test case. REVISION DETAIL https://reviews.facebook.net/D1875 AFFECTED FILES hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseSerDe.java hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStorageHandler.java hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHBaseTableInputFormat.java hbase-handler/src/test/queries/external_table_ppd.q hbase-handler/src/test/results/external_table_ppd.q.out MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/3981/ Tip: use the X-Herald-Rules header to filter Herald messages in your client.
          Hide
          Phabricator added a comment -

          ashutoshc updated the revision "HIVE-2815 [jira] Filter pushdown in hbase for keys stored in binary format".
          Reviewers: JIRA, jsichi, njain

          Rebased to trunk.

          REVISION DETAIL
          https://reviews.facebook.net/D1875

          AFFECTED FILES
          hbase-handler/src/test/results/external_table_ppd.q.out
          hbase-handler/src/test/queries/external_table_ppd.q
          hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHBaseTableInputFormat.java
          hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseSerDe.java
          hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStorageHandler.java

          Show
          Phabricator added a comment - ashutoshc updated the revision " HIVE-2815 [jira] Filter pushdown in hbase for keys stored in binary format". Reviewers: JIRA, jsichi, njain Rebased to trunk. REVISION DETAIL https://reviews.facebook.net/D1875 AFFECTED FILES hbase-handler/src/test/results/external_table_ppd.q.out hbase-handler/src/test/queries/external_table_ppd.q hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHBaseTableInputFormat.java hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseSerDe.java hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStorageHandler.java
          Hide
          Phabricator added a comment -

          cwsteinbach has accepted the revision "HIVE-2815 [jira] Filter pushdown in hbase for keys stored in binary format".

          +1. Will commit if tests pass.

          REVISION DETAIL
          https://reviews.facebook.net/D1875

          BRANCH
          svn

          Show
          Phabricator added a comment - cwsteinbach has accepted the revision " HIVE-2815 [jira] Filter pushdown in hbase for keys stored in binary format". +1. Will commit if tests pass. REVISION DETAIL https://reviews.facebook.net/D1875 BRANCH svn
          Hide
          Carl Steinbach added a comment -

          Committed to trunk. Thanks Ashutosh!

          Show
          Carl Steinbach added a comment - Committed to trunk. Thanks Ashutosh!
          Hide
          Phabricator added a comment -

          ashutoshc has committed the revision "HIVE-2815 [jira] Filter pushdown in hbase for keys stored in binary format".

          Change committed by cws.

          REVISION DETAIL
          https://reviews.facebook.net/D1875

          COMMIT
          https://reviews.facebook.net/rHIVE1301315

          Show
          Phabricator added a comment - ashutoshc has committed the revision " HIVE-2815 [jira] Filter pushdown in hbase for keys stored in binary format". Change committed by cws. REVISION DETAIL https://reviews.facebook.net/D1875 COMMIT https://reviews.facebook.net/rHIVE1301315
          Hide
          Hudson added a comment -

          Integrated in Hive-trunk-h0.21 #1313 (See https://builds.apache.org/job/Hive-trunk-h0.21/1313/)
          HIVE-2815 [jira] Filter pushdown in hbase for keys stored in binary format
          (Ashutosh Chauhan via Carl Steinbach)

          Summary:
          Further support for pushdown on keys stored in binary format

          This patch enables filter pushdown for keys stored in binary format in hbase

          Test Plan: Included a new test case.

          Reviewers: JIRA, jsichi, njain, cwsteinbach

          Reviewed By: cwsteinbach

          Differential Revision: https://reviews.facebook.net/D1875 (Revision 1301315)

          Result = FAILURE
          cws : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1301315
          Files :

          • /hive/trunk/hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseSerDe.java
          • /hive/trunk/hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStorageHandler.java
          • /hive/trunk/hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHBaseTableInputFormat.java
          • /hive/trunk/hbase-handler/src/test/queries/external_table_ppd.q
          • /hive/trunk/hbase-handler/src/test/results/external_table_ppd.q.out
          Show
          Hudson added a comment - Integrated in Hive-trunk-h0.21 #1313 (See https://builds.apache.org/job/Hive-trunk-h0.21/1313/ ) HIVE-2815 [jira] Filter pushdown in hbase for keys stored in binary format (Ashutosh Chauhan via Carl Steinbach) Summary: Further support for pushdown on keys stored in binary format This patch enables filter pushdown for keys stored in binary format in hbase Test Plan: Included a new test case. Reviewers: JIRA, jsichi, njain, cwsteinbach Reviewed By: cwsteinbach Differential Revision: https://reviews.facebook.net/D1875 (Revision 1301315) Result = FAILURE cws : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1301315 Files : /hive/trunk/hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseSerDe.java /hive/trunk/hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStorageHandler.java /hive/trunk/hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHBaseTableInputFormat.java /hive/trunk/hbase-handler/src/test/queries/external_table_ppd.q /hive/trunk/hbase-handler/src/test/results/external_table_ppd.q.out
          Hide
          Ashutosh Chauhan added a comment -

          This issue is closed now. It was released with the fix in 0.9.0. If there is a problem, please open a new jira and link this one with that.

          Show
          Ashutosh Chauhan added a comment - This issue is closed now. It was released with the fix in 0.9.0. If there is a problem, please open a new jira and link this one with that.
          Hide
          Hudson added a comment -

          Integrated in Hive-trunk-hadoop2 #54 (See https://builds.apache.org/job/Hive-trunk-hadoop2/54/)
          HIVE-2815 [jira] Filter pushdown in hbase for keys stored in binary format
          (Ashutosh Chauhan via Carl Steinbach)

          Summary:
          Further support for pushdown on keys stored in binary format

          This patch enables filter pushdown for keys stored in binary format in hbase

          Test Plan: Included a new test case.

          Reviewers: JIRA, jsichi, njain, cwsteinbach

          Reviewed By: cwsteinbach

          Differential Revision: https://reviews.facebook.net/D1875 (Revision 1301315)

          Result = ABORTED
          cws : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1301315
          Files :

          • /hive/trunk/hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseSerDe.java
          • /hive/trunk/hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStorageHandler.java
          • /hive/trunk/hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHBaseTableInputFormat.java
          • /hive/trunk/hbase-handler/src/test/queries/external_table_ppd.q
          • /hive/trunk/hbase-handler/src/test/results/external_table_ppd.q.out
          Show
          Hudson added a comment - Integrated in Hive-trunk-hadoop2 #54 (See https://builds.apache.org/job/Hive-trunk-hadoop2/54/ ) HIVE-2815 [jira] Filter pushdown in hbase for keys stored in binary format (Ashutosh Chauhan via Carl Steinbach) Summary: Further support for pushdown on keys stored in binary format This patch enables filter pushdown for keys stored in binary format in hbase Test Plan: Included a new test case. Reviewers: JIRA, jsichi, njain, cwsteinbach Reviewed By: cwsteinbach Differential Revision: https://reviews.facebook.net/D1875 (Revision 1301315) Result = ABORTED cws : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1301315 Files : /hive/trunk/hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseSerDe.java /hive/trunk/hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStorageHandler.java /hive/trunk/hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHBaseTableInputFormat.java /hive/trunk/hbase-handler/src/test/queries/external_table_ppd.q /hive/trunk/hbase-handler/src/test/results/external_table_ppd.q.out

            People

            • Assignee:
              Ashutosh Chauhan
              Reporter:
              Ashutosh Chauhan
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development