[HIVE-27825] Better error message for an empty quoted identifier

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 4.0.0-beta-1
• Fix Version/s: 4.0.0
• Component/s: Parser
• Labels: pull-request-available
• Assignee: Shohei Okumiya
• Reporter: Shohei Okumiya
• Created: 25/Oct/23 14:48
• Updated: 29/Mar/24 17:50
• Resolved: 30/Oct/23 04:08

Description

SemanticAnalyzer throws a StringIndexOutOfBoundsException when a quoted identifier is empty. It is likely to happen when a template system fails to fill a database name or table name. We should return a better message so that a user can easily identify where is wrong.

 

0: jdbc:hive2://hive-hiveserver2:10000/defaul> SELECT * FROM ``;
Error: Error while compiling statement: FAILED: StringIndexOutOfBoundsException String index out of range: 0 (state=42000,code=40000) 

This is the stacktrace on HiveServer2.

org.apache.hive.service.cli.HiveSQLException: Error while compiling statement: FAILED: StringIndexOutOfBoundsException String index out of range: 0
     at org.apache.hive.service.cli.operation.Operation.toSQLException(Operation.java:376) ~[hive-service-4.0.0-beta-2-SNAPSHOT.jar:4.0.0-beta-2-SNAPSHOT]
     at org.apache.hive.service.cli.operation.SQLOperation.prepare(SQLOperation.java:214) ~[hive-service-4.0.0-beta-2-SNAPSHOT.jar:4.0.0-beta-2-SNAPSHOT]
...
 Caused by: java.lang.StringIndexOutOfBoundsException: String index out of range: 0
     at java.lang.String.charAt(String.java:658) ~[?:1.8.0_275]
     at org.apache.hadoop.hive.ql.parse.BaseSemanticAnalyzer.unescapeIdentifier(BaseSemanticAnalyzer.java:608) ~[hive-exec-4.0.0-beta-2-SNAPSHOT.jar:4.0.0-beta-2-SNAPSHOT]
     at org.apache.hadoop.hive.ql.parse.BaseSemanticAnalyzer.getDbTableNamePair(BaseSemanticAnalyzer.java:424) ~[hive-exec-4.0.0-beta-2-SNAPSHOT.jar:4.0.0-beta-2-SNAPSHOT]

 

 

 

 

Issue Links

• links to: GitHub Pull Request #4829