[HIVE-2773] HiveStorageHandler.configureTableJobProperites() should let the handler know wether it is configuration for input or output

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.9.0
• Labels: hcatalog storage_handler
• Release Note: HiveStorageHandler.configureTableJobProperties() has been replaced with configureInputJobProperties() and configureOutputJobProperties().
• Assignee: Francis Christopher Liu
• Reporter: Francis Christopher Liu
• Created: 01/Feb/12 19:00
• Updated: 09/Jan/13 10:23
• Resolved: 23/Mar/12 02:39

Description

HiveStorageHandler.configureTableJobProperties() is called to allow the storage handler to setup any properties that the underlying inputformat/outputformat/serde may need. But the handler implementation does not know whether it is being called for configuring input or output. This makes it a problem for handlers which sets an external state. In the case of HCatalog's HBase storageHandler, whenever a write needs to be configured we create a write transaction which needs to be committed or aborted later on. In this case configuring for both input and output each time configureTableJobProperties() is called would not be desirable. This has become an issue since HCatalog is dropping storageDrivers for SerDe and StorageHandler (see HCATALOG-237).

My proposal is to replace configureTableJobProperties() with two methods:

configureInputJobProperties()
configureOutputJobProperties()

Each method will have the same signature. I cursory look at the code and I believe changes should be straighforward also given that we are not really changing anything just splitting responsibility. If the community is fine with this approach I will go ahead and create a aptch.

Issue Links

• blocks: HCATALOG-263 Make HBaseHCatStorageHandler work with Hive
• is related to: HIVE-2764 Obtain delegation tokens for MR jobs in secure hbase setup