[HIVE-27004] DateTimeFormatterBuilder cannot parse 'UTC+' in Java versions higher than 8

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 4.0.0-beta-1
• Component/s: Hive
• Labels: pull-request-available

Environment

Java version used 

openjdk version "11.0.16.1" 2022-08-12 LTS OpenJDK Runtime Environment Corretto-11.0.16.9.1 (build 11.0.16.1+9-LTS) OpenJDK 64-Bit Server VM Corretto-11.0.16.9.1 (build 11.0.16.1+9-LTS, mixed mode

 

• Flags: Patch
• Assignee: Anmol Sundaram
• Reporter: Anmol Sundaram
• Created: 31/Jan/23 05:25
• Updated: 15/Aug/23 06:33
• Resolved: 03/Feb/23 04:46

Description

Some of the unit tests related to DateTimeFormatter were failing in Java versions greater than 8 while working in Java 8.

Example of a failing Unit Test : org.apache.hadoop.hive.common.type.TestTimestampTZ#testComparision

 

java.time.format.DateTimeParseException: Text '2017-04-14 18:00:00 UTC+08:00' could not be parsed, unparsed text found at index 23 at java.base/java.time.format.DateTimeFormatter.parseResolved0(DateTimeFormatter.java:2049) at java.base/java.time.format.DateTimeFormatter.parse(DateTimeFormatter.java:1874) at org.apache.hadoop.hive.common.type.TimestampTZUtil.parse(TimestampTZUtil.java:76) at org.apache.hadoop.hive.common.type.TimestampTZUtil.parse(TimestampTZUtil.java:64) at org.apache.hadoop.hive.common.type.TestTimestampTZ.testComparison(TestTimestampTZ.java:44) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

 

The appendZoneText(TextStyle) method of DateTimeFormatteBuilder is not able to parse the + symbol in 2017-04-14 18:00:00 UTC+08:00 when running the test in Java 11 , while it is working fine with Java 8.

According to the doc , appendZoneText(TextStyle) should be able to parse either the textual zone name, the zone ID or the offset and UTC+08:00 should come under offset as per the same doc.

It seems, however, that "UTC" was explicitly removed when parsed as ZoneText for higher Java versions

As a workaround, we can use appendZoneOrOffsetId() rather than appendZoneText().

This ensures the tests are passing for Java 8+ and based on my testing, I didn’t see any regression of the change.

Sample repro code - jdoodle.com/ia/D5e

 

Issue Links

• links to: GitHub Pull Request #4008