Hive
  1. Hive
  2. HIVE-2654

"hive.querylog.location" requires parent directory to be exist or else folder creation fails

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0
    • Component/s: Query Processor
    • Labels:
      None
    • Environment:

      Hadoop 0.20.1, Hive0.9.0 and SUSE Linux Enterprise Server 10 SP2 (i586) - Kernel 2.6.16.60-0.21-smp (5).

    • Hadoop Flags:
      Reviewed

      Description

      if value of "hive.querylog.location" is '/tmp/root/hive123/test' if the parent directories not exist the creation of the folder is failed.

      1. ASF.LICENSE.NOT.GRANTED--HIVE-2654.D885.1.patch
        2 kB
        Phabricator
      2. HIVE-2654.patch
        2 kB
        Chinna Rao Lalam

        Activity

        Hide
        Chinna Rao Lalam added a comment -

        Patch uploaded in Phabricator.
        https://reviews.facebook.net/D855

        Show
        Chinna Rao Lalam added a comment - Patch uploaded in Phabricator. https://reviews.facebook.net/D855
        Hide
        Chinna Rao Lalam added a comment -

        For creating directory mkdir() api is used in HiveHistory() that changed to mkdirs()..

        Show
        Chinna Rao Lalam added a comment - For creating directory mkdir() api is used in HiveHistory() that changed to mkdirs()..
        Hide
        Phabricator added a comment -

        njain requested code review of "HIVE-2654 [jira] "hive.querylog.location" requires parent directory to be exist or else folder creation fails".
        Reviewers: JIRA

        HIVE-2654

        if value of "hive.querylog.location" is '/tmp/root/hive123/test' if the parent directories not exist the creation of the folder is failed.

        TEST PLAN
        EMPTY

        REVISION DETAIL
        https://reviews.facebook.net/D885

        AFFECTED FILES
        ql/src/test/org/apache/hadoop/hive/ql/history/TestHiveHistory.java
        ql/src/java/org/apache/hadoop/hive/ql/history/HiveHistory.java

        MANAGE HERALD DIFFERENTIAL RULES
        https://reviews.facebook.net/herald/view/differential/

        WHY DID I GET THIS EMAIL?
        https://reviews.facebook.net/herald/transcript/1869/

        Tip: use the X-Herald-Rules header to filter Herald messages in your client.

        Show
        Phabricator added a comment - njain requested code review of " HIVE-2654 [jira] "hive.querylog.location" requires parent directory to be exist or else folder creation fails". Reviewers: JIRA HIVE-2654 if value of "hive.querylog.location" is '/tmp/root/hive123/test' if the parent directories not exist the creation of the folder is failed. TEST PLAN EMPTY REVISION DETAIL https://reviews.facebook.net/D885 AFFECTED FILES ql/src/test/org/apache/hadoop/hive/ql/history/TestHiveHistory.java ql/src/java/org/apache/hadoop/hive/ql/history/HiveHistory.java MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/1869/ Tip: use the X-Herald-Rules header to filter Herald messages in your client.
        Hide
        Namit Jain added a comment -

        +1

        Show
        Namit Jain added a comment - +1
        Hide
        Namit Jain added a comment -

        Committed. Thanks Chinna Rao Lalam

        Show
        Namit Jain added a comment - Committed. Thanks Chinna Rao Lalam
        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-h0.23.0 #28 (See https://builds.apache.org/job/Hive-trunk-h0.23.0/28/)
        HIVE-2654 "hive.querylog.location" requires parent directory to be exist or
        else folder creation fails (Chinna Rao Lalam via namit)

        namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1214891
        Files :

        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/history/HiveHistory.java
        • /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/history/TestHiveHistory.java
        Show
        Hudson added a comment - Integrated in Hive-trunk-h0.23.0 #28 (See https://builds.apache.org/job/Hive-trunk-h0.23.0/28/ ) HIVE-2654 "hive.querylog.location" requires parent directory to be exist or else folder creation fails (Chinna Rao Lalam via namit) namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1214891 Files : /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/history/HiveHistory.java /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/history/TestHiveHistory.java
        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-h0.21 #1150 (See https://builds.apache.org/job/Hive-trunk-h0.21/1150/)
        HIVE-2654 "hive.querylog.location" requires parent directory to be exist or
        else folder creation fails (Chinna Rao Lalam via namit)

        namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1214891
        Files :

        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/history/HiveHistory.java
        • /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/history/TestHiveHistory.java
        Show
        Hudson added a comment - Integrated in Hive-trunk-h0.21 #1150 (See https://builds.apache.org/job/Hive-trunk-h0.21/1150/ ) HIVE-2654 "hive.querylog.location" requires parent directory to be exist or else folder creation fails (Chinna Rao Lalam via namit) namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1214891 Files : /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/history/HiveHistory.java /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/history/TestHiveHistory.java
        Hide
        Ashutosh Chauhan added a comment -

        This issue is closed now. It was released with the fix in 0.9.0. If there is a problem, please open a new jira and link this one with that.

        Show
        Ashutosh Chauhan added a comment - This issue is closed now. It was released with the fix in 0.9.0. If there is a problem, please open a new jira and link this one with that.

          People

          • Assignee:
            Chinna Rao Lalam
            Reporter:
            Chinna Rao Lalam
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development