[HIVE-26312] Use default digest normalization strategy in CBO

• Type: Task
• Status: In Progress
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 4.0.0-alpha-1
• Component/s: CBO
• Labels: pull-request-available
• Target Version/s: 4.0.0-alpha-2
• Assignee: Stamatis Zampetakis
• Reporter: Stamatis Zampetakis
• Created: 10/Jun/22 13:29
• Updated: 02/Nov/22 00:26

Description

CALCITE-2450 introduced a way to improve planning time by normalizing some query expressions (RexNodes). The behavior can be enabled/disabled via the following system property: calcite.enable.rexnode.digest.normalize

There was an attempt to disable the normalization explicitly in HIVE-23456 to avoid rendering HiveFilterSortPredicates rule useless. However, the way the normalization is disabled now, dependents on the way classes are loaded. If for some reason CalciteSystemProperty is loaded before hitting the respective line in Hive.java setting the property will not have any effect.

After HIVE-26238 the behavior of the rule is not dependent in the value of the property so there is nothing holding us back from enabling the normalization.

At the moment there is not strong reason to enable or disable the normalization explicitly so it is better to rely on the default value provided by Calcite to avoid running with different normalization strategy when the class loading order changes.

Issue Links

• depends upon: HIVE-26238 Decouple sort filter predicates optimization from digest normalization in CBO
• relates to: CALCITE-2450 RexSimplify: reorder predicates to a canonical form as a part of RexSimplify
• relates to: HIVE-23456 Upgrade Calcite version to 1.25.0
• links to: GitHub Pull Request #3359