[HIVE-25989] CTLT HBaseStorageHandler is dropping underlying HBase table when failed

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Labels: pull-request-available
• Assignee: Marton Bod
• Reporter: Naresh P R
• Created: 26/Feb/22 02:04
• Updated: 06/Apr/22 06:39
• Resolved: 10/Mar/22 11:11

Description

With hive.strict.managed.tables & hive.create.as.acid, 

Hive-Hbase rollback code is assuming it is a createTable failure instead of CTLT & removing underlying hbase table while rolling back at here.
https://github.com/apache/hive/blob/master/hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseMetaHook.java#L187-L195

 

Repro

 

hbase
=====
hbase shell
create 'hbase_hive_table', 'cf'
beeline
=======
set hive.support.concurrency=true;
set hive.txn.manager=org.apache.hadoop.hive.ql.lockmgr.DbTxnManager;
set hive.strict.managed.tables=true;
set hive.create.as.acid=true;
set hive.create.as.insert.only=true;
set hive.default.fileformat.managed=ORC;
> CREATE EXTERNAL TABLE `hbase_hive_table`(                       
   `key` int COMMENT '',                            
   `value` string COMMENT '')                       
 ROW FORMAT SERDE                                   
   'org.apache.hadoop.hive.hbase.HBaseSerDe'        
 STORED BY                                          
   'org.apache.hadoop.hive.hbase.HBaseStorageHandler'  
 WITH SERDEPROPERTIES (                             
   'hbase.columns.mapping'=':key,cf:cf')                      
 TBLPROPERTIES ('hbase.table.name'='hbase_hive_table');
> select * from hbase_hive_table;
+-----------------------+-------------------------+
| hbase_hive_table.key  | hbase_hive_table.value  |
+-----------------------+-------------------------+
+-----------------------+-------------------------+
> create table new_hbase_hive_table like hbase_hive_table;
Caused by: org.apache.hadoop.hive.metastore.api.MetaException: The table must be stored using an ACID compliant format (such as ORC): default.new_hbase_hive_table
> select * from hbase_hive_table;
Error: java.io.IOException: org.apache.hadoop.hbase.TableNotFoundException: hbase_hive_table

Issue Links

• fixes: HIVE-25813 CREATE TABLE x LIKE storagehandler-based-source fails
• links to: GitHub Pull Request #3076