[HIVE-25935] Cleanup IMetaStoreClient#getPartitionsByNames APIs

• Type: Task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 4.0.0-alpha-1
• Component/s: Metastore
• Labels: pull-request-available
• Target Version/s: 4.0.0, 4.0.0-alpha-1
• Assignee: Peter Vary
• Reporter: Stamatis Zampetakis
• Created: 07/Feb/22 16:25
• Updated: 17/Nov/22 08:48
• Resolved: 10/Mar/22 09:04

Description

Currently the IMetastoreClient interface has 8 variants of the getPartitionsByNames method. Going quickly over the concrete implementation it appears that not all of them are useful/necessary so a bit of cleanup is needed.

Below a few potential problems I observed:

• Some of the APIs are not used anywhere in the project (neither by production nor by test code).
• Some of the APIs are deprecated in some concrete implementations but not globally at the interface level without an explanation why.
• Some of the implementations simply throw without doing anything.
• Many of the APIs are partially tested or not tested at all.

HIVE-24743, HIVE-25281 are related since they introduce/deprecate some of the aforementioned APIs.

It would be good to review the aforementioned APIs and decide what needs to stay and what needs to go as well as complete necessary when relevant.

Issue Links

• fixes: HIVE-25936 ValidWriteIdList & table id are sometimes missing when requesting partitions by name via HS2
• links to: GitHub Pull Request #3072