Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.8.0
    • Component/s: None
    • Labels:
      None

      Description

      Add a linter that will be run at `arc diff` and will check for too long lines, trailing whitespace, etc.

        Activity

        Hide
        Phabricator added a comment -

        mareksapotafb requested code review of "HIVE-2565 [jira] Add Java linter to Hive".
        Reviewers: JIRA

        Alter .arcconfig to use JavaLintEngine

        Add a linter that will be run at `arc diff` and will check for too long lines, trailing whitespace, etc.

        TEST PLAN
        EMPTY

        REVISION DETAIL
        https://reviews.facebook.net/D345

        AFFECTED FILES
        .arcconfig

        MANAGE HERALD DIFFERENTIAL RULES
        https://reviews.facebook.net/herald/view/differential/

        WHY DID I GET THIS EMAIL?
        https://reviews.facebook.net/herald/transcript/693/

        Tip: use the X-Herald-Rules header to filter Herald messages in your client.

        Show
        Phabricator added a comment - mareksapotafb requested code review of " HIVE-2565 [jira] Add Java linter to Hive". Reviewers: JIRA Alter .arcconfig to use JavaLintEngine Add a linter that will be run at `arc diff` and will check for too long lines, trailing whitespace, etc. TEST PLAN EMPTY REVISION DETAIL https://reviews.facebook.net/D345 AFFECTED FILES .arcconfig MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/693/ Tip: use the X-Herald-Rules header to filter Herald messages in your client.
        Hide
        Phabricator added a comment -

        mareksapotafb has added reviewers to the revision "HIVE-2565 [jira] Add Java linter to Hive".
        Added Reviewers: jsichi

        REVISION DETAIL
        https://reviews.facebook.net/D345

        Show
        Phabricator added a comment - mareksapotafb has added reviewers to the revision " HIVE-2565 [jira] Add Java linter to Hive". Added Reviewers: jsichi REVISION DETAIL https://reviews.facebook.net/D345
        Hide
        Phabricator added a comment -

        jsichi has commented on the revision "HIVE-2565 [jira] Add Java linter to Hive".

        I applied this and tried

        arc lint --lintall */

        but got

        Usage Exception: No paths are lintable.

        REVISION DETAIL
        https://reviews.facebook.net/D345

        Show
        Phabricator added a comment - jsichi has commented on the revision " HIVE-2565 [jira] Add Java linter to Hive". I applied this and tried arc lint --lintall * / but got Usage Exception: No paths are lintable. REVISION DETAIL https://reviews.facebook.net/D345
        Hide
        Phabricator added a comment -

        mareksapotafb has commented on the revision "HIVE-2565 [jira] Add Java linter to Hive".

        You're using Bash? */ trick might not work there, just try giving it some specific paths like:

        arc lint --lintall ql/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/ql/plan/api/Adjacency.java

        REVISION DETAIL
        https://reviews.facebook.net/D345

        Show
        Phabricator added a comment - mareksapotafb has commented on the revision " HIVE-2565 [jira] Add Java linter to Hive". You're using Bash? * / trick might not work there, just try giving it some specific paths like: arc lint --lintall ql/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/ql/plan/api/Adjacency.java REVISION DETAIL https://reviews.facebook.net/D345
        Hide
        Phabricator added a comment -

        jsichi has commented on the revision "HIVE-2565 [jira] Add Java linter to Hive".

        Oh ok, yeah, I was using bash.

        REVISION DETAIL
        https://reviews.facebook.net/D345

        Show
        Phabricator added a comment - jsichi has commented on the revision " HIVE-2565 [jira] Add Java linter to Hive". Oh ok, yeah, I was using bash. REVISION DETAIL https://reviews.facebook.net/D345
        Hide
        Phabricator added a comment -

        jsichi has accepted the revision "HIVE-2565 [jira] Add Java linter to Hive".

        REVISION DETAIL
        https://reviews.facebook.net/D345

        Show
        Phabricator added a comment - jsichi has accepted the revision " HIVE-2565 [jira] Add Java linter to Hive". REVISION DETAIL https://reviews.facebook.net/D345
        Hide
        John Sichi added a comment -

        +1, committed to trunk. Thanks Marek!

        Show
        John Sichi added a comment - +1, committed to trunk. Thanks Marek!
        Hide
        Phabricator added a comment -

        mareksapotafb has committed the revision "HIVE-2565 [jira] Add Java linter to Hive".

        REVISION DETAIL
        https://reviews.facebook.net/D345

        COMMIT
        https://reviews.facebook.net/rHIVE1200031

        Show
        Phabricator added a comment - mareksapotafb has committed the revision " HIVE-2565 [jira] Add Java linter to Hive". REVISION DETAIL https://reviews.facebook.net/D345 COMMIT https://reviews.facebook.net/rHIVE1200031
        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-h0.21 #1072 (See https://builds.apache.org/job/Hive-trunk-h0.21/1072/)
        HIVE-2565 [jira] Add Java linter to Hive
        (Marek Sapota via jvs)

        Summary:
        Alter .arcconfig to use JavaLintEngine

        Add a linter that will be run at `arc diff` and will check for too long lines,
        trailing whitespace, etc.

        Test Plan: EMPTY

        Reviewers: JIRA, jsichi

        Reviewed By: jsichi

        CC: mareksapotafb, jsichi

        Differential Revision: 345

        jvs : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1200031
        Files :

        • /hive/trunk/.arcconfig
        Show
        Hudson added a comment - Integrated in Hive-trunk-h0.21 #1072 (See https://builds.apache.org/job/Hive-trunk-h0.21/1072/ ) HIVE-2565 [jira] Add Java linter to Hive (Marek Sapota via jvs) Summary: Alter .arcconfig to use JavaLintEngine Add a linter that will be run at `arc diff` and will check for too long lines, trailing whitespace, etc. Test Plan: EMPTY Reviewers: JIRA, jsichi Reviewed By: jsichi CC: mareksapotafb, jsichi Differential Revision: 345 jvs : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1200031 Files : /hive/trunk/.arcconfig

          People

          • Assignee:
            Marek Sapota
            Reporter:
            Marek Sapota
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development