Hive
  1. Hive
  2. HIVE-2562

HIVE-2247 Changed the Thrift API causing compatibility issues.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.8.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      HIVE-2247 Added a parameter to alter_partition in the Metastore Thrift API which has been causing compatibility issues with some scripts. We would like to change this to have two methods, one called alter_partition which takes the old parameters, and one called something else (I'll leave the naming up to you) which has the new parameters. The implementation of the old method should just call the new method with null for the new parameter.

      This will fix the compatibility issues.

      1. HIVE-2562-2.patch
        106 kB
        Weiyan Wang
      2. HIVE-2562-1.patch
        106 kB
        Weiyan Wang
      3. HIVE-2562.patch
        107 kB
        Weiyan Wang

        Activity

        Kevin Wilfong created issue -
        Weiyan Wang made changes -
        Field Original Value New Value
        Status Open [ 1 ] Patch Available [ 10002 ]
        Weiyan Wang made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Hide
        Weiyan Wang added a comment -

        keep the old api alter_partition, and add the new api alter_rename_partition. In the server side, alter_partition calls alter_rename_partition with part_vals = null

        Run the "ant test". Only load_fs.q fails, but after I revert the patch and run "ant clean package; ant test -Dtestcase=TestCliDriver -Dqfile=load_fs.q -Dtest.silent=false" it still fails. So I think it's not a bug introduced by my patch

        Show
        Weiyan Wang added a comment - keep the old api alter_partition, and add the new api alter_rename_partition. In the server side, alter_partition calls alter_rename_partition with part_vals = null Run the "ant test". Only load_fs.q fails, but after I revert the patch and run "ant clean package; ant test -Dtestcase=TestCliDriver -Dqfile=load_fs.q -Dtest.silent=false" it still fails. So I think it's not a bug introduced by my patch
        Weiyan Wang made changes -
        Attachment HIVE-2562.patch [ 12503028 ]
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2783/
        -----------------------------------------------------------

        (Updated 2011-11-09 09:04:42.416457)

        Review request for hive, Siying Dong and Kevin Wilfong.

        Changes
        -------

        I thought this patch is going to fix the bug in HIVE-2247, so I should put HIVE-2247 in the bugs field...It seems it is not like what I think.

        Summary (updated)
        -------

        keep the old api alter_partition, and add the new api alter_rename_partition. In the server side, alter_partition calls alter_rename_partition with part_vals = null

        Run the "ant test". Only load_fs.q fails, but after I revert the patch and run "ant clean package; ant test -Dtestcase=TestCliDriver -Dqfile=load_fs.q -Dtest.silent=false" it still fails. So I think it's not a bug introduced by my patch

        This addresses bug HIVE-2562.
        https://issues.apache.org/jira/browse/HIVE-2562

        Diffs


        trunk/metastore/if/hive_metastore.thrift 1199598
        trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1199598
        trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1199598
        trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 1199598
        trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 1199598
        trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 1199598
        trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 1199598
        trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 1199598
        trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1199598
        trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1199598
        trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1199598

        Diff: https://reviews.apache.org/r/2783/diff

        Testing
        -------

        Thanks,

        Weiyan

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2783/ ----------------------------------------------------------- (Updated 2011-11-09 09:04:42.416457) Review request for hive, Siying Dong and Kevin Wilfong. Changes ------- I thought this patch is going to fix the bug in HIVE-2247 , so I should put HIVE-2247 in the bugs field...It seems it is not like what I think. Summary (updated) ------- keep the old api alter_partition, and add the new api alter_rename_partition. In the server side, alter_partition calls alter_rename_partition with part_vals = null Run the "ant test". Only load_fs.q fails, but after I revert the patch and run "ant clean package; ant test -Dtestcase=TestCliDriver -Dqfile=load_fs.q -Dtest.silent=false" it still fails. So I think it's not a bug introduced by my patch This addresses bug HIVE-2562 . https://issues.apache.org/jira/browse/HIVE-2562 Diffs trunk/metastore/if/hive_metastore.thrift 1199598 trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1199598 trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1199598 trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 1199598 trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 1199598 trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 1199598 trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 1199598 trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 1199598 trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1199598 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1199598 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1199598 Diff: https://reviews.apache.org/r/2783/diff Testing ------- Thanks, Weiyan
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2783/#review3131
        -----------------------------------------------------------

        trunk/metastore/if/hive_metastore.thrift
        <https://reviews.apache.org/r/2783/#comment6944>

        can this function just called rename_partition().

        • Ning

        On 2011-11-09 09:04:42, Weiyan Wang wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/2783/

        -----------------------------------------------------------

        (Updated 2011-11-09 09:04:42)

        Review request for hive, Siying Dong and Kevin Wilfong.

        Summary

        -------

        keep the old api alter_partition, and add the new api alter_rename_partition. In the server side, alter_partition calls alter_rename_partition with part_vals = null

        Run the "ant test". Only load_fs.q fails, but after I revert the patch and run "ant clean package; ant test -Dtestcase=TestCliDriver -Dqfile=load_fs.q -Dtest.silent=false" it still fails. So I think it's not a bug introduced by my patch

        This addresses bug HIVE-2562.

        https://issues.apache.org/jira/browse/HIVE-2562

        Diffs

        -----

        trunk/metastore/if/hive_metastore.thrift 1199598

        trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1199598

        trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1199598

        trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 1199598

        trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 1199598

        trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 1199598

        trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 1199598

        trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 1199598

        trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1199598

        trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1199598

        trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1199598

        Diff: https://reviews.apache.org/r/2783/diff

        Testing

        -------

        Thanks,

        Weiyan

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2783/#review3131 ----------------------------------------------------------- trunk/metastore/if/hive_metastore.thrift < https://reviews.apache.org/r/2783/#comment6944 > can this function just called rename_partition(). Ning On 2011-11-09 09:04:42, Weiyan Wang wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2783/ ----------------------------------------------------------- (Updated 2011-11-09 09:04:42) Review request for hive, Siying Dong and Kevin Wilfong. Summary ------- keep the old api alter_partition, and add the new api alter_rename_partition. In the server side, alter_partition calls alter_rename_partition with part_vals = null Run the "ant test". Only load_fs.q fails, but after I revert the patch and run "ant clean package; ant test -Dtestcase=TestCliDriver -Dqfile=load_fs.q -Dtest.silent=false" it still fails. So I think it's not a bug introduced by my patch This addresses bug HIVE-2562 . https://issues.apache.org/jira/browse/HIVE-2562 Diffs ----- trunk/metastore/if/hive_metastore.thrift 1199598 trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1199598 trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1199598 trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 1199598 trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 1199598 trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 1199598 trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 1199598 trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 1199598 trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1199598 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1199598 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1199598 Diff: https://reviews.apache.org/r/2783/diff Testing ------- Thanks, Weiyan
        Hide
        Namit Jain added a comment -

        Remove the files /tmp/*9000 from your machine.
        load_fs.q will succeed after that

        Show
        Namit Jain added a comment - Remove the files /tmp/*9000 from your machine. load_fs.q will succeed after that
        Hide
        jiraposter@reviews.apache.org added a comment -

        On 2011-11-09 17:01:46, Ning Zhang wrote:

        > trunk/metastore/if/hive_metastore.thrift, line 373

        > <https://reviews.apache.org/r/2783/diff/2/?file=56941#file56941line373>

        >

        > can this function just called rename_partition().

        I agree with Ning's comment about the function name, everything else looks good to me.

        • Kevin

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2783/#review3131
        -----------------------------------------------------------

        On 2011-11-09 09:04:42, Weiyan Wang wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/2783/

        -----------------------------------------------------------

        (Updated 2011-11-09 09:04:42)

        Review request for hive, Siying Dong and Kevin Wilfong.

        Summary

        -------

        keep the old api alter_partition, and add the new api alter_rename_partition. In the server side, alter_partition calls alter_rename_partition with part_vals = null

        Run the "ant test". Only load_fs.q fails, but after I revert the patch and run "ant clean package; ant test -Dtestcase=TestCliDriver -Dqfile=load_fs.q -Dtest.silent=false" it still fails. So I think it's not a bug introduced by my patch

        This addresses bug HIVE-2562.

        https://issues.apache.org/jira/browse/HIVE-2562

        Diffs

        -----

        trunk/metastore/if/hive_metastore.thrift 1199598

        trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1199598

        trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1199598

        trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 1199598

        trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 1199598

        trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 1199598

        trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 1199598

        trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 1199598

        trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1199598

        trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1199598

        trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1199598

        Diff: https://reviews.apache.org/r/2783/diff

        Testing

        -------

        Thanks,

        Weiyan

        Show
        jiraposter@reviews.apache.org added a comment - On 2011-11-09 17:01:46, Ning Zhang wrote: > trunk/metastore/if/hive_metastore.thrift, line 373 > < https://reviews.apache.org/r/2783/diff/2/?file=56941#file56941line373 > > > can this function just called rename_partition(). I agree with Ning's comment about the function name, everything else looks good to me. Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2783/#review3131 ----------------------------------------------------------- On 2011-11-09 09:04:42, Weiyan Wang wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2783/ ----------------------------------------------------------- (Updated 2011-11-09 09:04:42) Review request for hive, Siying Dong and Kevin Wilfong. Summary ------- keep the old api alter_partition, and add the new api alter_rename_partition. In the server side, alter_partition calls alter_rename_partition with part_vals = null Run the "ant test". Only load_fs.q fails, but after I revert the patch and run "ant clean package; ant test -Dtestcase=TestCliDriver -Dqfile=load_fs.q -Dtest.silent=false" it still fails. So I think it's not a bug introduced by my patch This addresses bug HIVE-2562 . https://issues.apache.org/jira/browse/HIVE-2562 Diffs ----- trunk/metastore/if/hive_metastore.thrift 1199598 trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1199598 trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1199598 trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 1199598 trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 1199598 trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 1199598 trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 1199598 trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 1199598 trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1199598 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1199598 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1199598 Diff: https://reviews.apache.org/r/2783/diff Testing ------- Thanks, Weiyan
        Weiyan Wang made changes -
        Attachment HIVE-2562-1.patch [ 12503136 ]
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2783/
        -----------------------------------------------------------

        (Updated 2011-11-09 21:38:50.463372)

        Review request for hive, Siying Dong and Kevin Wilfong.

        Changes
        -------

        Address Ning's comment

        Summary
        -------

        keep the old api alter_partition, and add the new api alter_rename_partition. In the server side, alter_partition calls alter_rename_partition with part_vals = null

        Run the "ant test". Only load_fs.q fails, but after I revert the patch and run "ant clean package; ant test -Dtestcase=TestCliDriver -Dqfile=load_fs.q -Dtest.silent=false" it still fails. So I think it's not a bug introduced by my patch

        This addresses bug HIVE-2562.
        https://issues.apache.org/jira/browse/HIVE-2562

        Diffs (updated)


        trunk/metastore/if/hive_metastore.thrift 1199943
        trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1199943
        trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1199943
        trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 1199943
        trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 1199943
        trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 1199943
        trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 1199943
        trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 1199943
        trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1199943
        trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1199943
        trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1199943

        Diff: https://reviews.apache.org/r/2783/diff

        Testing
        -------

        Thanks,

        Weiyan

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2783/ ----------------------------------------------------------- (Updated 2011-11-09 21:38:50.463372) Review request for hive, Siying Dong and Kevin Wilfong. Changes ------- Address Ning's comment Summary ------- keep the old api alter_partition, and add the new api alter_rename_partition. In the server side, alter_partition calls alter_rename_partition with part_vals = null Run the "ant test". Only load_fs.q fails, but after I revert the patch and run "ant clean package; ant test -Dtestcase=TestCliDriver -Dqfile=load_fs.q -Dtest.silent=false" it still fails. So I think it's not a bug introduced by my patch This addresses bug HIVE-2562 . https://issues.apache.org/jira/browse/HIVE-2562 Diffs (updated) trunk/metastore/if/hive_metastore.thrift 1199943 trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1199943 trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1199943 trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 1199943 trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 1199943 trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 1199943 trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 1199943 trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 1199943 trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1199943 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1199943 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1199943 Diff: https://reviews.apache.org/r/2783/diff Testing ------- Thanks, Weiyan
        Hide
        jiraposter@reviews.apache.org added a comment -

        On 2011-11-09 17:01:46, Ning Zhang wrote:

        > trunk/metastore/if/hive_metastore.thrift, line 373

        > <https://reviews.apache.org/r/2783/diff/2/?file=56941#file56941line373>

        >

        > can this function just called rename_partition().

        Kevin Wilfong wrote:

        I agree with Ning's comment about the function name, everything else looks good to me.

        I am still running all unit tests.

        • Weiyan

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2783/#review3131
        -----------------------------------------------------------

        On 2011-11-09 21:38:50, Weiyan Wang wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/2783/

        -----------------------------------------------------------

        (Updated 2011-11-09 21:38:50)

        Review request for hive, Siying Dong and Kevin Wilfong.

        Summary

        -------

        keep the old api alter_partition, and add the new api alter_rename_partition. In the server side, alter_partition calls alter_rename_partition with part_vals = null

        Run the "ant test". Only load_fs.q fails, but after I revert the patch and run "ant clean package; ant test -Dtestcase=TestCliDriver -Dqfile=load_fs.q -Dtest.silent=false" it still fails. So I think it's not a bug introduced by my patch

        This addresses bug HIVE-2562.

        https://issues.apache.org/jira/browse/HIVE-2562

        Diffs

        -----

        trunk/metastore/if/hive_metastore.thrift 1199943

        trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1199943

        trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1199943

        trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 1199943

        trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 1199943

        trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 1199943

        trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 1199943

        trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 1199943

        trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1199943

        trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1199943

        trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1199943

        Diff: https://reviews.apache.org/r/2783/diff

        Testing

        -------

        Thanks,

        Weiyan

        Show
        jiraposter@reviews.apache.org added a comment - On 2011-11-09 17:01:46, Ning Zhang wrote: > trunk/metastore/if/hive_metastore.thrift, line 373 > < https://reviews.apache.org/r/2783/diff/2/?file=56941#file56941line373 > > > can this function just called rename_partition(). Kevin Wilfong wrote: I agree with Ning's comment about the function name, everything else looks good to me. I am still running all unit tests. Weiyan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2783/#review3131 ----------------------------------------------------------- On 2011-11-09 21:38:50, Weiyan Wang wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2783/ ----------------------------------------------------------- (Updated 2011-11-09 21:38:50) Review request for hive, Siying Dong and Kevin Wilfong. Summary ------- keep the old api alter_partition, and add the new api alter_rename_partition. In the server side, alter_partition calls alter_rename_partition with part_vals = null Run the "ant test". Only load_fs.q fails, but after I revert the patch and run "ant clean package; ant test -Dtestcase=TestCliDriver -Dqfile=load_fs.q -Dtest.silent=false" it still fails. So I think it's not a bug introduced by my patch This addresses bug HIVE-2562 . https://issues.apache.org/jira/browse/HIVE-2562 Diffs ----- trunk/metastore/if/hive_metastore.thrift 1199943 trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1199943 trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1199943 trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 1199943 trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 1199943 trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 1199943 trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 1199943 trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 1199943 trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1199943 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1199943 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1199943 Diff: https://reviews.apache.org/r/2783/diff Testing ------- Thanks, Weiyan
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2783/#review3141
        -----------------------------------------------------------

        trunk/metastore/if/hive_metastore.thrift
        <https://reviews.apache.org/r/2783/#comment6951>

        can you keep the comments for this method (after reverting the changes to the comments as well).

        trunk/metastore/if/hive_metastore.thrift
        <https://reviews.apache.org/r/2783/#comment6952>

        the comment here is not clear. are you changing the name of new_part with the name specified by part_vals or you want to change the partition identified by part_vals with the name found in new_part?

        • Ning

        On 2011-11-09 21:38:50, Weiyan Wang wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/2783/

        -----------------------------------------------------------

        (Updated 2011-11-09 21:38:50)

        Review request for hive, Siying Dong and Kevin Wilfong.

        Summary

        -------

        keep the old api alter_partition, and add the new api alter_rename_partition. In the server side, alter_partition calls alter_rename_partition with part_vals = null

        Run the "ant test". Only load_fs.q fails, but after I revert the patch and run "ant clean package; ant test -Dtestcase=TestCliDriver -Dqfile=load_fs.q -Dtest.silent=false" it still fails. So I think it's not a bug introduced by my patch

        This addresses bug HIVE-2562.

        https://issues.apache.org/jira/browse/HIVE-2562

        Diffs

        -----

        trunk/metastore/if/hive_metastore.thrift 1199943

        trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1199943

        trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1199943

        trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 1199943

        trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 1199943

        trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 1199943

        trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 1199943

        trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 1199943

        trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1199943

        trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1199943

        trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1199943

        Diff: https://reviews.apache.org/r/2783/diff

        Testing

        -------

        Thanks,

        Weiyan

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2783/#review3141 ----------------------------------------------------------- trunk/metastore/if/hive_metastore.thrift < https://reviews.apache.org/r/2783/#comment6951 > can you keep the comments for this method (after reverting the changes to the comments as well). trunk/metastore/if/hive_metastore.thrift < https://reviews.apache.org/r/2783/#comment6952 > the comment here is not clear. are you changing the name of new_part with the name specified by part_vals or you want to change the partition identified by part_vals with the name found in new_part? Ning On 2011-11-09 21:38:50, Weiyan Wang wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2783/ ----------------------------------------------------------- (Updated 2011-11-09 21:38:50) Review request for hive, Siying Dong and Kevin Wilfong. Summary ------- keep the old api alter_partition, and add the new api alter_rename_partition. In the server side, alter_partition calls alter_rename_partition with part_vals = null Run the "ant test". Only load_fs.q fails, but after I revert the patch and run "ant clean package; ant test -Dtestcase=TestCliDriver -Dqfile=load_fs.q -Dtest.silent=false" it still fails. So I think it's not a bug introduced by my patch This addresses bug HIVE-2562 . https://issues.apache.org/jira/browse/HIVE-2562 Diffs ----- trunk/metastore/if/hive_metastore.thrift 1199943 trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1199943 trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1199943 trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 1199943 trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 1199943 trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 1199943 trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 1199943 trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 1199943 trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1199943 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1199943 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1199943 Diff: https://reviews.apache.org/r/2783/diff Testing ------- Thanks, Weiyan
        Hide
        Weiyan Wang added a comment -

        Change comment in the thrift api

        Show
        Weiyan Wang added a comment - Change comment in the thrift api
        Weiyan Wang made changes -
        Attachment HIVE-2562-2.patch [ 12503170 ]
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2783/
        -----------------------------------------------------------

        (Updated 2011-11-10 05:46:57.500909)

        Review request for hive, Siying Dong and Kevin Wilfong.

        Summary
        -------

        keep the old api alter_partition, and add the new api alter_rename_partition. In the server side, alter_partition calls alter_rename_partition with part_vals = null

        Run the "ant test". Only load_fs.q fails, but after I revert the patch and run "ant clean package; ant test -Dtestcase=TestCliDriver -Dqfile=load_fs.q -Dtest.silent=false" it still fails. So I think it's not a bug introduced by my patch

        This addresses bug HIVE-2562.
        https://issues.apache.org/jira/browse/HIVE-2562

        Diffs (updated)


        trunk/metastore/if/hive_metastore.thrift 1199943
        trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1199943
        trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1199943
        trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 1199943
        trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 1199943
        trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 1199943
        trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 1199943
        trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 1199943
        trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1199943
        trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1199943
        trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1199943

        Diff: https://reviews.apache.org/r/2783/diff

        Testing
        -------

        Thanks,

        Weiyan

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2783/ ----------------------------------------------------------- (Updated 2011-11-10 05:46:57.500909) Review request for hive, Siying Dong and Kevin Wilfong. Summary ------- keep the old api alter_partition, and add the new api alter_rename_partition. In the server side, alter_partition calls alter_rename_partition with part_vals = null Run the "ant test". Only load_fs.q fails, but after I revert the patch and run "ant clean package; ant test -Dtestcase=TestCliDriver -Dqfile=load_fs.q -Dtest.silent=false" it still fails. So I think it's not a bug introduced by my patch This addresses bug HIVE-2562 . https://issues.apache.org/jira/browse/HIVE-2562 Diffs (updated) trunk/metastore/if/hive_metastore.thrift 1199943 trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1199943 trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1199943 trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 1199943 trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 1199943 trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 1199943 trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 1199943 trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 1199943 trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1199943 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1199943 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1199943 Diff: https://reviews.apache.org/r/2783/diff Testing ------- Thanks, Weiyan
        Hide
        Ning Zhang added a comment -

        +1. Will commit if tests pass.

        Show
        Ning Zhang added a comment - +1. Will commit if tests pass.
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2783/#review3150
        -----------------------------------------------------------

        Ship it!

        • Ning

        On 2011-11-10 05:46:57, Weiyan Wang wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/2783/

        -----------------------------------------------------------

        (Updated 2011-11-10 05:46:57)

        Review request for hive, Siying Dong and Kevin Wilfong.

        Summary

        -------

        keep the old api alter_partition, and add the new api alter_rename_partition. In the server side, alter_partition calls alter_rename_partition with part_vals = null

        Run the "ant test". Only load_fs.q fails, but after I revert the patch and run "ant clean package; ant test -Dtestcase=TestCliDriver -Dqfile=load_fs.q -Dtest.silent=false" it still fails. So I think it's not a bug introduced by my patch

        This addresses bug HIVE-2562.

        https://issues.apache.org/jira/browse/HIVE-2562

        Diffs

        -----

        trunk/metastore/if/hive_metastore.thrift 1199943

        trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1199943

        trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1199943

        trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 1199943

        trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 1199943

        trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 1199943

        trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 1199943

        trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 1199943

        trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1199943

        trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1199943

        trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1199943

        Diff: https://reviews.apache.org/r/2783/diff

        Testing

        -------

        Thanks,

        Weiyan

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2783/#review3150 ----------------------------------------------------------- Ship it! Ning On 2011-11-10 05:46:57, Weiyan Wang wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2783/ ----------------------------------------------------------- (Updated 2011-11-10 05:46:57) Review request for hive, Siying Dong and Kevin Wilfong. Summary ------- keep the old api alter_partition, and add the new api alter_rename_partition. In the server side, alter_partition calls alter_rename_partition with part_vals = null Run the "ant test". Only load_fs.q fails, but after I revert the patch and run "ant clean package; ant test -Dtestcase=TestCliDriver -Dqfile=load_fs.q -Dtest.silent=false" it still fails. So I think it's not a bug introduced by my patch This addresses bug HIVE-2562 . https://issues.apache.org/jira/browse/HIVE-2562 Diffs ----- trunk/metastore/if/hive_metastore.thrift 1199943 trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1199943 trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1199943 trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 1199943 trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 1199943 trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 1199943 trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 1199943 trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 1199943 trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1199943 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1199943 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1199943 Diff: https://reviews.apache.org/r/2783/diff Testing ------- Thanks, Weiyan
        Hide
        Ning Zhang added a comment -

        Committed. Thanks Weiyan!

        Show
        Ning Zhang added a comment - Committed. Thanks Weiyan!
        Ning Zhang made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Fix Version/s 0.9.0 [ 12317742 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-h0.21 #1075 (See https://builds.apache.org/job/Hive-trunk-h0.21/1075/)
        HIVE-2562. HIVE-2247 Changed the Thrift API causing compatibility issues. (Weiyan Wang via Ning Zhang)

        nzhang : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1200442
        Files :

        • /hive/trunk/metastore/if/hive_metastore.thrift
        • /hive/trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp
        • /hive/trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h
        • /hive/trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp
        • /hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java
        • /hive/trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php
        • /hive/trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote
        • /hive/trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py
        • /hive/trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb
        • /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
        • /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
        Show
        Hudson added a comment - Integrated in Hive-trunk-h0.21 #1075 (See https://builds.apache.org/job/Hive-trunk-h0.21/1075/ ) HIVE-2562 . HIVE-2247 Changed the Thrift API causing compatibility issues. (Weiyan Wang via Ning Zhang) nzhang : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1200442 Files : /hive/trunk/metastore/if/hive_metastore.thrift /hive/trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp /hive/trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h /hive/trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp /hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java /hive/trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php /hive/trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote /hive/trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py /hive/trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
        Carl Steinbach made changes -
        Fix Version/s 0.8.0 [ 12316178 ]
        Carl Steinbach made changes -
        Fix Version/s 0.9.0 [ 12317742 ]
        Carl Steinbach made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        6h 59m 1 Weiyan Wang 09/Nov/11 08:28
        Patch Available Patch Available Open Open
        11s 1 Weiyan Wang 09/Nov/11 08:28
        Open Open Resolved Resolved
        1d 9h 1m 1 Ning Zhang 10/Nov/11 17:30
        Resolved Resolved Closed Closed
        36d 6h 26m 1 Carl Steinbach 16/Dec/11 23:56

          People

          • Assignee:
            Weiyan Wang
            Reporter:
            Kevin Wilfong
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development