Hive
  1. Hive
  2. HIVE-2549

Support standard cross join syntax

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.10.0
    • Fix Version/s: 0.10.0
    • Component/s: Query Processor, SQL
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Hive should support standard (ANSI) cross join syntax:

      SELECT a.*, b.*
      FROM a
      CROSS JOIN b
      
      1. hive-2549-1.txt
        8 kB
        Edward Capriolo

        Activity

        Hide
        Navis added a comment -
        Show
        Navis added a comment - https://reviews.facebook.net/D3621
        Hide
        Namit Jain added a comment -

        see comments on phabricator

        Show
        Namit Jain added a comment - see comments on phabricator
        Hide
        Edward Capriolo added a comment -

        Navis can you also please add explain and explain extended. It is actually fairly amazing that cross join just "works" like this to me and covering the explain output in a unit test would make me feel better.

        Show
        Edward Capriolo added a comment - Navis can you also please add explain and explain extended. It is actually fairly amazing that cross join just "works" like this to me and covering the explain output in a unit test would make me feel better.
        Hide
        Edward Capriolo added a comment -

        Add explain queries so we can be sure cross join is doing what it is intended to do.

        Show
        Edward Capriolo added a comment - Add explain queries so we can be sure cross join is doing what it is intended to do.
        Hide
        Edward Capriolo added a comment -

        Never mind the last comment. I missed the explain in the patch. +1.

        Show
        Edward Capriolo added a comment - Never mind the last comment. I missed the explain in the patch. +1.
        Hide
        Edward Capriolo added a comment -

        Fabricator patch.

        Show
        Edward Capriolo added a comment - Fabricator patch.
        Hide
        Edward Capriolo added a comment -

        Commit. Thank you Navis.

        Show
        Edward Capriolo added a comment - Commit. Thank you Navis.
        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-hadoop2 #54 (See https://builds.apache.org/job/Hive-trunk-hadoop2/54/)
        HIVE-2549 Support standard cross join syntax. Navis Ryu (via egc) (Revision 1357875)

        Result = ABORTED
        ecapriolo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1357875
        Files :

        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g
        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
        • /hive/trunk/ql/src/test/queries/clientpositive/cross_join.q
        • /hive/trunk/ql/src/test/results/clientpositive/cross_join.q.out
        Show
        Hudson added a comment - Integrated in Hive-trunk-hadoop2 #54 (See https://builds.apache.org/job/Hive-trunk-hadoop2/54/ ) HIVE-2549 Support standard cross join syntax. Navis Ryu (via egc) (Revision 1357875) Result = ABORTED ecapriolo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1357875 Files : /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java /hive/trunk/ql/src/test/queries/clientpositive/cross_join.q /hive/trunk/ql/src/test/results/clientpositive/cross_join.q.out
        Hide
        Ashutosh Chauhan added a comment -

        This issue is fixed and released as part of 0.10.0 release. If you find an issue which seems to be related to this one, please create a new jira and link this one with new jira.

        Show
        Ashutosh Chauhan added a comment - This issue is fixed and released as part of 0.10.0 release. If you find an issue which seems to be related to this one, please create a new jira and link this one with new jira.

          People

          • Assignee:
            Navis
            Reporter:
            David Phillips
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development