[HIVE-25390] Metrics compaction_failed_initiator_ratio and compaction_failed_cleaner_ratio should be counters

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 4.0.0-alpha-1
• Labels: backward-incompatible pull-request-available
• Assignee: Karen Coppage
• Reporter: Karen Coppage
• Created: 27/Jul/21 07:34
• Updated: 17/Nov/22 08:48
• Resolved: 28/Jul/21 09:16

Description

Metric compaction_failed_initiator_ratio represents the ratio of initiator failures to the total number of initiator runs, both computed since Metastore was restarted, represented by a double. This isn't really useable. It would be better if it counted the number of initiator failures since Metastore was restarted so other components can keep an eye on things like "number of initiator failures in the last day".

Same goes for compaction_failed_cleaner_ratio.

This commit removes metrics

• compaction_failed_initiator_ratio
• compaction_failed_cleaner_ratio

and introduces metrics

• compaction_initiator_failure_counter
• compaction_cleaner_failure_counter

Issue Links

• fixes: HIVE-25018 Create new metrics about Initiator / Cleaner failures
• links to: GitHub Pull Request #2534