Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-25046

Log CBO plans right after major transformations

Log workAgile BoardRank to TopRank to BottomBulk Copy AttachmentsBulk Move AttachmentsVotersWatch issueWatchersCreate sub-taskConvert to sub-taskMoveLinkCloneLabelsUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    Description

      Currently the results of various CBO transformations are logged (in DEBUG mode) at the end of the optimization phase and only if we are not in test mode. This has some disadvantages:

      • If there is a failure (exception) in some intermediate step we will miss all the intermediate plans, possibly losing track of what plan led to the problem.
      • Intermediate logs are very useful for identifying plan problems while working on a patch; unfortunately the logs are explicitly disabled in test mode which means that in order to appear the respective code needs to change every time we need to see those logs.
      • Logging at the end necessitates keeping additional local variables that make code harder to read.

      The goal of this issue is to place DEBUG logging right after major transformations and independently if we are running in test mode or not to alleviate the shortcomings mentioned above.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            zabetak Stamatis Zampetakis Assign to me
            zabetak Stamatis Zampetakis
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - Not Specified
              Not Specified
              Remaining:
              Remaining Estimate - 0h
              0h
              Logged:
              Time Spent - 1h
              1h

              Slack

                Issue deployment