Hive
  1. Hive
  2. HIVE-2487

Bug from HIVE-2446, the code that calls client stats publishers run() methods is in wrong place, should be in the same method but inside of while (!rj.isComplete()) {} loop

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.8.0
    • Component/s: None
    • Labels:
      None
    1. HIVE-2487.1.patch
      1 kB
      Robert Surówka
    2. HIVE-2487.1.patch
      2 kB
      Robert Surówka
    3. HIVE-2487.2.patch
      2 kB
      Robert Surówka

      Issue Links

        Activity

        Hide
        He Yongqiang added a comment -

        committed, thanks Robert!

        Show
        He Yongqiang added a comment - committed, thanks Robert!
        Hide
        Ning Zhang added a comment -

        Yongqiang, it seems you have committed this patch? Can you close this JIRA if so?

        Show
        Ning Zhang added a comment - Yongqiang, it seems you have committed this patch? Can you close this JIRA if so?
        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-h0.21 #1019 (See https://builds.apache.org/job/Hive-trunk-h0.21/1019/)
        HIVE-2487: Bug from HIVE-2446, the code that calls client stats publishers should be inside the while loop (Robert Surówka via He Yongqiang)

        heyongqiang : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1185767
        Files :

        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/HadoopJobExecHelper.java
        Show
        Hudson added a comment - Integrated in Hive-trunk-h0.21 #1019 (See https://builds.apache.org/job/Hive-trunk-h0.21/1019/ ) HIVE-2487 : Bug from HIVE-2446 , the code that calls client stats publishers should be inside the while loop (Robert Surówka via He Yongqiang) heyongqiang : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1185767 Files : /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/HadoopJobExecHelper.java
        Hide
        He Yongqiang added a comment -

        +1, will commit after tests pass

        Show
        He Yongqiang added a comment - +1, will commit after tests pass
        Hide
        Robert Surówka added a comment -

        See updated diff request at https://reviews.apache.org/r/2234/diff/2/ (added runtime exception handling)

        Show
        Robert Surówka added a comment - See updated diff request at https://reviews.apache.org/r/2234/diff/2/ (added runtime exception handling)
        Hide
        Robert Surówka added a comment -
        Show
        Robert Surówka added a comment - Diff request at https://reviews.apache.org/r/2234/diff/#index_header
        Hide
        Robert Surówka added a comment -

        current version (previous was diffed from not most up to date branch)

        Show
        Robert Surówka added a comment - current version (previous was diffed from not most up to date branch)

          People

          • Assignee:
            Robert Surówka
            Reporter:
            Robert Surówka
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development