[HIVE-24782] Fix in HIVE-22889 introduced NPE when using non-WebHCat HCat components

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Component/s: HCatalog
• Labels: pull-request-available
• Assignee: Jason Phelps
• Reporter: Jason Phelps
• Created: 16/Feb/21 00:26
• Updated: 21/Dec/23 19:55
• Resolved: 26/Feb/21 06:31

Description

In HIVE-22889, it introduced the following lines:

    // remove the leading and trailing quotes. hcatalog can miss on some cases.
    if (execString.length() > 1 && execString.startsWith("\"") && execString.endsWith("\"")) {
      execString = execString.substring(1, execString.length() - 1);
    }

When calling Sqoop HCat jobs, or the HCat CLI, it will throw an NPE because execString is null but not wrapped in the handy Null check that is nearby

    if (execString != null) {

Issue Links

• is caused by: HIVE-22889 Trim trailing and leading quotes for HCatCli query processing
• is duplicated by: HIVE-23156 NPE if -f is used with HCatCLI
• links to: GitHub Pull Request #1989