[HIVE-24772] Revamp Server Request Error Logging

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 4.0.0-alpha-1
• Labels: pull-request-available
• Target Version/s: 4.0.0
• Assignee: David Mollitor
• Reporter: David Mollitor
• Created: 12/Feb/21 19:33
• Updated: 17/Nov/22 08:48
• Resolved: 23/Apr/21 16:45

Description

Most of the action takes place in ThriftCLIService where errors are logged in response to client requests (though I know in many instances things are logged multiple times).

I propose to improve this on multiple fronts:

1. Many log messages have the word "Error" in it, but log at the WARN level. I have changed all relevant logging to be at ERROR level and removed the word "Error" from the message
2. Some of the error message in the logging code had copy & paste errors where they printed the wrong request name
3. Print the actual request object in the error message
4. Big one for me: Do not pass a stack trace to the client. This is bad practice from a security perspective,... clients should not know that level of detail of the server, and also it's very confusing for the client perspective to understand that the stack trace is actually from the remote server, not the local client, and finally, it's too messy for a typical user to deal with anyway. Stack trace should be presented in the HS2 logs only.
5. Various clean up
6. Log an IP address for the client as part of standard operating procedure

Issue Links

• is related to: HIVE-25844 Exception deserialization error-s may cause beeline to terminate immediately
• links to: GitHub Pull Request #1974