Hive
  1. Hive
  2. HIVE-2462

make INNER a non-reserved keyword

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.8.0
    • Component/s: None
    • Labels:
      None

      Description

      HIVE-2191 introduced the INNER keyword as reserved, which breaks backwards compatibility for queries which were using it as an identifier. This patch addresses that.

        Issue Links

          Activity

          Hide
          Hudson added a comment -

          Integrated in Hive-trunk-h0.21 #972 (See https://builds.apache.org/job/Hive-trunk-h0.21/972/)
          HIVE-2462:make INNER a non-reserved keyword (John Sichi via He Yongqiang)

          heyongqiang : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1174531
          Files :

          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g
          • /hive/trunk/ql/src/test/queries/clientpositive/innerjoin.q
          • /hive/trunk/ql/src/test/results/clientpositive/innerjoin.q.out
          Show
          Hudson added a comment - Integrated in Hive-trunk-h0.21 #972 (See https://builds.apache.org/job/Hive-trunk-h0.21/972/ ) HIVE-2462 :make INNER a non-reserved keyword (John Sichi via He Yongqiang) heyongqiang : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1174531 Files : /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g /hive/trunk/ql/src/test/queries/clientpositive/innerjoin.q /hive/trunk/ql/src/test/results/clientpositive/innerjoin.q.out
          Hide
          He Yongqiang added a comment -

          committed, thanks John!

          Show
          He Yongqiang added a comment - committed, thanks John!
          Hide
          He Yongqiang added a comment -

          The patch looks good, we should have it. running test

          Show
          He Yongqiang added a comment - The patch looks good, we should have it. running test
          Hide
          John Sichi added a comment -

          Not sure whether we want/need this, but if so, here's the patch.

          Show
          John Sichi added a comment - Not sure whether we want/need this, but if so, here's the patch.
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/2024/
          -----------------------------------------------------------

          Review request for hive.

          Summary
          -------

          HIVE-2462

          This addresses bug HIVE-2462.
          https://issues.apache.org/jira/browse/HIVE-2462

          Diffs


          http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 1174316
          http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/innerjoin.q 1174316
          http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/innerjoin.q.out 1174316

          Diff: https://reviews.apache.org/r/2024/diff

          Testing
          -------

          Thanks,

          John

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2024/ ----------------------------------------------------------- Review request for hive. Summary ------- HIVE-2462 This addresses bug HIVE-2462 . https://issues.apache.org/jira/browse/HIVE-2462 Diffs http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 1174316 http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/innerjoin.q 1174316 http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/innerjoin.q.out 1174316 Diff: https://reviews.apache.org/r/2024/diff Testing ------- Thanks, John

            People

            • Assignee:
              John Sichi
              Reporter:
              John Sichi
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development