[HIVE-23979] Resolve spotbugs errors in JsonReporter.java, Metrics.java, and PerfLogger.java

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 4.0.0-alpha-1
• Labels: pull-request-available
• Assignee: Soumyakanti Das
• Reporter: Soumyakanti Das
• Created: 03/Aug/20 15:43
• Updated: 27/Feb/24 22:24
• Resolved: 15/Aug/20 21:46

Description

Resolve these spotbugs errors:
[ERROR] Found reliance on default encoding in org.apache.hadoop.hive.metastore.metrics.JsonReporter.report(SortedMap, SortedMap, SortedMap, SortedMap, SortedMap): new java.io.FileWriter(File) [org.apache.hadoop.hive.metastore.metrics.JsonReporter] At JsonReporter.java:[line 159] DM_DEFAULT_ENCODING

[ERROR] Incorrect lazy initialization of static field org.apache.hadoop.hive.metastore.metrics.Metrics.self in org.apache.hadoop.hive.metastore.metrics.Metrics.shutdown() [org.apache.hadoop.hive.metastore.metrics.Metrics] At Metrics.java:[lines 79-85] LI_LAZY_INIT_STATIC

[ERROR] The method name org.apache.hadoop.hive.metastore.metrics.PerfLogger.PerfLogBegin(String, String) doesn't start with a lower case letter [org.apache.hadoop.hive.metastore.metrics.PerfLogger] At PerfLogger.java:[lines 92-98] NM_METHOD_NAMING_CONVENTION

[ERROR] The method name org.apache.hadoop.hive.metastore.metrics.PerfLogger.PerfLogEnd(String, String) doesn't start with a lower case letter [org.apache.hadoop.hive.metastore.metrics.PerfLogger] At PerfLogger.java:[line 106] NM_METHOD_NAMING_CONVENTION

[ERROR] The method name org.apache.hadoop.hive.metastore.metrics.PerfLogger.PerfLogEnd(String, String, String) doesn't start with a lower case letter [org.apache.hadoop.hive.metastore.metrics.PerfLogger] At PerfLogger.java:[lines 116-138] NM_METHOD_NAMING_CONVENTION

Issue Links

• is related to: HIVE-23823 Fix violated naming conventions
• Parent Feature: HIVE-23949 Introduce caching layer in HS2 to accelerate query compilation
• links to: GitHub Pull Request #1404