[HIVE-23704] Thrift HTTP Server Does Not Handle Auth Handle Correctly

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.3.7, 3.1.2
• Fix Version/s: 4.0.0-alpha-1
• Component/s: Security
• Labels: pull-request-available
• Assignee: David Mollitor Assign to me
• Reporter: David Mollitor
• Created: 16/Jun/20 16:12
• Updated: 17/Nov/22 08:48
• Resolved: 21/Jun/20 16:30

Description

ThriftHttpServlet.java

  private String[] getAuthHeaderTokens(HttpServletRequest request,
      String authType) throws HttpAuthenticationException {
    String authHeaderBase64 = getAuthHeader(request, authType);
    String authHeaderString = StringUtils.newStringUtf8(
        Base64.decodeBase64(authHeaderBase64.getBytes()));
    String[] creds = authHeaderString.split(":");
    return creds;
  }

So here, it takes the authHeaderBase64 (which is a base-64 string), and converts it into bytes, and then it tries to decode those bytes. That is incorrect It should covert base-64 string directly into bytes.

I tried to do this as part of HIVE-22676 and the tests was failing because the string that is being decoded is not actually Base-64 (see attached image) It has a stray space and a colon. Again, the existing code doesn't care because it's not parsing Base-64 text, it is parsing the bytes generated by converting base-64 text to bytes.

I'm not sure what affect this has, what security issues this may present, but it's definitely not correct.

Issue Links

• blocks: HIVE-22676 Replace Base64 in hive-service Package
• links to: GitHub Pull Request #1127