[HIVE-23592] Routine "makeIntPair" is Not Correct

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.2.0
• Fix Version/s: 4.0.0-alpha-1
• Component/s: llap
• Labels: pull-request-available
• Target Version/s: 4.0.0
• Assignee: David Mollitor
• Reporter: David Mollitor
• Created: 02/Jun/20 13:42
• Updated: 17/Nov/22 08:48
• Resolved: 16/Jun/20 13:24

Description

BuddyAllocator.java

  // Utility methods used to store pairs of ints as long.
  private static long makeIntPair(int first, int second) {
    return ((long)first) << 32 | second;
  }
  private static int getFirstInt(long result) {
    return (int) (result >>> 32);
  }
  private static int getSecondInt(long result) {
    return (int) (result & ((1L << 32) - 1));
  }

    long result = LLAP.makeIntPair(Integer.MIN_VALUE, Integer.MIN_VALUE);
    if (LLAP.getFirstInt(result) != Integer.MIN_VALUE) {
       throw new Exception();
    }
    if (LLAP.getSecondInt(result) != Integer.MIN_VALUE) {
      throw new Exception();
   }
/*
 * Exception in thread "main" java.lang.Exception
 * 	at org.test.TestMe.main(TestMe.java:19)
 */

https://github.com/apache/hive/blob/4b670877c280b37c5776046f66d766079489b2a8/llap-server/src/java/org/apache/hadoop/hive/llap/cache/BuddyAllocator.java#L1677

Issue Links

• links to: GitHub Pull Request #1052