Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-23533

Remove an FS#exists call from AcidUtils#getLogicalLength

Log workAgile BoardRank to TopRank to BottomBulk Copy AttachmentsBulk Move AttachmentsVotersWatch issueWatchersCreate sub-taskConvert to sub-taskMoveLinkCloneLabelsUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 4.0.0-alpha-1
    • None
    • None

    Description

       Path lengths = OrcAcidUtils.getSideFile(file.getPath());
          if(!fs.exists(lengths)) {
      ...
            return file.getLen();
          }
          long len = OrcAcidUtils.getLastFlushLength(fs, file.getPath());
      

      OrcAcidUtils.getLastFlushLength also has an exists() check and returns Long.MAX_VALUE if false.
      exists() is expensive on S3.

      Attachments

        1. HIVE-23533.02.patch
          3 kB
          Karen Coppage
        2. HIVE-23533.01.patch
          2 kB
          Karen Coppage
        3. HIVE-23533.01.patch
          2 kB
          Karen Coppage
        4. HIVE-23533.01.patch
          2 kB
          Karen Coppage

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            klcopp Karen Coppage Assign to me
            klcopp Karen Coppage
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment