[HIVE-23098] Allow Operation assertState to Accept a Collection

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 4.0.0-alpha-1
• Target Version/s: 4.0.0
• Assignee: David Mollitor
• Reporter: David Mollitor
• Created: 27/Mar/20 19:04
• Updated: 17/Nov/22 08:49
• Resolved: 15/Apr/20 00:44

Description

Operation.java

  protected final void assertState(List<OperationState> states) throws HiveSQLException {
    if (!states.contains(state)) {
      throw new HiveSQLException("Expected states: " + states.toString() + ", but found "
          + this.state);
    }
    this.lastAccessTime = System.currentTimeMillis();
  }
/*********************/
public void someMethod() {
    assertState(new ArrayList<OperationState>(Arrays.asList(OperationState.FINISHED)));
}

By allowing assertState to accept a Collection, one can save an allocation and simplify the code:

    assertState(Collections.singleton(OperationState.FINISHED));

Issue Links

• relates to: HIVE-23099 Improve Logger for Operation Child Classes