[HIVE-23051] Clean up BucketCodec

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 4.0.0-alpha-1
• Target Version/s: 4.0.0
• Assignee: David Mollitor
• Reporter: David Mollitor
• Created: 18/Mar/20 22:17
• Updated: 17/Nov/22 08:51
• Resolved: 18/Apr/20 18:16

Description

A couple of nagging things caught my eye with this class. The first thing:

BucketCodec.java

      int statementId = options.getStatementId() >= 0 ? options.getStatementId() : 0;

      assert this.version >=0 && this.version <= MAX_VERSION
        : "Version out of range: " + version;
      if(!(options.getBucketId() >= 0 && options.getBucketId() <= MAX_BUCKET_ID)) {
        throw new IllegalArgumentException("bucketId out of range: " + options.getBucketId());
      }
      if(!(statementId >= 0 && statementId <= MAX_STATEMENT_ID)) {
        throw new IllegalArgumentException("statementId out of range: " + statementId);
      }

statementId gets capped, if it's less than 0, then it gets rounded up to 0. However, it later checks that the statementId is greater,... which is will always be 'true' since it's getting rounded.

1. Remove the rounding behavior.
2. Make better error message
3. Fail-fast in the constructor if the version is invalid