[HIVE-22981] DataFileReader is not closed in AvroGenericRecordReader#extractWriterTimezoneFromMetadata

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.1.3, 3.2.0, 4.0.0-alpha-1
• Labels: pull-request-available
• Assignee: Karen Coppage
• Reporter: Karen Coppage
• Created: 05/Mar/20 11:45
• Updated: 21/Oct/22 06:56
• Resolved: 06/Mar/20 10:44

Description

Method looks like :

 private ZoneId extractWriterTimezoneFromMetadata(JobConf job, FileSplit split,
      GenericDatumReader<GenericRecord> gdr) throws IOException {
    if (job == null || gdr == null || split == null || split.getPath() == null) {
      return null;
    }
    try {
      DataFileReader<GenericRecord> dataFileReader =
          new DataFileReader<GenericRecord>(new FsInput(split.getPath(), job), gdr);
      [...return...]
      }
    } catch (IOException e) {
      // Can't access metadata, carry on.
    }
    return null;
  }

The DataFileReader is never closed which can cause a memory leak. We need a try-with-resources here.

Issue Links

• links to: GitHub Pull Request #1686