Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-22929

Performance: quoted identifier parsing uses throwaway Regex via String.replaceAll()

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 4.0.0-alpha-1
    • None
    • None

    Description

      https://github.com/apache/hive/blob/master/parser/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g#L530

          '`'  ( '``' | ~('`') )* '`' { setText(getText().substring(1, getText().length() -1 ).replaceAll("``", "`")); }

      Attachments

        1. HIVE-22929.1.patch
          40 kB
          Krisztian Kasa
        2. HIVE-22929.2.patch
          0.8 kB
          Krisztian Kasa
        3. HIVE-22929.2.patch
          0.8 kB
          Krisztian Kasa
        4. HIVE-22929.2.patch
          0.8 kB
          Krisztian Kasa
        5. HIVE-22929.2.patch
          0.8 kB
          Krisztian Kasa
        6. String.replaceAll.png
          82 kB
          Gopal Vijayaraghavan

        Issue Links

          links to

          Web Link Review Board

          Activity

            People

              kkasa Krisztian Kasa
              gopalv Gopal Vijayaraghavan
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: