Hive
  1. Hive
  2. HIVE-2288

Adding the oracle nvl function to the UDF

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.9.0
    • Fix Version/s: 0.11.0
    • Component/s: UDF
    • Labels:
    • Tags:
      UDF NVL

      Description

      It would be nice if we could use the nvl function, described at oracle:
      http://www.techonthenet.com/oracle/functions/nvl.php

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-hadoop2 #54 (See https://builds.apache.org/job/Hive-trunk-hadoop2/54/)
        HIVE-2288 : Adding the oracle nvl function to the UDF (Ed Capriolo, Guy Doulberg via Ashutosh Chauhan) (Revision 1419204)

        Result = ABORTED
        hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1419204
        Files :

        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java
        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFNvl.java
        • /hive/trunk/ql/src/test/queries/clientpositive/udf_nvl.q
        • /hive/trunk/ql/src/test/results/clientpositive/show_functions.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/udf_nvl.q.out
        Show
        Hudson added a comment - Integrated in Hive-trunk-hadoop2 #54 (See https://builds.apache.org/job/Hive-trunk-hadoop2/54/ ) HIVE-2288 : Adding the oracle nvl function to the UDF (Ed Capriolo, Guy Doulberg via Ashutosh Chauhan) (Revision 1419204) Result = ABORTED hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1419204 Files : /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFNvl.java /hive/trunk/ql/src/test/queries/clientpositive/udf_nvl.q /hive/trunk/ql/src/test/results/clientpositive/show_functions.q.out /hive/trunk/ql/src/test/results/clientpositive/udf_nvl.q.out
        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-h0.21 #1848 (See https://builds.apache.org/job/Hive-trunk-h0.21/1848/)
        HIVE-2288 : Adding the oracle nvl function to the UDF (Ed Capriolo, Guy Doulberg via Ashutosh Chauhan) (Revision 1419204)

        Result = FAILURE
        hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1419204
        Files :

        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java
        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFNvl.java
        • /hive/trunk/ql/src/test/queries/clientpositive/udf_nvl.q
        • /hive/trunk/ql/src/test/results/clientpositive/show_functions.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/udf_nvl.q.out
        Show
        Hudson added a comment - Integrated in Hive-trunk-h0.21 #1848 (See https://builds.apache.org/job/Hive-trunk-h0.21/1848/ ) HIVE-2288 : Adding the oracle nvl function to the UDF (Ed Capriolo, Guy Doulberg via Ashutosh Chauhan) (Revision 1419204) Result = FAILURE hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1419204 Files : /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFNvl.java /hive/trunk/ql/src/test/queries/clientpositive/udf_nvl.q /hive/trunk/ql/src/test/results/clientpositive/show_functions.q.out /hive/trunk/ql/src/test/results/clientpositive/udf_nvl.q.out
        Hide
        Ashutosh Chauhan added a comment -

        Committed to trunk. Thanks, Ed and Guy!

        Show
        Ashutosh Chauhan added a comment - Committed to trunk. Thanks, Ed and Guy!
        Hide
        Ashutosh Chauhan added a comment -

        +1 will commit if tests pass.

        Show
        Ashutosh Chauhan added a comment - +1 will commit if tests pass.
        Hide
        Edward Capriolo added a comment -

        Namit, I added the test cases and related changed. Is there anyreason you reverted this back to OPEN? In my eyes it is read for review.

        Show
        Edward Capriolo added a comment - Namit, I added the test cases and related changed. Is there anyreason you reverted this back to OPEN? In my eyes it is read for review.
        Hide
        Edward Capriolo added a comment -

        You need to include test cases will a patch. Are you still looking to work on this?

        Show
        Edward Capriolo added a comment - You need to include test cases will a patch. Are you still looking to work on this?
        Hide
        Guy Doulberg added a comment -

        I created a it myself...
        Attached a patch

        Show
        Guy Doulberg added a comment - I created a it myself... Attached a patch

          People

          • Assignee:
            Edward Capriolo
            Reporter:
            Guy Doulberg
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development