Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.8.0
    • Component/s: CLI
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      If you specify something like:

      – This is a comment
      add jar jar_path;
      select * from my_table;

      This fails.

      I have created a fix to skip the commented lines.

      1. HIVE-2259.patch
        0.6 kB
        Vaibhav Aggarwal

        Activity

        Hide
        Carl Steinbach added a comment -

        +1. Will commit if tests pass.

        Show
        Carl Steinbach added a comment - +1. Will commit if tests pass.
        Hide
        Carl Steinbach added a comment -

        Committed to trunk. Thanks Vaibhav!

        Show
        Carl Steinbach added a comment - Committed to trunk. Thanks Vaibhav!
        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-h0.21 #828 (See https://builds.apache.org/job/Hive-trunk-h0.21/828/)
        HIVE-2259. Skip comments in hive script (Vaibhav Aggarwal via cws)

        cws : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1146960
        Files :

        • /hive/trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java
        Show
        Hudson added a comment - Integrated in Hive-trunk-h0.21 #828 (See https://builds.apache.org/job/Hive-trunk-h0.21/828/ ) HIVE-2259 . Skip comments in hive script (Vaibhav Aggarwal via cws) cws : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1146960 Files : /hive/trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java
        Hide
        Ido Hadanny added a comment -

        Hey, what about /* style comments?
        this also fails: /pretty comment/drop table BABA;
        with this error message: Query returned non-zero code: 11, cause: FAILED: Parse Error: line 1:0 cannot recognize input '/'

        Show
        Ido Hadanny added a comment - Hey, what about /* style comments? this also fails: / pretty comment /drop table BABA; with this error message: Query returned non-zero code: 11, cause: FAILED: Parse Error: line 1:0 cannot recognize input '/'
        Hide
        Ido Hadanny added a comment -

        oops, wiki-markup-fail. meant:
        this also fails: / * pretty comment * /drop table BABA;

        Show
        Ido Hadanny added a comment - oops, wiki-markup-fail. meant: this also fails: / * pretty comment * /drop table BABA;

          People

          • Assignee:
            Vaibhav Aggarwal
            Reporter:
            Vaibhav Aggarwal
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development