[HIVE-22375] ObjectStore.lockNotificationSequenceForUpdate is leaking query in case of error

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 4.0.0
• Fix Version/s: 4.0.0-alpha-1
• Component/s: Standalone Metastore
• Assignee: Marta Kuczora Assign to me
• Reporter: Marta Kuczora
• Created: 21/Oct/19 08:10
• Updated: 17/Nov/22 08:51
• Resolved: 22/Oct/19 08:58

Description

In the ObjectStore.lockNotificationSequenceForUpdate method, the query doesn't get closed if an error occur:

  private void lockNotificationSequenceForUpdate() throws MetaException {
    if (sqlGenerator.getDbProduct() == DatabaseProduct.DERBY && directSql != null) {
      // Derby doesn't allow FOR UPDATE to lock the row being selected (See https://db.apache
      // .org/derby/docs/10.1/ref/rrefsqlj31783.html) . So lock the whole table. Since there's
      // only one row in the table, this shouldn't cause any performance degradation.
      new RetryingExecutor(conf, () -> {
        directSql.lockDbTable("NOTIFICATION_SEQUENCE");
      }).run();
    } else {
      String selectQuery = "select \"NEXT_EVENT_ID\" from \"NOTIFICATION_SEQUENCE\"";
      String lockingQuery = sqlGenerator.addForUpdateClause(selectQuery);
      new RetryingExecutor(conf, () -> {
        prepareQuotes();
        Query query = pm.newQuery("javax.jdo.query.SQL", lockingQuery);
        query.setUnique(true);
        // only need to execute it to get db Lock
        query.execute();
        query.closeAll();
      }).run();
    }
  }