Details
-
Improvement
-
Status: Closed
-
Major
-
Resolution: Fixed
-
None
Description
UDF that converts a date/timestamp to new proleptic Gregorian calendar (ISO 8601 standard), which is produced by extending the Gregorian calendar backward to dates preceding its official introduction in 1582, assuming that its internal days/milliseconds since epoch is calculated using legacy Gregorian-Julian hybrid calendar, i.e., calendar that supports both the Julian and Gregorian calendar systems with the support of a single discontinuity, which corresponds by default to the Gregorian date when the Gregorian calendar was instituted.
Attachments
Attachments
- HIVE-22241.patch
- 14 kB
- jcamachorodriguez
- HIVE-22241.01.patch
- 15 kB
- jcamachorodriguez
- HIVE-22241.02.patch
- 17 kB
- jcamachorodriguez
- HIVE-22241.02.patch
- 17 kB
- jcamachorodriguez
Issue Links
- links to
Activity
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12981268/HIVE-22241.patch
SUCCESS: +1 due to 2 test(s) being added or modified.
ERROR: -1 due to 1 failed/errored test(s), 17010 tests executed
Failed tests:
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[show_functions] (batchId=81)
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/18717/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/18717/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-18717/
Messages:
Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 1 tests failed
This message is automatically generated.
ATTACHMENT ID: 12981268 - PreCommit-HIVE-Build
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
Prechecks | |||
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
master Compile Tests | |||
+1 | mvninstall | 8m 56s | master passed |
+1 | compile | 1m 8s | master passed |
+1 | checkstyle | 0m 40s | master passed |
0 | findbugs | 4m 18s | ql in master has 1567 extant Findbugs warnings. |
+1 | javadoc | 0m 58s | master passed |
Patch Compile Tests | |||
+1 | mvninstall | 1m 28s | the patch passed |
+1 | compile | 1m 9s | the patch passed |
+1 | javac | 1m 9s | the patch passed |
-1 | checkstyle | 0m 41s | ql: The patch generated 35 new + 83 unchanged - 0 fixed = 118 total (was 83) |
+1 | whitespace | 0m 0s | The patch has no whitespace issues. |
+1 | findbugs | 4m 24s | the patch passed |
+1 | javadoc | 1m 2s | the patch passed |
Other Tests | |||
+1 | asflicense | 0m 15s | The patch does not generate ASF License warnings. |
25m 27s |
Subsystem | Report/Notes |
---|---|
Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
Build tool | maven |
Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-18729/dev-support/hive-personality.sh |
git revision | master / d6668c7 |
Default Java | 1.8.0_111 |
findbugs | v3.0.1 |
checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-18729/yetus/diff-checkstyle-ql.txt |
modules | C: ql U: ql |
Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-18729/yetus.txt |
Powered by | Apache Yetus http://yetus.apache.org |
This message was automatically generated.
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12981346/HIVE-22241.01.patch
SUCCESS: +1 due to 2 test(s) being added or modified.
SUCCESS: +1 due to 17010 tests passed
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/18729/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/18729/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-18729/
Messages:
Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase
This message is automatically generated.
ATTACHMENT ID: 12981346 - PreCommit-HIVE-Build
jcamachorodriguez I think this change is doing something the other way around.
For example
select to_proleptic_gregorian(CAST('1582-10-02' AS DATE));
gives 1582-09-22. Which would mean that 1582-10-02 being a Julian date which it is, corresponds to an earlier date in proleptic Gregorian, where in reality it should be later one: 1582-10-12.
AFAIK 1582-10-04 was the last Julian date, a day followed by 1582-10-15 and this latter is already a (true) Gregorian calendar day. So 1582-10-02 interpreted as Julian date, should be 3 days before 1582-10-15 (true) Gregorian, making it a 1582-10-12 proleptic Gregorian date.
szita, I have updated the patch after our conversation offline. I changed the names and descriptions (in the JIRA and UDF) to make clearer the intent of the new UDF. I also added new test cases. Can you take a look again? Thanks
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
Prechecks | |||
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
master Compile Tests | |||
+1 | mvninstall | 9m 15s | master passed |
+1 | compile | 1m 9s | master passed |
+1 | checkstyle | 0m 42s | master passed |
0 | findbugs | 4m 15s | ql in master has 1566 extant Findbugs warnings. |
+1 | javadoc | 1m 2s | master passed |
Patch Compile Tests | |||
+1 | mvninstall | 1m 32s | the patch passed |
+1 | compile | 1m 8s | the patch passed |
+1 | javac | 1m 8s | the patch passed |
-1 | checkstyle | 0m 41s | ql: The patch generated 38 new + 83 unchanged - 0 fixed = 121 total (was 83) |
+1 | whitespace | 0m 0s | The patch has no whitespace issues. |
+1 | findbugs | 4m 22s | the patch passed |
+1 | javadoc | 0m 58s | the patch passed |
Other Tests | |||
+1 | asflicense | 0m 14s | The patch does not generate ASF License warnings. |
25m 40s |
Subsystem | Report/Notes |
---|---|
Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
Build tool | maven |
Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-18758/dev-support/hive-personality.sh |
git revision | master / 6ca8397 |
Default Java | 1.8.0_111 |
findbugs | v3.0.1 |
checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-18758/yetus/diff-checkstyle-ql.txt |
modules | C: ql U: ql |
Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-18758/yetus.txt |
Powered by | Apache Yetus http://yetus.apache.org |
This message was automatically generated.
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12981495/HIVE-22241.02.patch
SUCCESS: +1 due to 2 test(s) being added or modified.
ERROR: -1 due to 2 failed/errored test(s), 17012 tests executed
Failed tests:
org.apache.hadoop.hive.llap.cache.TestBuddyAllocator.testMTT[2] (batchId=363) org.apache.hadoop.hive.metastore.TestGetPartitionsUsingProjectionAndFilterSpecs.testGetPartitionsUsingValues (batchId=225)
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/18758/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/18758/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-18758/
Messages:
Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 2 tests failed
This message is automatically generated.
ATTACHMENT ID: 12981495 - PreCommit-HIVE-Build
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
Prechecks | |||
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
master Compile Tests | |||
+1 | mvninstall | 9m 3s | master passed |
+1 | compile | 1m 4s | master passed |
+1 | checkstyle | 0m 41s | master passed |
0 | findbugs | 4m 3s | ql in master has 1566 extant Findbugs warnings. |
+1 | javadoc | 0m 59s | master passed |
Patch Compile Tests | |||
+1 | mvninstall | 1m 23s | the patch passed |
+1 | compile | 1m 7s | the patch passed |
+1 | javac | 1m 7s | the patch passed |
-1 | checkstyle | 0m 41s | ql: The patch generated 38 new + 83 unchanged - 0 fixed = 121 total (was 83) |
+1 | whitespace | 0m 0s | The patch has no whitespace issues. |
+1 | findbugs | 4m 24s | the patch passed |
+1 | javadoc | 1m 1s | the patch passed |
Other Tests | |||
+1 | asflicense | 0m 14s | The patch does not generate ASF License warnings. |
25m 5s |
Subsystem | Report/Notes |
---|---|
Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
Build tool | maven |
Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-18764/dev-support/hive-personality.sh |
git revision | master / b53521a |
Default Java | 1.8.0_111 |
findbugs | v3.0.1 |
checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-18764/yetus/diff-checkstyle-ql.txt |
modules | C: ql U: ql |
Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-18764/yetus.txt |
Powered by | Apache Yetus http://yetus.apache.org |
This message was automatically generated.
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12981577/HIVE-22241.02.patch
SUCCESS: +1 due to 2 test(s) being added or modified.
SUCCESS: +1 due to 17013 tests passed
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/18764/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/18764/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-18764/
Messages:
Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase
This message is automatically generated.
ATTACHMENT ID: 12981577 - PreCommit-HIVE-Build
This message was automatically generated.