[HIVE-22033] HiveServer2: fix delegation token renewal

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.3.5
• Fix Version/s: 3.2.0, 4.0.0-alpha-1
• Labels: pull-request-available
• Assignee: Ion Alberdi
• Reporter: Ion Alberdi
• Created: 23/Jul/19 14:29
• Updated: 10/Apr/23 04:02
• Resolved: 09/Mar/20 10:29

Description

Hello, the issue we faced (and a proposal for a fix) in our hive instances is depicted at
https://github.com/criteo-forks/hive/pull/24

Reading the master branch of the project
https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/security/TokenStoreDelegationTokenSecretManager.java#L147
I think the same behavior is replicated there.

Long story short, TokenStoreDelegationTokenSecretManager.renewToken, does not update the expiry date of a given token (as it does not get the updated DelegationTokenInformation from super.currentTokens).

This makes any call to renewToken ineffective (the expiry date of the token is not postponed).

Issue Links

• is a parent of: HIVE-26522 Test for HIVE-22033 and backport to 3.1 and 2.3
• relates to: HIVE-12270 Add DBTokenStore support to HS2 delegation token
• links to: GitHub Pull Request #3587