Hive
  1. Hive
  2. HIVE-2196

Ensure HiveConf includes all properties defined in hive-default.xml

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 0.8.0
    • Component/s: Configuration
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      There are a bunch of properties that are defined in hive-default.xml but not in HiveConf.

      1. HIVE-2196.6.patch
        13 kB
        Chinna Rao Lalam
      2. HIVE-2196.5.patch
        18 kB
        Chinna Rao Lalam
      3. HIVE-2196.4.patch
        18 kB
        Chinna Rao Lalam
      4. HIVE-2196.3.patch
        17 kB
        Chinna Rao Lalam
      5. HIVE-2196.build.log
        1.25 MB
        Carl Steinbach
      6. HIVE-2196.2.patch
        13 kB
        Chinna Rao Lalam
      7. HIVE-2196.1.patch
        13 kB
        Chinna Rao Lalam
      8. HIVE-2196.patch
        4 kB
        Chinna Rao Lalam

        Issue Links

          Activity

          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Patch Available Patch Available Open Open
          50d 1h 10m 7 Namit Jain 07/Nov/11 04:25
          Open Open Patch Available Patch Available
          106d 22h 24m 8 Chinna Rao Lalam 08/Nov/11 07:07
          Patch Available Patch Available Resolved Resolved
          7d 10h 51m 1 Namit Jain 15/Nov/11 17:59
          Resolved Resolved Closed Closed
          31d 5h 56m 1 Carl Steinbach 16/Dec/11 23:55
          Sumit Kumar made changes -
          Link This issue relates to HIVE-6037 [ HIVE-6037 ]
          Carl Steinbach made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Carl Steinbach made changes -
          Fix Version/s 0.9.0 [ 12317742 ]
          Carl Steinbach made changes -
          Fix Version/s 0.8.0 [ 12316178 ]
          Carl Steinbach made changes -
          Fix Version/s 0.9.0 [ 12317742 ]
          Carl Steinbach made changes -
          Link This issue relates to HIVE-2596 [ HIVE-2596 ]
          Namit Jain made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags Reviewed [ 10343 ]
          Resolution Fixed [ 1 ]
          Hide
          Namit Jain added a comment -

          Committed. Thanks Chinna

          Show
          Namit Jain added a comment - Committed. Thanks Chinna
          Hide
          Hudson added a comment -

          Integrated in Hive-trunk-h0.21 #1085 (See https://builds.apache.org/job/Hive-trunk-h0.21/1085/)
          HIVE-2196 Ensure HiveConf includes all properties defined in
          hive-default.xml (Chinna Rao Lalam via namit)

          namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1201872
          Files :

          • /hive/trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
          • /hive/trunk/conf/hive-default.xml
          • /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
          Show
          Hudson added a comment - Integrated in Hive-trunk-h0.21 #1085 (See https://builds.apache.org/job/Hive-trunk-h0.21/1085/ ) HIVE-2196 Ensure HiveConf includes all properties defined in hive-default.xml (Chinna Rao Lalam via namit) namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1201872 Files : /hive/trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java /hive/trunk/conf/hive-default.xml /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/1423/
          -----------------------------------------------------------

          (Updated 2011-11-08 07:07:28.602261)

          Review request for hive, Carl Steinbach and John Sichi.

          Changes
          -------

          refreshed the patch

          Summary
          -------

          The below configurations are not used in the code base so removed from the hive-default.xml

          hive.mapjoin.hashtable.initialCapacity
          hive.mapjoin.hashtable.loadfactor
          hive.mapjoin.smalltable.filesize
          hive.optimize.pruner
          hive.stats.jdbc.atomic
          hive.concurrency.manager

          The below configurations are not used in the code base but these configurations are required for the system so need to maintain in the hive-default.xml and no need to add in the HiveConf.java

          javax.jdo.option.ConnectionDriverName
          javax.jdo.PersistenceManagerFactoryClass
          javax.jdo.option.DetachAllOnCommit
          javax.jdo.option.NonTransactionalRead
          javax.jdo.option.ConnectionUserName
          fs.har.impl

          This addresses bug HIVE-2196.
          https://issues.apache.org/jira/browse/HIVE-2196

          Diffs (updated)


          trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1198626
          trunk/conf/hive-default.xml 1198626
          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1198626

          Diff: https://reviews.apache.org/r/1423/diff

          Testing
          -------

          All unit tests passed

          Thanks,

          chinna

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1423/ ----------------------------------------------------------- (Updated 2011-11-08 07:07:28.602261) Review request for hive, Carl Steinbach and John Sichi. Changes ------- refreshed the patch Summary ------- The below configurations are not used in the code base so removed from the hive-default.xml hive.mapjoin.hashtable.initialCapacity hive.mapjoin.hashtable.loadfactor hive.mapjoin.smalltable.filesize hive.optimize.pruner hive.stats.jdbc.atomic hive.concurrency.manager The below configurations are not used in the code base but these configurations are required for the system so need to maintain in the hive-default.xml and no need to add in the HiveConf.java javax.jdo.option.ConnectionDriverName javax.jdo.PersistenceManagerFactoryClass javax.jdo.option.DetachAllOnCommit javax.jdo.option.NonTransactionalRead javax.jdo.option.ConnectionUserName fs.har.impl This addresses bug HIVE-2196 . https://issues.apache.org/jira/browse/HIVE-2196 Diffs (updated) trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1198626 trunk/conf/hive-default.xml 1198626 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1198626 Diff: https://reviews.apache.org/r/1423/diff Testing ------- All unit tests passed Thanks, chinna
          Chinna Rao Lalam made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Chinna Rao Lalam made changes -
          Attachment HIVE-2196.6.patch [ 12502890 ]
          Namit Jain made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Hide
          Namit Jain added a comment -

          And, also please mark it as 'Patch Available' so that everyone takes a look

          Show
          Namit Jain added a comment - And, also please mark it as 'Patch Available' so that everyone takes a look
          Hide
          Namit Jain added a comment -

          @Chinna, this slipped through the cracks and is not generating a lot of merge conflicts.
          I think this is a really good idea - Can you refresh ? I will definitely go over it this time and try to get it in.

          Show
          Namit Jain added a comment - @Chinna, this slipped through the cracks and is not generating a lot of merge conflicts. I think this is a really good idea - Can you refresh ? I will definitely go over it this time and try to get it in.
          Ashutosh Chauhan made changes -
          Link This issue blocks HIVE-1984 [ HIVE-1984 ]
          Chinna Rao Lalam made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/1423/
          -----------------------------------------------------------

          (Updated 2011-10-14 16:54:00.383612)

          Review request for hive, Carl Steinbach and John Sichi.

          Changes
          -------

          Rebase the patch on the trunk

          Summary
          -------

          The below configurations are not used in the code base so removed from the hive-default.xml

          hive.mapjoin.hashtable.initialCapacity
          hive.mapjoin.hashtable.loadfactor
          hive.mapjoin.smalltable.filesize
          hive.optimize.pruner
          hive.stats.jdbc.atomic
          hive.concurrency.manager

          The below configurations are not used in the code base but these configurations are required for the system so need to maintain in the hive-default.xml and no need to add in the HiveConf.java

          javax.jdo.option.ConnectionDriverName
          javax.jdo.PersistenceManagerFactoryClass
          javax.jdo.option.DetachAllOnCommit
          javax.jdo.option.NonTransactionalRead
          javax.jdo.option.ConnectionUserName
          fs.har.impl

          This addresses bug HIVE-2196.
          https://issues.apache.org/jira/browse/HIVE-2196

          Diffs (updated)


          trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1182263
          trunk/conf/hive-default.xml 1182263
          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1182263
          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1182263
          trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMarkPartitionRemote.java 1182263
          trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreAuthorization.java 1182263
          trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java 1182263
          trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteHiveMetaStore.java 1182263
          trunk/shims/src/test/org/apache/hadoop/hive/thrift/TestHadoop20SAuthBridge.java 1182263

          Diff: https://reviews.apache.org/r/1423/diff

          Testing
          -------

          All unit tests passed

          Thanks,

          chinna

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1423/ ----------------------------------------------------------- (Updated 2011-10-14 16:54:00.383612) Review request for hive, Carl Steinbach and John Sichi. Changes ------- Rebase the patch on the trunk Summary ------- The below configurations are not used in the code base so removed from the hive-default.xml hive.mapjoin.hashtable.initialCapacity hive.mapjoin.hashtable.loadfactor hive.mapjoin.smalltable.filesize hive.optimize.pruner hive.stats.jdbc.atomic hive.concurrency.manager The below configurations are not used in the code base but these configurations are required for the system so need to maintain in the hive-default.xml and no need to add in the HiveConf.java javax.jdo.option.ConnectionDriverName javax.jdo.PersistenceManagerFactoryClass javax.jdo.option.DetachAllOnCommit javax.jdo.option.NonTransactionalRead javax.jdo.option.ConnectionUserName fs.har.impl This addresses bug HIVE-2196 . https://issues.apache.org/jira/browse/HIVE-2196 Diffs (updated) trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1182263 trunk/conf/hive-default.xml 1182263 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1182263 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1182263 trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMarkPartitionRemote.java 1182263 trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreAuthorization.java 1182263 trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java 1182263 trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteHiveMetaStore.java 1182263 trunk/shims/src/test/org/apache/hadoop/hive/thrift/TestHadoop20SAuthBridge.java 1182263 Diff: https://reviews.apache.org/r/1423/diff Testing ------- All unit tests passed Thanks, chinna
          Hide
          Chinna Rao Lalam added a comment -

          Rebase the patch on the trunk

          Show
          Chinna Rao Lalam added a comment - Rebase the patch on the trunk
          Chinna Rao Lalam made changes -
          Attachment HIVE-2196.5.patch [ 12499062 ]
          Hide
          Ashutosh Chauhan added a comment -

          Looks like HIVE-1571 will get fixed alongwith this.

          Show
          Ashutosh Chauhan added a comment - Looks like HIVE-1571 will get fixed alongwith this.
          Ashutosh Chauhan made changes -
          Link This issue incorporates HIVE-1571 [ HIVE-1571 ]
          Hide
          Ashutosh Chauhan added a comment -

          @Chinna,

          I guess you need to mark it as Patch Available so that committers know that its ready for review. We should get this in, lest some other property get introduced which again violates this.

          Others,
          HiveConf first loads hive-default.xml and then loads hive-site.xml Isn't loading hive-default.xml will be redundant after this change. Default values should come from HiveConf not from external xml file, if user wishes to override he should provide that value in hive-site.xml. We should stop loading hive-default.xml while initializing HiveConf.

          Show
          Ashutosh Chauhan added a comment - @Chinna, I guess you need to mark it as Patch Available so that committers know that its ready for review. We should get this in, lest some other property get introduced which again violates this. Others, HiveConf first loads hive-default.xml and then loads hive-site.xml Isn't loading hive-default.xml will be redundant after this change. Default values should come from HiveConf not from external xml file, if user wishes to override he should provide that value in hive-site.xml. We should stop loading hive-default.xml while initializing HiveConf.
          Chinna Rao Lalam made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Chinna Rao Lalam made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Chinna Rao Lalam added a comment -

          All tests passed. Changes make it sink the contents of hive-default.xml to Hiveconf.java. After hive-default.xml loaded hive-site.xml will load so no need to change the contents of hive-site.xml

          Show
          Chinna Rao Lalam added a comment - All tests passed. Changes make it sink the contents of hive-default.xml to Hiveconf.java. After hive-default.xml loaded hive-site.xml will load so no need to change the contents of hive-site.xml
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/1423/
          -----------------------------------------------------------

          (Updated 2011-09-27 15:51:37.029125)

          Review request for hive, Carl Steinbach and John Sichi.

          Changes
          -------

          All tests passed

          Summary
          -------

          The below configurations are not used in the code base so removed from the hive-default.xml

          hive.mapjoin.hashtable.initialCapacity
          hive.mapjoin.hashtable.loadfactor
          hive.mapjoin.smalltable.filesize
          hive.optimize.pruner
          hive.stats.jdbc.atomic
          hive.concurrency.manager

          The below configurations are not used in the code base but these configurations are required for the system so need to maintain in the hive-default.xml and no need to add in the HiveConf.java

          javax.jdo.option.ConnectionDriverName
          javax.jdo.PersistenceManagerFactoryClass
          javax.jdo.option.DetachAllOnCommit
          javax.jdo.option.NonTransactionalRead
          javax.jdo.option.ConnectionUserName
          fs.har.impl

          This addresses bug HIVE-2196.
          https://issues.apache.org/jira/browse/HIVE-2196

          Diffs (updated)


          trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1175859
          trunk/conf/hive-default.xml 1175859
          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1175859
          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1175859
          trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMarkPartitionRemote.java 1175859
          trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreAuthorization.java 1175859
          trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java 1175859
          trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteHiveMetaStore.java 1175859
          trunk/shims/src/test/org/apache/hadoop/hive/thrift/TestHadoop20SAuthBridge.java 1175859

          Diff: https://reviews.apache.org/r/1423/diff

          Testing
          -------

          All unit tests passed

          Thanks,

          chinna

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1423/ ----------------------------------------------------------- (Updated 2011-09-27 15:51:37.029125) Review request for hive, Carl Steinbach and John Sichi. Changes ------- All tests passed Summary ------- The below configurations are not used in the code base so removed from the hive-default.xml hive.mapjoin.hashtable.initialCapacity hive.mapjoin.hashtable.loadfactor hive.mapjoin.smalltable.filesize hive.optimize.pruner hive.stats.jdbc.atomic hive.concurrency.manager The below configurations are not used in the code base but these configurations are required for the system so need to maintain in the hive-default.xml and no need to add in the HiveConf.java javax.jdo.option.ConnectionDriverName javax.jdo.PersistenceManagerFactoryClass javax.jdo.option.DetachAllOnCommit javax.jdo.option.NonTransactionalRead javax.jdo.option.ConnectionUserName fs.har.impl This addresses bug HIVE-2196 . https://issues.apache.org/jira/browse/HIVE-2196 Diffs (updated) trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1175859 trunk/conf/hive-default.xml 1175859 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1175859 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1175859 trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMarkPartitionRemote.java 1175859 trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreAuthorization.java 1175859 trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java 1175859 trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteHiveMetaStore.java 1175859 trunk/shims/src/test/org/apache/hadoop/hive/thrift/TestHadoop20SAuthBridge.java 1175859 Diff: https://reviews.apache.org/r/1423/diff Testing ------- All unit tests passed Thanks, chinna
          Chinna Rao Lalam made changes -
          Attachment HIVE-2196.4.patch [ 12496704 ]
          Carl Steinbach made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Hide
          Carl Steinbach added a comment -

          Please run the tests before submitting a patch. All of the tests currently fail due to an assertion error in HiveConf:

          java.lang.AssertionError
          	at org.apache.hadoop.hive.conf.HiveConf.getVar(HiveConf.java:638)
          	at org.apache.hadoop.hive.conf.HiveConf.getVar(HiveConf.java:648)
          	at org.apache.hadoop.hive.ql.lockmgr.zookeeper.ZooKeeperHiveLockManager.getQuorumServers(ZooKeeperHiveLockManager.java:80)
          	at org.apache.hadoop.hive.ql.lockmgr.zookeeper.ZooKeeperHiveLockManager.setContext(ZooKeeperHiveLockManager.java:92)
          	at org.apache.hadoop.hive.ql.Driver.setLockManager(Driver.java:168)
          	at org.apache.hadoop.hive.ql.Driver.checkLockManager(Driver.java:141)
          	at org.apache.hadoop.hive.ql.Driver.run(Driver.java:908)
          	at org.apache.hadoop.hive.ql.QTestUtil.runLoadCmd(QTestUtil.java:394)
          	at org.apache.hadoop.hive.ql.QTestUtil.createSources(QTestUtil.java:441)
          	at org.apache.hadoop.hive.cli.TestCliDriver.<clinit>(TestCliDriver.java:38)
          	at java.lang.Class.forName0(Native Method)
          	at java.lang.Class.forName(Class.java:169)
          	at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:337)
          	at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.launch(JUnitTestRunner.java:931)
          	at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestRunner.java:785)
          

          Also, please update the contents of data/conf/hive-site.xml

          Thanks.

          Show
          Carl Steinbach added a comment - Please run the tests before submitting a patch. All of the tests currently fail due to an assertion error in HiveConf: java.lang.AssertionError at org.apache.hadoop.hive.conf.HiveConf.getVar(HiveConf.java:638) at org.apache.hadoop.hive.conf.HiveConf.getVar(HiveConf.java:648) at org.apache.hadoop.hive.ql.lockmgr.zookeeper.ZooKeeperHiveLockManager.getQuorumServers(ZooKeeperHiveLockManager.java:80) at org.apache.hadoop.hive.ql.lockmgr.zookeeper.ZooKeeperHiveLockManager.setContext(ZooKeeperHiveLockManager.java:92) at org.apache.hadoop.hive.ql.Driver.setLockManager(Driver.java:168) at org.apache.hadoop.hive.ql.Driver.checkLockManager(Driver.java:141) at org.apache.hadoop.hive.ql.Driver.run(Driver.java:908) at org.apache.hadoop.hive.ql.QTestUtil.runLoadCmd(QTestUtil.java:394) at org.apache.hadoop.hive.ql.QTestUtil.createSources(QTestUtil.java:441) at org.apache.hadoop.hive.cli.TestCliDriver.<clinit>(TestCliDriver.java:38) at java.lang.Class.forName0(Native Method) at java.lang.Class.forName(Class.java:169) at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:337) at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.launch(JUnitTestRunner.java:931) at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestRunner.java:785) Also, please update the contents of data/conf/hive-site.xml Thanks.
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/1423/
          -----------------------------------------------------------

          (Updated 2011-09-06 06:16:26.733090)

          Review request for hive, Carl Steinbach and John Sichi.

          Changes
          -------

          Reworked on the patch and latest patch taken care the below issues
          1) Configuration property values verified and made it sync with the hive-default.xml
          2) Compilation failure corrected.

          Summary
          -------

          The below configurations are not used in the code base so removed from the hive-default.xml

          hive.mapjoin.hashtable.initialCapacity
          hive.mapjoin.hashtable.loadfactor
          hive.mapjoin.smalltable.filesize
          hive.optimize.pruner
          hive.stats.jdbc.atomic
          hive.concurrency.manager

          The below configurations are not used in the code base but these configurations are required for the system so need to maintain in the hive-default.xml and no need to add in the HiveConf.java

          javax.jdo.option.ConnectionDriverName
          javax.jdo.PersistenceManagerFactoryClass
          javax.jdo.option.DetachAllOnCommit
          javax.jdo.option.NonTransactionalRead
          javax.jdo.option.ConnectionUserName
          fs.har.impl

          This addresses bug HIVE-2196.
          https://issues.apache.org/jira/browse/HIVE-2196

          Diffs (updated)


          trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteHiveMetaStore.java 1165244
          trunk/shims/src/test/org/apache/hadoop/hive/thrift/TestHadoop20SAuthBridge.java 1165244
          trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMarkPartitionRemote.java 1165244
          trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreAuthorization.java 1165244
          trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java 1165244
          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1165244
          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1165244
          trunk/conf/hive-default.xml 1165244
          trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1165244

          Diff: https://reviews.apache.org/r/1423/diff

          Testing
          -------

          All unit tests passed

          Thanks,

          chinna

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1423/ ----------------------------------------------------------- (Updated 2011-09-06 06:16:26.733090) Review request for hive, Carl Steinbach and John Sichi. Changes ------- Reworked on the patch and latest patch taken care the below issues 1) Configuration property values verified and made it sync with the hive-default.xml 2) Compilation failure corrected. Summary ------- The below configurations are not used in the code base so removed from the hive-default.xml hive.mapjoin.hashtable.initialCapacity hive.mapjoin.hashtable.loadfactor hive.mapjoin.smalltable.filesize hive.optimize.pruner hive.stats.jdbc.atomic hive.concurrency.manager The below configurations are not used in the code base but these configurations are required for the system so need to maintain in the hive-default.xml and no need to add in the HiveConf.java javax.jdo.option.ConnectionDriverName javax.jdo.PersistenceManagerFactoryClass javax.jdo.option.DetachAllOnCommit javax.jdo.option.NonTransactionalRead javax.jdo.option.ConnectionUserName fs.har.impl This addresses bug HIVE-2196 . https://issues.apache.org/jira/browse/HIVE-2196 Diffs (updated) trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteHiveMetaStore.java 1165244 trunk/shims/src/test/org/apache/hadoop/hive/thrift/TestHadoop20SAuthBridge.java 1165244 trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMarkPartitionRemote.java 1165244 trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreAuthorization.java 1165244 trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java 1165244 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1165244 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1165244 trunk/conf/hive-default.xml 1165244 trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1165244 Diff: https://reviews.apache.org/r/1423/diff Testing ------- All unit tests passed Thanks, chinna
          Chinna Rao Lalam made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Affects Version/s 0.8.0 [ 12316178 ]
          Hide
          Chinna Rao Lalam added a comment -

          @Carl: Reworked on the patch and latest patch taken care the below issues
          1) Configuration property values verified and made it sync with the hive-default.xml
          2) Compilation failure corrected.

          Show
          Chinna Rao Lalam added a comment - @Carl: Reworked on the patch and latest patch taken care the below issues 1) Configuration property values verified and made it sync with the hive-default.xml 2) Compilation failure corrected.
          Chinna Rao Lalam made changes -
          Attachment HIVE-2196.3.patch [ 12493117 ]
          Hide
          Carl Steinbach added a comment -

          @Chinna: Please followup on the issue raised by Ashutosh. Configuration property values should match in HiveConf and hive-default.xml. If they don't match then the value that appears in hive-default.xml should be copied over to HiveConf. Thanks.

          Show
          Carl Steinbach added a comment - @Chinna: Please followup on the issue raised by Ashutosh. Configuration property values should match in HiveConf and hive-default.xml. If they don't match then the value that appears in hive-default.xml should be copied over to HiveConf. Thanks.
          Hide
          Ashutosh Chauhan added a comment -

          What about the values? Some keys have different default value in HiveConf then from hive-default.xml. Shouldn't the values should also match up in two places?

          Show
          Ashutosh Chauhan added a comment - What about the values? Some keys have different default value in HiveConf then from hive-default.xml. Shouldn't the values should also match up in two places?
          Hide
          Carl Steinbach added a comment -

          @Chinna: I suspect this is working for you because you haven't run 'ant clean'. If you
          do you'll see that your changes have introduced a circular build dependency: hive-shims
          depends on hive-common and vice-versa, whereas previously hive-common only depended
          on hive-shims. If you revert your changes to the shims/ directory I think this patch
          will build cleanly and should be ready to commit.

          Show
          Carl Steinbach added a comment - @Chinna: I suspect this is working for you because you haven't run 'ant clean'. If you do you'll see that your changes have introduced a circular build dependency: hive-shims depends on hive-common and vice-versa, whereas previously hive-common only depended on hive-shims. If you revert your changes to the shims/ directory I think this patch will build cleanly and should be ready to commit.
          Carl Steinbach made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Carl Steinbach made changes -
          Attachment HIVE-2196.build.log [ 12492116 ]
          Hide
          Carl Steinbach added a comment -

          @Chinna: Compilation still fails for me. Please see the attached ant build log for more details.

          Show
          Carl Steinbach added a comment - @Chinna: Compilation still fails for me. Please see the attached ant build log for more details.
          Chinna Rao Lalam made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Chinna Rao Lalam added a comment -

          Hi Carl,
          i applied the patch on trunk i did not get compilation failure and in HiveIOExceptionHandlerChain HiveConf is improted in this patch. Can u check one more time. I am submitting the same patch.

          Show
          Chinna Rao Lalam added a comment - Hi Carl, i applied the patch on trunk i did not get compilation failure and in HiveIOExceptionHandlerChain HiveConf is improted in this patch. Can u check one more time. I am submitting the same patch.
          Carl Steinbach made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Hide
          Carl Steinbach added a comment -

          I get a compilation error in HiveIOExceptionHandlerChain. Looks like you need to import HiveConf.

          Show
          Carl Steinbach added a comment - I get a compilation error in HiveIOExceptionHandlerChain. Looks like you need to import HiveConf.
          Hide
          Carl Steinbach added a comment -

          +1. Will commit if tests pass.

          Show
          Carl Steinbach added a comment - +1. Will commit if tests pass.
          Chinna Rao Lalam made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Chinna Rao Lalam added a comment -

          These configurations are added to HiveConf.java

          javax.jdo.option.ConnectionDriverName
          javax.jdo.PersistenceManagerFactoryClass
          javax.jdo.option.DetachAllOnCommit
          javax.jdo.option.NonTransactionalRead
          javax.jdo.option.ConnectionUserName
          fs.har.impl

          Show
          Chinna Rao Lalam added a comment - These configurations are added to HiveConf.java javax.jdo.option.ConnectionDriverName javax.jdo.PersistenceManagerFactoryClass javax.jdo.option.DetachAllOnCommit javax.jdo.option.NonTransactionalRead javax.jdo.option.ConnectionUserName fs.har.impl
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/1423/
          -----------------------------------------------------------

          (Updated 2011-08-16 14:51:32.766435)

          Review request for hive, Carl Steinbach and John Sichi.

          Changes
          -------

          These configurations are added to HiveConf.java

          javax.jdo.option.ConnectionDriverName
          javax.jdo.PersistenceManagerFactoryClass
          javax.jdo.option.DetachAllOnCommit
          javax.jdo.option.NonTransactionalRead
          javax.jdo.option.ConnectionUserName
          fs.har.impl

          Summary
          -------

          The below configurations are not used in the code base so removed from the hive-default.xml

          hive.mapjoin.hashtable.initialCapacity
          hive.mapjoin.hashtable.loadfactor
          hive.mapjoin.smalltable.filesize
          hive.optimize.pruner
          hive.stats.jdbc.atomic
          hive.concurrency.manager

          The below configurations are not used in the code base but these configurations are required for the system so need to maintain in the hive-default.xml and no need to add in the HiveConf.java

          javax.jdo.option.ConnectionDriverName
          javax.jdo.PersistenceManagerFactoryClass
          javax.jdo.option.DetachAllOnCommit
          javax.jdo.option.NonTransactionalRead
          javax.jdo.option.ConnectionUserName
          fs.har.impl

          This addresses bug HIVE-2196.
          https://issues.apache.org/jira/browse/HIVE-2196

          Diffs (updated)


          trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1158213
          trunk/conf/hive-default.xml 1158213
          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1158213
          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1158213
          trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMarkPartitionRemote.java 1158213
          trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreAuthorization.java 1158213
          trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java 1158213
          trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteHiveMetaStore.java 1158213
          trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionHandlerChain.java 1158213
          trunk/shims/src/test/org/apache/hadoop/hive/thrift/TestHadoop20SAuthBridge.java 1158213

          Diff: https://reviews.apache.org/r/1423/diff

          Testing
          -------

          All unit tests passed

          Thanks,

          chinna

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1423/ ----------------------------------------------------------- (Updated 2011-08-16 14:51:32.766435) Review request for hive, Carl Steinbach and John Sichi. Changes ------- These configurations are added to HiveConf.java javax.jdo.option.ConnectionDriverName javax.jdo.PersistenceManagerFactoryClass javax.jdo.option.DetachAllOnCommit javax.jdo.option.NonTransactionalRead javax.jdo.option.ConnectionUserName fs.har.impl Summary ------- The below configurations are not used in the code base so removed from the hive-default.xml hive.mapjoin.hashtable.initialCapacity hive.mapjoin.hashtable.loadfactor hive.mapjoin.smalltable.filesize hive.optimize.pruner hive.stats.jdbc.atomic hive.concurrency.manager The below configurations are not used in the code base but these configurations are required for the system so need to maintain in the hive-default.xml and no need to add in the HiveConf.java javax.jdo.option.ConnectionDriverName javax.jdo.PersistenceManagerFactoryClass javax.jdo.option.DetachAllOnCommit javax.jdo.option.NonTransactionalRead javax.jdo.option.ConnectionUserName fs.har.impl This addresses bug HIVE-2196 . https://issues.apache.org/jira/browse/HIVE-2196 Diffs (updated) trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1158213 trunk/conf/hive-default.xml 1158213 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1158213 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1158213 trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMarkPartitionRemote.java 1158213 trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreAuthorization.java 1158213 trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java 1158213 trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteHiveMetaStore.java 1158213 trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionHandlerChain.java 1158213 trunk/shims/src/test/org/apache/hadoop/hive/thrift/TestHadoop20SAuthBridge.java 1158213 Diff: https://reviews.apache.org/r/1423/diff Testing ------- All unit tests passed Thanks, chinna
          Chinna Rao Lalam made changes -
          Attachment HIVE-2196.2.patch [ 12490538 ]
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/1423/#review1451
          -----------------------------------------------------------

          > The below configurations are not used in the code base but these configurations are required for the system so need to maintain in the hive-default.xml and no need to add in the HiveConf.java

          Actually, everything that appears in hive-default.xml should also appear in HiveConf and vice-versa.

          • Carl

          On 2011-08-09 19:11:13, chinna wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/1423/

          -----------------------------------------------------------

          (Updated 2011-08-09 19:11:13)

          Review request for hive, Carl Steinbach and John Sichi.

          Summary

          -------

          The below configurations are not used in the code base so removed from the hive-default.xml

          hive.mapjoin.hashtable.initialCapacity

          hive.mapjoin.hashtable.loadfactor

          hive.mapjoin.smalltable.filesize

          hive.optimize.pruner

          hive.stats.jdbc.atomic

          hive.concurrency.manager

          The below configurations are not used in the code base but these configurations are required for the system so need to maintain in the hive-default.xml and no need to add in the HiveConf.java

          javax.jdo.option.ConnectionDriverName

          javax.jdo.PersistenceManagerFactoryClass

          javax.jdo.option.DetachAllOnCommit

          javax.jdo.option.NonTransactionalRead

          javax.jdo.option.ConnectionUserName

          fs.har.impl

          This addresses bug HIVE-2196.

          https://issues.apache.org/jira/browse/HIVE-2196

          Diffs

          -----

          trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1155275

          trunk/conf/hive-default.xml 1155275

          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1155275

          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1155275

          trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMarkPartitionRemote.java 1155275

          trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreAuthorization.java 1155275

          trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java 1155275

          trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteHiveMetaStore.java 1155275

          trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionHandlerChain.java 1155275

          trunk/shims/src/test/org/apache/hadoop/hive/thrift/TestHadoop20SAuthBridge.java 1155275

          Diff: https://reviews.apache.org/r/1423/diff

          Testing

          -------

          All unit tests passed

          Thanks,

          chinna

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1423/#review1451 ----------------------------------------------------------- > The below configurations are not used in the code base but these configurations are required for the system so need to maintain in the hive-default.xml and no need to add in the HiveConf.java Actually, everything that appears in hive-default.xml should also appear in HiveConf and vice-versa. Carl On 2011-08-09 19:11:13, chinna wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1423/ ----------------------------------------------------------- (Updated 2011-08-09 19:11:13) Review request for hive, Carl Steinbach and John Sichi. Summary ------- The below configurations are not used in the code base so removed from the hive-default.xml hive.mapjoin.hashtable.initialCapacity hive.mapjoin.hashtable.loadfactor hive.mapjoin.smalltable.filesize hive.optimize.pruner hive.stats.jdbc.atomic hive.concurrency.manager The below configurations are not used in the code base but these configurations are required for the system so need to maintain in the hive-default.xml and no need to add in the HiveConf.java javax.jdo.option.ConnectionDriverName javax.jdo.PersistenceManagerFactoryClass javax.jdo.option.DetachAllOnCommit javax.jdo.option.NonTransactionalRead javax.jdo.option.ConnectionUserName fs.har.impl This addresses bug HIVE-2196 . https://issues.apache.org/jira/browse/HIVE-2196 Diffs ----- trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1155275 trunk/conf/hive-default.xml 1155275 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1155275 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1155275 trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMarkPartitionRemote.java 1155275 trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreAuthorization.java 1155275 trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java 1155275 trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteHiveMetaStore.java 1155275 trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionHandlerChain.java 1155275 trunk/shims/src/test/org/apache/hadoop/hive/thrift/TestHadoop20SAuthBridge.java 1155275 Diff: https://reviews.apache.org/r/1423/diff Testing ------- All unit tests passed Thanks, chinna
          Carl Steinbach made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Chinna Rao Lalam made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Chinna Rao Lalam added a comment -

          Added review board request.

          https://reviews.apache.org/r/1423/

          Show
          Chinna Rao Lalam added a comment - Added review board request. https://reviews.apache.org/r/1423/
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/1423/
          -----------------------------------------------------------

          Review request for hive, Carl Steinbach and John Sichi.

          Summary
          -------

          The below configurations are not used in the code base so removed from the hive-default.xml

          hive.mapjoin.hashtable.initialCapacity
          hive.mapjoin.hashtable.loadfactor
          hive.mapjoin.smalltable.filesize
          hive.optimize.pruner
          hive.stats.jdbc.atomic
          hive.concurrency.manager

          The below configurations are not used in the code base but these configurations are required for the system so need to maintain in the hive-default.xml and no need to add in the HiveConf.java

          javax.jdo.option.ConnectionDriverName
          javax.jdo.PersistenceManagerFactoryClass
          javax.jdo.option.DetachAllOnCommit
          javax.jdo.option.NonTransactionalRead
          javax.jdo.option.ConnectionUserName
          fs.har.impl

          This addresses bug HIVE-2196.
          https://issues.apache.org/jira/browse/HIVE-2196

          Diffs


          trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1155275
          trunk/conf/hive-default.xml 1155275
          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1155275
          trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1155275
          trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMarkPartitionRemote.java 1155275
          trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreAuthorization.java 1155275
          trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java 1155275
          trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteHiveMetaStore.java 1155275
          trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionHandlerChain.java 1155275
          trunk/shims/src/test/org/apache/hadoop/hive/thrift/TestHadoop20SAuthBridge.java 1155275

          Diff: https://reviews.apache.org/r/1423/diff

          Testing
          -------

          All unit tests passed

          Thanks,

          chinna

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1423/ ----------------------------------------------------------- Review request for hive, Carl Steinbach and John Sichi. Summary ------- The below configurations are not used in the code base so removed from the hive-default.xml hive.mapjoin.hashtable.initialCapacity hive.mapjoin.hashtable.loadfactor hive.mapjoin.smalltable.filesize hive.optimize.pruner hive.stats.jdbc.atomic hive.concurrency.manager The below configurations are not used in the code base but these configurations are required for the system so need to maintain in the hive-default.xml and no need to add in the HiveConf.java javax.jdo.option.ConnectionDriverName javax.jdo.PersistenceManagerFactoryClass javax.jdo.option.DetachAllOnCommit javax.jdo.option.NonTransactionalRead javax.jdo.option.ConnectionUserName fs.har.impl This addresses bug HIVE-2196 . https://issues.apache.org/jira/browse/HIVE-2196 Diffs trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1155275 trunk/conf/hive-default.xml 1155275 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1155275 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1155275 trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMarkPartitionRemote.java 1155275 trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreAuthorization.java 1155275 trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java 1155275 trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteHiveMetaStore.java 1155275 trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionHandlerChain.java 1155275 trunk/shims/src/test/org/apache/hadoop/hive/thrift/TestHadoop20SAuthBridge.java 1155275 Diff: https://reviews.apache.org/r/1423/diff Testing ------- All unit tests passed Thanks, chinna
          Chinna Rao Lalam made changes -
          Attachment HIVE-2196.1.patch [ 12489845 ]
          Hide
          Chinna Rao Lalam added a comment -

          Patch updated with below information

          The below configurations are not used in the code base so removed from the hive-default.xml

          hive.mapjoin.hashtable.initialCapacity
          hive.mapjoin.hashtable.loadfactor
          hive.mapjoin.smalltable.filesize
          hive.optimize.pruner
          hive.stats.jdbc.atomic
          hive.concurrency.manager

          The below configurations are not used in the code base but these configurations are required for the system so need to maintain in the hive-default.xml and no need to add in the HiveConf.java

          javax.jdo.option.ConnectionDriverName
          javax.jdo.PersistenceManagerFactoryClass
          javax.jdo.option.DetachAllOnCommit
          javax.jdo.option.NonTransactionalRead
          javax.jdo.option.ConnectionUserName
          fs.har.impl

          Show
          Chinna Rao Lalam added a comment - Patch updated with below information The below configurations are not used in the code base so removed from the hive-default.xml hive.mapjoin.hashtable.initialCapacity hive.mapjoin.hashtable.loadfactor hive.mapjoin.smalltable.filesize hive.optimize.pruner hive.stats.jdbc.atomic hive.concurrency.manager The below configurations are not used in the code base but these configurations are required for the system so need to maintain in the hive-default.xml and no need to add in the HiveConf.java javax.jdo.option.ConnectionDriverName javax.jdo.PersistenceManagerFactoryClass javax.jdo.option.DetachAllOnCommit javax.jdo.option.NonTransactionalRead javax.jdo.option.ConnectionUserName fs.har.impl
          John Sichi made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Hide
          John Sichi added a comment -

          For each one of these, we need to verify that the parameter is actually used. For example, I searched the code for references to hive.optimize.pruner, and could not find any. In such cases, we should delete from xml rather than add to HiveConf.

          For cases where the parameter is still used (e.g. hive.io.exception.handlers), we should change the points of reference to go through the HiveConf symbol.

          Show
          John Sichi added a comment - For each one of these, we need to verify that the parameter is actually used. For example, I searched the code for references to hive.optimize.pruner, and could not find any. In such cases, we should delete from xml rather than add to HiveConf. For cases where the parameter is still used (e.g. hive.io.exception.handlers), we should change the points of reference to go through the HiveConf symbol.
          Carl Steinbach made changes -
          Assignee Carl Steinbach [ cwsteinbach ] Chinna Rao Lalam [ chinnalalam ]
          Chinna Rao Lalam made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Chinna Rao Lalam made changes -
          Field Original Value New Value
          Attachment HIVE-2196.patch [ 12485283 ]
          Carl Steinbach created issue -

            People

            • Assignee:
              Chinna Rao Lalam
              Reporter:
              Carl Steinbach
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development