[HIVE-21729] Arrow serializer sometimes shifts timestamp by one second

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.0.0
• Fix Version/s: 4.0.0-alpha-1
• Component/s: Serializers/Deserializers
• Labels: pull-request-available timestamp
• Assignee: Shubham Chaurasia Assign to me
• Reporter: Shubham Chaurasia
• Created: 15/May/19 05:22
• Updated: 29/Nov/22 10:02
• Resolved: 15/May/19 12:07

Description

This happens due to secondInMicros are calculated like

final long secondInMicros = (secondInMillis - secondInMillis % MILLIS_PER_SECOND) * MICROS_PER_MILLIS;

Instead this should be calculated like(by taking nanos from timestampColumnVector itself)

final long nanos = timestampColumnVector.getNanos(j);
final long secondInMicros = (secondInMillis - nanos / NS_PER_MILLIS) * MICROS_PER_MILLIS;

Issue Links

• Is contained by: HIVE-26751 Bug Fixes and Improvements for 3.2.0 release
• links to: GitHub Pull Request #627