[HIVE-21636] ReplaceAll() -> replace() for non regex strings

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: 4.0.0-alpha-1
• Component/s: Accumulo Storage Handler, HCatalog, Vectorization
• Labels: pull-request-available
• Target Version/s: 4.0.0
• Flags: Patch
• Assignee: bd2019us Assign to me
• Reporter: bd2019us
• Created: 20/Apr/19 21:04
• Updated: 17/Nov/22 08:50
• Resolved: 11/Jun/20 17:05

Description

Use String.replace() instead of String.replaceAll() when replaceAll() does not use a regex

replace() does not need extra compilation / performance overhead when a non-regex string is used. Thus changing replaceAll() to replace() can remove the associated performance overhead.

Affected files:

1. accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/predicate/compare/StringCompare.java
2. hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/FileOutputCommitterContainer.java
3. vector-code-gen/src/org/apache/hadoop/hive/tools/GenVectorCode.java

Issue Links

• links to: GitHub Pull Request #599