[HIVE-21371] Make NonSyncByteArrayOutputStream Overflow Conscious

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.2.0, 4.0.0
• Fix Version/s: 4.0.0-alpha-1
• Assignee: David Mollitor
• Reporter: David Mollitor
• Created: 01/Mar/19 20:46
• Updated: 17/Nov/22 08:50
• Resolved: 11/Mar/19 05:53

Description

NonSyncByteArrayOutputStream

  private int enLargeBuffer(int increment) {
    int temp = count + increment;
    int newLen = temp;
    if (temp > buf.length) {
      if ((buf.length << 1) > temp) {
        newLen = buf.length << 1;
      }
      byte newbuf[] = new byte[newLen];
      System.arraycopy(buf, 0, newbuf, 0, count);
      buf = newbuf;
    }
    return newLen;
  }

This will fail if the array is 2GB or larger because it will double the size every time without consideration for the 4GB limit on arrays.