Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-21369

LLAP: Logging is expensive in encoded reader path

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Patch Available
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: 3.2.0, 4.0.0
    • Fix Version/s: None
    • Component/s: Logging
    • Labels:
      None

      Description

      There should be no INFO logging in EncodedReaderImpl. Stringifying of disk ranges is expensive in core read path.

      2019-03-01T17:55:56.322852142Z 2019-03-01T17:55:56,306 INFO  [IO-Elevator-Thread-3 (hive_20190301175546_a279f33c-4f2b-4cd5-8695-57bc8b042a61)] encoded.EncodedReaderImpl: Disk ranges after cache (found everything true; file [-3693547618692831801, 1551190876000, 1047660824], base offset 792920167): [{start: 887940 end: 1003508 cache buffer: 0x5165f83d(1)}, {start: 1003508 end: 1119078 cache buffer: 0xb63cac3(1)}, {start: 1119078 end: 1234745 cache buffer: 0x41a724fa(1)}, {start: 1234745 end: 1350261 cache buffer: 0x2f71bc38(1)}, {start: 1350261 end: 1465752 cache buffer: 0x2c38e1bb(1)}, {start: 1465752 end: 1581231 cache buffer: 0x5827982(1)}, {start: 1581231 end: 1696885 cache buffer: 0x75a6773c(1)}, {start: 1696885 end: 1812492 cache buffer: 0x2ed060f9(1)},{start: 1812492 end: 1928086 cache buffer: 0x20b2c8aa(1)}, {start: 1928086 end: 2043588 cache buffer: 0x6559aacb(1)}, {start: 2043588 end: 2159089 cache buffer: 0x569c85e1(1)}, {start: 2159089 end: 2274725 cache buffer: 0x25a88dd0(1)}, {start: 2274725 end: 2390228 cache buffer: 0x738b7e87(1)}, {start: 2390228 end: 2505715 cache buffer: 0x26edafa0(1)}, {start: 2505715 end: 2621322 cache buffer: 0x69db7752(1)}, {start: 2621322 end: 2736844 cache b

        Attachments

        1. HIVE-21369.patch
          2 kB
          Nita Dembla
        2. HIVE-21369.patch.2
          2 kB
          Nita Dembla
        3. HIVE-21369.2.patch
          2 kB
          Prasanth Jayachandran

          Activity

            People

            • Assignee:
              ndembla Nita Dembla
              Reporter:
              prasanth_j Prasanth Jayachandran
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated: