[HIVE-21290] Restore historical way of handling timestamps in Parquet while keeping the new semantics at the same time

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.1.2, 3.2.0, 4.0.0-alpha-1
• Target Version/s: 3.1.2, 3.2.0, 4.0.0
• Assignee: Karen Coppage
• Reporter: Zoltan Ivanfi
• Created: 19/Feb/19 16:22
• Updated: 27/Feb/24 22:23
• Resolved: 27/Mar/19 20:44

Description

This sub-task is for implementing the Parquet-specific parts of the following plan:

Problem

Historically, the semantics of the TIMESTAMP type in Hive depended on the file format. Timestamps in Avro, Parquet and RCFiles with a binary SerDe had Instant semantics, while timestamps in ORC, textfiles and RCFiles with a text SerDe had LocalDateTime semantics.

The Hive community wanted to get rid of this inconsistency and have LocalDateTime semantics in Avro, Parquet and RCFiles with a binary SerDe as well. Hive 3.1 turned off normalization to UTC to achieve this. While this leads to the desired new semantics, it also leads to incorrect results when new Hive versions read timestamps written by old Hive versions or when old Hive versions or any other component not aware of this change (including legacy Impala and Spark versions) read timestamps written by new Hive versions.

Solution

To work around this issue, Hive should restore the practice of normalizing to UTC when writing timestamps to Avro, Parquet and RCFiles with a binary SerDe. In itself, this would restore the historical Instant semantics, which is undesirable. In order to achieve the desired LocalDateTime semantics in spite of normalizing to UTC, newer Hive versions should record the session-local local time zone in the file metadata fields serving arbitrary key-value storage purposes.

When reading back files with this time zone metadata, newer Hive versions (or any other new component aware of this extra metadata) can achieve LocalDateTime semantics by converting from UTC to the saved time zone (instead of to the local time zone). Legacy components that are unaware of the new metadata can read the files without any problem and the timestamps will show the historical Instant behaviour to them.

Issue Links

• causes: HIVE-25129 Wrong results when timestamps stored in Avro/Parquet fall into the DST shift
• is related to: IMPALA-8721 Wrong result when Impala reads a Hive written parquet TimeStamp column
• is related to: IMPALA-10491 Impala parquet scanner should use writer.time.zone when converting Hive timestamps
• links to: review board