Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-21214

MoveTask : Use attemptId instead of file size for deduplication of files compareTempOrDuplicateFiles()

Log workAgile BoardRank to TopRank to BottomBulk Copy AttachmentsBulk Move AttachmentsVotersWatch issueWatchersCreate sub-taskConvert to sub-taskMoveLinkCloneLabelsUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • None
    • None
    • None

    Description

      For a given task, if there is more than one attempt then deduplication logic kicks in.

      Utilities.compareTempOrDuplicateFiles()

      The logic uses file size and picks the one with largest size. This logic is very fragile.

      ideally, it should pick the successful attempt's file.

      However, a simpler solution is to pick the newest attempt and also checking the file size for the newest attempt is the largest.

      If not, throw an exception.

       

      cc Gopal Vijayaraghavan Thejas Nair Jason Dere Eugene Koifman

      Attachments

        1. HIVE-21214.1.patch
          5 kB
          Deepak Jaiswal
        2. HIVE-21214.2.patch
          5 kB
          Deepak Jaiswal
        3. HIVE-21214.3.patch
          5 kB
          Deepak Jaiswal

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            djaiswal Deepak Jaiswal Assign to me
            djaiswal Deepak Jaiswal
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment