Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-20238

Remove stringifyException Method

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Patch Available
    • Minor
    • Resolution: Unresolved
    • 4.0.0
    • None
    • None

    Description

      Deprecate the method stringifyException

      https://github.com/apache/hive/blob/c2940a07cf0891e922672782b73ec22551a7eedd/common/src/java/org/apache/hive/common/util/HiveStringUtils.java#L146

      The code already exists in Hadoop proper:

      https://github.com/apache/hadoop/blob/2b2399d623539ab68e71a38fa9fbfc9a405bddb8/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StringUtils.java#L86

      And beyond that, I was told on the Hadoop dev mailing list that this function should not be used anymore. Developers should just be using the SLF4J facilities and not this home-grown thing.

      Attachments

        1. HIVE-20238.1.patch
          8 kB
          David Mollitor
        2. HIVE-20238.2.patch
          7 kB
          David Mollitor
        3. HIVE-20238.3.patch
          12 kB
          David Mollitor
        4. HIVE-20238.4.patch
          12 kB
          David Mollitor
        5. HIVE-20238.5.patch
          120 kB
          David Mollitor
        6. HIVE-20238.6.patch
          121 kB
          David Mollitor
        7. HIVE-20238.7.patch
          124 kB
          David Mollitor
        8. HIVE-20238.8.patch
          127 kB
          David Mollitor

        Issue Links

          Activity

            People

              belugabehr David Mollitor
              belugabehr David Mollitor
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 4h 40m
                  4h 40m