[HIVE-20237] Do Not Print StackTraces to STDERR in HiveMetaStore

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 3.0.0, 4.0.0
• Fix Version/s: 4.0.0-alpha-1
• Component/s: Standalone Metastore
• Labels: newbie noob
• Assignee: Alice Fan
• Reporter: David Mollitor
• Created: 25/Jul/18 20:57
• Updated: 17/Nov/22 08:55
• Resolved: 22/Aug/18 17:28

Description

HiveMetaStore.java

    } catch (Throwable x) {
      x.printStackTrace();
      HMSHandler.LOG.error(StringUtils.stringifyException(x));
      throw x;
    }

Bad design here of "log and throw". Don't do it. Just throw the exception and let it be handled, and logged, in one place. At the very least, we don't need the error message to go into the STDERR logs with printStackTrace, please remove. And remove the stringifyException code. Just use the normal logging faciltiies at the 'debug' level logging to hide the stack trace during normal operations.

HMSHandler.LOG.debug("Error", e);