Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-20223

SmallTableCache.java SLF4J Parameterized Logging

    Details

    • Type: Improvement
    • Status: Patch Available
    • Priority: Trivial
    • Resolution: Unresolved
    • Affects Version/s: 3.0.0, 4.0.0
    • Fix Version/s: None
    • Component/s: Spark
    • Labels:

      Description

      org/apache/hadoop/hive/ql/exec/spark/SmallTableCache.java
      
      if (LOG.isDebugEnabled()) {
          LOG.debug("Cleaned up small table cache for query " + queryId);
      }
      
          if (tableContainerMap.putIfAbsent(path, tableContainer) == null && LOG.isDebugEnabled()) {
            LOG.debug("Cached small table file " + path + " for query " + queryId);
          }
      
          if (tableContainer != null && LOG.isDebugEnabled()) {
            LOG.debug("Loaded small table file " + path + " from cache for query " + queryId);
          }
      

       

      Remove isDebugEnabled and replace with parameterized logging.

      https://www.slf4j.org/faq.html#logging_performance

        Attachments

          Activity

            People

            • Assignee:
              belugabehr BELUGA BEHR
              Reporter:
              belugabehr BELUGA BEHR
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated: