[HIVE-20223] SmallTableCache.java SLF4J Parameterized Logging

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 3.0.0, 4.0.0
• Fix Version/s: 4.0.0-alpha-1
• Component/s: Spark
• Labels: newbie noob
• Assignee: David Mollitor
• Reporter: David Mollitor
• Created: 23/Jul/18 16:14
• Updated: 17/Nov/22 08:54
• Resolved: 29/Nov/18 11:15

Description

org/apache/hadoop/hive/ql/exec/spark/SmallTableCache.java

if (LOG.isDebugEnabled()) {
    LOG.debug("Cleaned up small table cache for query " + queryId);
}

    if (tableContainerMap.putIfAbsent(path, tableContainer) == null && LOG.isDebugEnabled()) {
      LOG.debug("Cached small table file " + path + " for query " + queryId);
    }

    if (tableContainer != null && LOG.isDebugEnabled()) {
      LOG.debug("Loaded small table file " + path + " from cache for query " + queryId);
    }

 

Remove isDebugEnabled and replace with parameterized logging.

https://www.slf4j.org/faq.html#logging_performance