Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-20223

SmallTableCache.java SLF4J Parameterized Logging

Log workAgile BoardRank to TopRank to BottomBulk Copy AttachmentsBulk Move AttachmentsVotersWatch issueWatchersCreate sub-taskConvert to sub-taskMoveLinkCloneLabelsUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Trivial
    • Resolution: Fixed
    • 3.0.0, 4.0.0
    • 4.0.0, 4.0.0-alpha-1
    • Spark

    Description

      org/apache/hadoop/hive/ql/exec/spark/SmallTableCache.java
      
      if (LOG.isDebugEnabled()) {
          LOG.debug("Cleaned up small table cache for query " + queryId);
      }
      
          if (tableContainerMap.putIfAbsent(path, tableContainer) == null && LOG.isDebugEnabled()) {
            LOG.debug("Cached small table file " + path + " for query " + queryId);
          }
      
          if (tableContainer != null && LOG.isDebugEnabled()) {
            LOG.debug("Loaded small table file " + path + " from cache for query " + queryId);
          }
      

       

      Remove isDebugEnabled and replace with parameterized logging.

      https://www.slf4j.org/faq.html#logging_performance

      Attachments

        1. HIVE-20223.1.patch
          2 kB
          David Mollitor

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            belugabehr David Mollitor Assign to me
            belugabehr David Mollitor
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment