[HIVE-20219] verify that analyze and analyze for columns manage txn stats state correctly

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 4.0.0-alpha-1
• Assignee: Sergey Shelukhin
• Reporter: Sergey Shelukhin
• Created: 20/Jul/18 22:19
• Updated: 17/Nov/22 08:54
• Resolved: 21/Jul/18 00:42

Description

Discovered while adding tests in HIVE-20029

Step 1. Have a table with fully correct txn stats.
Step 2. Run some query that sets stats to invalid (e.g. parallel inserts).
Step 3. Run analyze without for columns...

Result is that while only basic stats are updated, the flag is set to true with old column stats values.
I blame json; if stats state was stored in proper places this kind of bug would be very unlikely.
Not sure if this would affect master, I'll add a test; ACID stats invalidation definitely needs to invalidate all the stats, not just basic stats flag, when invalidating.