Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-2017

Driver.execute() should maintaining SessionState in case of runtime errors

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Not A Problem
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      Here's a snippet from Driver.execute():

                  // TODO: This error messaging is not very informative. Fix that.
                  errorMessage = "FAILED: Execution Error, return code " + exitVal + " from "
                      + tsk.getClass().getName();
                  SQLState = "08S01";
                  console.printError(errorMessage);
                  if (running.size() != 0) {
                    taskCleanup();
                  }
                  return 9;
      

      I simply returned in case of runtime errors without maintaining SessionState. It could cause resource leak mentioned in HIVE-1959.

        Attachments

        1. HIVE-2017.1.patch
          9 kB
          Chinna Rao Lalam
        2. HIVE-2017.2.patch
          9 kB
          Chinna Rao Lalam
        3. HIVE-2017.3.patch
          9 kB
          Chinna Rao Lalam
        4. HIVE-2017.4.patch
          10 kB
          Chinna Rao Lalam

          Issue Links

            Activity

              People

              • Assignee:
                chinnalalam Chinna Rao Lalam
                Reporter:
                nzhang Ning Zhang
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: