Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-20166

LazyBinaryStruct Warn Level Logging

    Details

      Description

      https://github.com/apache/hive/blob/6d890faf22fd1ede3658a5eed097476eab3c67e9/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryStruct.java#L177-L180

          // Extra bytes at the end?
          if (!extraFieldWarned && lastFieldByteEnd < structByteEnd) {
            extraFieldWarned = true;
            LOG.warn("Extra bytes detected at the end of the row! " +
                 "Last field end " + lastFieldByteEnd + " and serialize buffer end " + structByteEnd + ". " +
                     "Ignoring similar problems.");
          }
      
          // Missing fields?
          if (!missingFieldWarned && lastFieldByteEnd > structByteEnd) {
            missingFieldWarned = true;
            LOG.info("Missing fields! Expected " + fields.length + " fields but " +
                    "only got " + fieldId + "! " +
                "Last field end " + lastFieldByteEnd + " and serialize buffer end " + structByteEnd + ". " +
                "Ignoring similar problems.");
          }
      

      The first log statement is a 'warn' level logging, the second is an 'info' level logging. Please change the second log to also be a 'warn'. This seems like it could be a problem that the user would like to know about.

        Attachments

        1. HIVE-20166.1.patch
          0.9 kB
          Anurag Mantripragada

          Activity

            People

            • Assignee:
              anuragmantri Anurag Mantripragada
              Reporter:
              belugabehr David Mollitor
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: